From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD0BC433EF for ; Tue, 26 Oct 2021 11:55:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B425160F0F for ; Tue, 26 Oct 2021 11:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235672AbhJZL50 (ORCPT ); Tue, 26 Oct 2021 07:57:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235679AbhJZL5Q (ORCPT ); Tue, 26 Oct 2021 07:57:16 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DECA8C061225 for ; Tue, 26 Oct 2021 04:54:49 -0700 (PDT) Received: from [192.168.1.111] (91-158-153-130.elisa-laajakaista.fi [91.158.153.130]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B17CD3F0; Tue, 26 Oct 2021 13:54:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1635249288; bh=ggHeYahoS2RHmAuvX8GxcaHPSqZuA65tApA2UmZ/gDY=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=rg9f1Z4mTWafNjvlmiqNZR57QK194a1l/HC/GFI2Ybb/ea7QGBFL+TWx2GXiZyVG1 WL5vK1aUvlvRyDzbXMumSChQd2u+Uf43+oA1fOuybGIlGFfY1AuESs6K6nouac+zOM Q84eG6BfHqjUbjG9n0Hzxt5OkYA1DdMpQSIgkYOU= To: Hans Verkuil , linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, Jacopo Mondi , Laurent Pinchart , niklas.soderlund+renesas@ragnatech.se Cc: Mauro Carvalho Chehab , Pratyush Yadav References: <20211005085750.138151-1-tomi.valkeinen@ideasonboard.com> <6c1dfc4d-ec8a-6643-b768-5fe507da495d@xs4all.nl> From: Tomi Valkeinen Subject: Re: [PATCH v9 00/36] v4l: subdev internal routing and streams Message-ID: <60c9509b-6f39-8492-065d-72918670d49f@ideasonboard.com> Date: Tue, 26 Oct 2021 14:54:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <6c1dfc4d-ec8a-6643-b768-5fe507da495d@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Hans, On 11/10/2021 18:29, Hans Verkuil wrote: > Hi Tomi, > > On 05/10/2021 10:57, Tomi Valkeinen wrote: >> Hi, >> >> This is v9 of the multiplexed streams series. v8 can be found from: >> >> https://lore.kernel.org/all/20210830110116.488338-1-tomi.valkeinen@ideasonboard.com/ >> >> I have pushed my work branch to: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git multistream/work-v9 >> >> which contains the patches in this series, along with subdev drivers >> using multiplexed streams. >> >> As can be guessed from the work branch, I have been testing this series >> with TI's FPDLink setup. I have also done a "backwards compatibility" >> test by dropping all multiplexed streams patches from the CAL driver >> (the CSI-2 RX on the TI SoC), and using the FPDLink drivers with >> single-stream configuration. > > I hope to look at this series this week (fingers crossed), but I was asked to > give some input w.r.t. testing of this series: Thanks for the reviews! I'll start updating the series accordingly. > I think before this can be merged we need: > > 1) libcamera tests. Since libcamera would probably be the most active user of this > API, and you have HW for it, it makes a lot of sense that there are decent tests > for the supported HW in libcamera. That takes care of the real-world tests. I agree, libcamera would be a good userspace test. Laurent has been working on that. > 2) obviously the existing utils in v4l-utils need to be adapted to understand any > new API elements. Yes. I think it's "just" two things that are needed: ability to set a routing table (that might be quite messy via the cmdline for larger routing tables) and ability to set format and other parameters with a (pad,stream) tuple, instead of just pad. > 3) compliance tests in v4l2-compliance for the new API. After I did a review of the > series we can see to what extent this is possible. One thing we have to fix are the problems caused by adding the 'stream' field to many structs, but I think fixing that is trivial. Actually testing routing and streams is a bit more difficult. > 4) optionally (for now at least, I reserve the right to change my mind): it would > be very helpful if this can be added to vimc (or something similar), allowing for > testing the API without having real hardware, which is useful both for writing > the tests and for running regression tests regularly on a simple VM, without needing > special hardware. I haven't studied the vimc code, but maybe a metadata stream would be an easy addition. Tomi