All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Harrison McCullough <mccullough.harrison@gmail.com>, git@vger.kernel.org
Subject: RE: Error in bash completion
Date: Wed, 16 Jun 2021 21:06:39 -0500	[thread overview]
Message-ID: <60caae2f893ec_894e2085d@natae.notmuch> (raw)
In-Reply-To: <CAHLeu+y3DxLv7M4SM2f5yVxtKXbpAWD7Ad2m+rVKpKfKiA6PVw@mail.gmail.com>

Harrison McCullough wrote:
> What did you do before the bug happened? (Steps to reproduce your issue)
> 
> 1. Create a Bash function, e.g. `ga() { git add "${@:-.}"; }`
> 2. Use the `__git_complete` function to add Bash tab completion for your custom
>    Bash function, e.g. `__git_complete ga git_add`
> 3. Attempt to tab complete a file path, e.g. `ga my-incomplete-file-path<TAB>`

I can reproduce this issue; it's caused by 59d85a2a05
(git-completion.bash: use $__git_cmd_idx in more places, 2021-04-22)
which is present in v2.32.

The problem is that __git_find_on_cmdline now relies on __git_cmd_idx,
which is not defined when you do __git_complete.

The solution is to add __git_cmd_idx=1 to __git_func_wrap.

zsh is also broken by the same change, and the fix is to do the same in
the _git service.

I've fixed this in git-completion's master branch [1].

You are welcome to trying the fix.

Cheers.

[1] https://github.com/felipec/git-completion/commit/95b3b49
[2] https://github.com/git/git/commit/59d85a2a05

-- 
Felipe Contreras

  parent reply	other threads:[~2021-06-17  2:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 15:44 Harrison McCullough
2021-06-16 17:40 ` Denton Liu
2021-06-16 18:05   ` Harrison McCullough
2021-06-16 19:19   ` Felipe Contreras
2021-06-17  2:06 ` Felipe Contreras [this message]
2021-06-17  2:15   ` Harrison McCullough

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60caae2f893ec_894e2085d@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mccullough.harrison@gmail.com \
    --subject='RE: Error in bash completion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.