From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Zfy-0000t0-FO for qemu-devel@nongnu.org; Wed, 25 May 2016 10:20:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Zfu-0002XL-41 for qemu-devel@nongnu.org; Wed, 25 May 2016 10:20:45 -0400 References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-28-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <60d13e6a-8b72-6ab9-1a9f-1010f5e7a4a5@redhat.com> Date: Wed, 25 May 2016 16:20:28 +0200 MIME-Version: 1.0 In-Reply-To: <1463470536-8981-28-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RD4jusmEaDn6M58oE42bKkgEiqRPE6rXw" Subject: Re: [Qemu-devel] [PATCH v5 27/27] qemu-iotests: Add test case 153 for image locking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RD4jusmEaDn6M58oE42bKkgEiqRPE6rXw From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com Message-ID: <60d13e6a-8b72-6ab9-1a9f-1010f5e7a4a5@redhat.com> Subject: Re: [PATCH v5 27/27] qemu-iotests: Add test case 153 for image locking References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-28-git-send-email-famz@redhat.com> In-Reply-To: <1463470536-8981-28-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.05.2016 09:35, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/153 | 197 +++++++++++++++++++++ > tests/qemu-iotests/153.out | 426 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 624 insertions(+) > create mode 100755 tests/qemu-iotests/153 > create mode 100644 tests/qemu-iotests/153.out >=20 > diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 > new file mode 100755 > index 0000000..cbeda8e > --- /dev/null > +++ b/tests/qemu-iotests/153 [...] > +for opts1 in "" "readonly=3Don" "lock-mode=3Doff" "lock-mode=3Dshared"= ; do > + echo > + echo "=3D=3D Creating base image =3D=3D" > + TEST_IMG=3D"${TEST_IMG}.base" _make_test_img $size > + > + echo > + echo "=3D=3D Creating test image =3D=3D" > + $QEMU_IMG create -f $IMGFMT "${TEST_IMG}" -b ${TEST_IMG}.base | _f= ilter_img_create _make_test_img understands -b, so maybe you want to use it here. Also I'm not sure why you're creating the images inside of this loop, but it certainly isn't wrong. But maybe you want to add a line that echos $opts1 somewhere here. However you decide: Reviewed-by: Max Reitz --RD4jusmEaDn6M58oE42bKkgEiqRPE6rXw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXRbStAAoJEDuxQgLoOKytlHsH/A3+Qi+AbiyPOsFMTODuUdHO 2hyXUVPuRDLpdqsGOGDAJk/Q9Iyfg34EnmSVhzdsLReWSopWY6BzyiZWceBb9izo dWqfFtjHtTKBzMw36eq+s1/Mfk27hoEwayrGxBpMrKPChuFq6VLNE/zLsHBEg8r1 Eb+3nN+bJxCehqw3wG3JXSLHDrlEeRd1T1UdwXmRdh940+GkZoqbMWDnu7e7uMJu wwb6Bc5zUoK6Zrv54p+DXL7wRfUc4066CgvHROwtAcwh1uhR1aKUXW+r3QCj2oPh p9zA1C6kqjNlPTGSTicrwU3IYbOZJFGzPkC96oWcUU9dzbDSFsc29hjnbOwEx24= =Fpr9 -----END PGP SIGNATURE----- --RD4jusmEaDn6M58oE42bKkgEiqRPE6rXw--