From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: RE: [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag
Date: Wed, 23 Jun 2021 14:21:52 -0500 [thread overview]
Message-ID: <60d389d015943_4290208ae@natae.notmuch> (raw)
In-Reply-To: <patch-1.1-9420448e74f-20210622T141100Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> @@ -2243,7 +2253,6 @@ SCRIPT_DEFINES = $(SHELL_PATH_SQ):$(DIFF_SQ):$(GIT_VERSION):\
> $(gitwebdir_SQ):$(PERL_PATH_SQ):$(SANE_TEXT_GREP):$(PAGER_ENV):\
> $(perllibdir_SQ)
> define cmd_munge_script
> -$(RM) $@ $@+ && \
> sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
> -e 's|@SHELL_PATH@|$(SHELL_PATH_SQ)|' \
> -e 's|@@DIFF@@|$(DIFF_SQ)|' \
Any reason why the same isn't done for the $(BUILT_INS) target?
> @@ -2514,7 +2522,6 @@ endif
> ifeq ($(GENERATE_COMPILATION_DATABASE),yes)
> all:: compile_commands.json
> compile_commands.json:
> - @$(RM) $@
> $(QUIET_GEN)sed -e '1s/^/[/' -e '$$s/,$$/]/' $(compdb_dir)/*.o.json > $@+
> @if test -s $@+; then mv $@+ $@; else $(RM) $@+; fi
> endif
What about these?
$(REMOTE_CURL_ALIASES):
$(LIB_FILE):
$(XDIFF_LIB):
$(ETAGS_TARGET):
tags:
cscope:
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-23 19:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:13 [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag Ævar Arnfjörð Bjarmason
2021-06-22 15:27 ` Taylor Blau
2021-06-22 17:34 ` Ævar Arnfjörð Bjarmason
2021-06-22 19:17 ` Jeff King
2021-06-23 19:54 ` Ævar Arnfjörð Bjarmason
2021-06-23 22:21 ` Jeff King
2021-06-24 13:53 ` Ævar Arnfjörð Bjarmason
2021-06-24 14:49 ` Jeff King
2021-06-25 9:49 ` Ævar Arnfjörð Bjarmason
2021-06-29 2:26 ` Jeff King
2021-06-29 6:19 ` Junio C Hamano
2021-06-29 7:39 ` Ævar Arnfjörð Bjarmason
2021-06-29 21:38 ` Junio C Hamano
2021-06-30 2:23 ` Jeff King
2021-07-01 3:54 ` Felipe Contreras
2021-07-01 13:34 ` Ævar Arnfjörð Bjarmason
2021-07-03 0:41 ` Felipe Contreras
2021-07-03 12:31 ` Ævar Arnfjörð Bjarmason
2021-07-03 18:42 ` Felipe Contreras
2021-06-23 19:15 ` Felipe Contreras
2021-06-23 19:09 ` Felipe Contreras
2021-06-23 19:01 ` Felipe Contreras
2021-06-23 19:45 ` Ævar Arnfjörð Bjarmason
2021-06-23 20:32 ` Felipe Contreras
2021-06-29 7:29 ` Ævar Arnfjörð Bjarmason
2021-07-01 3:06 ` Felipe Contreras
2021-06-23 19:21 ` Felipe Contreras [this message]
2021-06-23 19:59 ` Ævar Arnfjörð Bjarmason
2021-06-23 20:52 ` Felipe Contreras
2021-06-29 8:17 ` Ævar Arnfjörð Bjarmason
2021-07-01 3:19 ` Felipe Contreras
2021-06-29 8:44 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-08-18 21:36 ` [PATCH] Makefile: remove archives before manipulating them with 'ar' SZEDER Gábor
2021-08-19 23:39 ` Junio C Hamano
2021-09-01 17:06 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d389d015943_4290208ae@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.