From: Felipe Contreras <felipe.contreras@gmail.com>
To: Elijah Newren <newren@gmail.com>, Alex Henrie <alexhenrie24@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH] pull: abort by default if fast-forwarding is impossible
Date: Sat, 26 Jun 2021 23:16:55 -0500 [thread overview]
Message-ID: <60d7fbb770397_b8dfe2087d@natae.notmuch> (raw)
In-Reply-To: <CABPp-BGko7BP6ZMyRKwKrv0xz7FM9ehe67HSAtzgHF9eV2TD3A@mail.gmail.com>
Elijah Newren wrote:
> The code changes look good, but you'll need to add several test
> changes as well, or this code change will cause test failures.
Wouldn't you consider sending a patch without running 'make test'
"cavalier"?
> Thanks for working on this.
Such a completely different tone for a "cavalier" patch depending 100%
on the person who sent it. Weird.
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-27 4:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 0:08 [PATCH] pull: abort by default if fast-forwarding is impossible Alex Henrie
2021-06-27 1:34 ` Elijah Newren
2021-06-27 4:16 ` Felipe Contreras [this message]
2021-06-27 7:49 ` Elijah Newren
2021-06-27 16:46 ` Felipe Contreras
2021-06-27 19:54 ` Alex Henrie
2021-06-27 21:29 ` Felipe Contreras
2021-06-28 10:31 ` Ævar Arnfjörð Bjarmason
2021-06-28 17:39 ` Felipe Contreras
2021-06-27 4:12 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d7fbb770397_b8dfe2087d@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.