From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for
 RGMII mode
Date: Tue, 19 Feb 2019 13:41:37 +0100
Message-ID: <60e0143b-9032-4c31-0dbb-9f2518f79601@free.fr>
References: <20190219061800.31025-1-vkoul@kernel.org>
 <20190219061800.31025-3-vkoul@kernel.org>
 <1dddc455-309d-5e7d-ca26-479fe800a013@free.fr>
 <20190219123339.GA13172@centauri.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <netdev-owner@vger.kernel.org>
In-Reply-To: <20190219123339.GA13172@centauri.lan>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>, David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>, MSM <linux-arm-msm@vger.kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Nori Sekhar <nsekhar@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>
List-Id: linux-arm-msm@vger.kernel.org

On 19/02/2019 13:33, Niklas Cassel wrote:

> However, since the bootloader might have enabled delay on
> TX, I still think that this patch does the right thing by
> starting out with disabling delays for both RX and TX.
> 
> But we should probably make the comment more elaborate:
> 
> The value after HW reset is RX delay enabled and TX delay disabled.
> The value after SW reset is RX delay enabled, while TX delay retains
> the value before reset.
> In order to not depend on reset values, start off by disabling both
> delays.

Ultimately, the two patches do the same thing, AFAICT ;-)

I was just arguing that my way was better because... errr... because
it was my way! :-)

Regards.