From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Date: Fri, 7 May 2021 16:55:13 +0200 Subject: [PATCH] usb: dwc3-meson-g12a: skip phy on -ENODATA aswell In-Reply-To: <71f9ffcc-58bf-9e74-fe15-ffab5d4fe248@denx.de> References: <20210505084150.3862010-1-narmstrong@baylibre.com> <71f9ffcc-58bf-9e74-fe15-ffab5d4fe248@denx.de> Message-ID: <60e0e17e-1d81-df5f-3e5e-71bd18ab7e90@baylibre.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/05/2021 12:06, Marek Vasut wrote: > On 5/5/21 10:41 AM, Neil Armstrong wrote: >> If the PHY isn't specified in the DT, -ENODATA means it should be skipped, >> handle it like -ENOENT. >> >> With that, devices without USB3 supported can have USB working (Odroid-HC4). > > Shouldn't you rather specify NOP PHY in the DT ? Who NOP I would have no idea if the port is disabled or used. The PHY control is mixed between the actual PHY driver and the DWC3/DWC2 glue, so the bindings were designed to make some PHYs phandle optionals if unused. Neil