All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,
	davem@davemloft.net, netdev@vger.kernel.org,
	rshearma@brocade.com, eric.dumazet@gmail.com
Cc: Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with udp_l3mdev_accept=0
Date: Tue, 18 Apr 2017 09:59:30 -0600	[thread overview]
Message-ID: <60e43d02-035e-6536-4284-1c5b31c696ab@cumulusnetworks.com> (raw)
In-Reply-To: <1492471495-13073-1-git-send-email-subashab@codeaurora.org>

On 4/17/17 5:24 PM, Subash Abhinov Kasiviswanathan wrote:
> David Ahern reported that 5425077d73e0c ("net: ipv6: Add early demux
> handler for UDP unicast") breaks udp_l3mdev_accept=0 since early
> demux for IPv6 UDP was doing a generic socket lookup which does not
> require an exact match. Fix this by making UDPv6 early demux match
> connected sockets only.
> 
> v1->v2: Take reference to socket after match as suggested by Eric
> 
> Fixes: 5425077d73e0c ("net: ipv6: Add early demux handler for UDP unicast")
> Reported-by: David Ahern <dsa@cumulusnetworks.com>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
> Cc: Eric Dumazet <edumazet@google.com>
> ---
>  net/ipv6/udp.c | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)

Besides adding the comment before the break, this looks fine to me.

Acked-by: David Ahern <dsa@cumulusnetworks.com>
Tested-by: David Ahern <dsa@cumulusnetworks.com>

If the only change for v3 is the comment before the break, please keep
the above with the new patch.

      parent reply	other threads:[~2017-04-18 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 23:24 [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with udp_l3mdev_accept=0 Subash Abhinov Kasiviswanathan
2017-04-17 23:51 ` YUAN Linyu
2017-04-18  1:07   ` Subash Abhinov Kasiviswanathan
2017-04-18 15:46     ` David Ahern
2017-04-18 15:59 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60e43d02-035e-6536-4284-1c5b31c696ab@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rshearma@brocade.com \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.