From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B1EC433E7 for ; Wed, 2 Sep 2020 16:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07CDD20767 for ; Wed, 2 Sep 2020 16:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="MbZXF4kH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727970AbgIBQvM (ORCPT ); Wed, 2 Sep 2020 12:51:12 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:54248 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgIBQvK (ORCPT ); Wed, 2 Sep 2020 12:51:10 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 082Gp5Pi033319; Wed, 2 Sep 2020 11:51:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599065465; bh=dDTC0gpdXie8DL9+hkg/Fiz8VsxEy70PtTPaF9NGk88=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=MbZXF4kHAWsQrSOmCIKVq4M7gPmwVSHjYUy0LvUa0K1wiYX8R+md9/hnxngJrx/im q5371/6H3GfnClaIE2TUPU5Zl8O10v6Mc7NcxK9UxW9DjlEd3Rxwn0MkxZ3pYwnltx VO2LyhJUciRtsGOWOtSKDP2PKL2/9s1z7C4igTAE= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 082Gp4eq095150 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Sep 2020 11:51:05 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 2 Sep 2020 11:51:04 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 2 Sep 2020 11:51:04 -0500 Received: from [10.250.34.112] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 082Gp4rc046690; Wed, 2 Sep 2020 11:51:04 -0500 Subject: Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names To: Nishanth Menon , Rob Herring , Tero Kristo CC: , , , Vignesh Raghavendra , , , References: <20200901223059.14801-1-nm@ti.com> <20200901223059.14801-7-nm@ti.com> From: Suman Anna Message-ID: <60e6b790-360a-6eaf-03a3-5bb256adf215@ti.com> Date: Wed, 2 Sep 2020 11:51:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200901223059.14801-7-nm@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/1/20 5:30 PM, Nishanth Menon wrote: > Use adc@ naming for nodes following standard conventions of device > tree (section 2.2.2 Generic Names recommendation in [1]). > > [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3 > > Suggested-by: Suman Anna > Signed-off-by: Nishanth Menon > --- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 51ca4b4d4c21..6dfec68ac865 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -80,7 +80,7 @@ > #size-cells = <0>; > }; > > - tscadc0: tscadc@40200000 { > + tscadc0: adc@40200000 { OK with these changes, since these seem to be only have the adc child nodes. This node is essentially a parent node for touchscreen and adc child nodes. The driver is currently looking for "tsc" on touchscreen child nodes, but none of the K3 SoCs have them atm. regards Suman > compatible = "ti,am654-tscadc", "ti,am3359-tscadc"; > reg = <0x0 0x40200000 0x0 0x1000>; > interrupts = ; > @@ -98,7 +98,7 @@ > }; > }; > > - tscadc1: tscadc@40210000 { > + tscadc1: adc@40210000 { > compatible = "ti,am654-tscadc", "ti,am3359-tscadc"; > reg = <0x0 0x40210000 0x0 0x1000>; > interrupts = ; > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > index 9ad0266598ad..81801f519a61 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > @@ -211,7 +211,7 @@ > }; > }; > > - tscadc0: tscadc@40200000 { > + tscadc0: adc@40200000 { > compatible = "ti,am3359-tscadc"; > reg = <0x0 0x40200000 0x0 0x1000>; > interrupts = ; > @@ -230,7 +230,7 @@ > }; > }; > > - tscadc1: tscadc@40210000 { > + tscadc1: adc@40210000 { > compatible = "ti,am3359-tscadc"; > reg = <0x0 0x40210000 0x0 0x1000>; > interrupts = ; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EE9C433E2 for ; Wed, 2 Sep 2020 16:52:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D81320767 for ; Wed, 2 Sep 2020 16:52:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yRDd4tPB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="MbZXF4kH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D81320767 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eO2ObbGLC+ANXKsLCLq6qhmpwQWHZtd24tCF6gT08xk=; b=yRDd4tPBbhAUmRSk+YQIhlIL5 mukutI/NkkO1jtuA1q4VAYAc5loEweE8STvIIrJlj2aiXShkDwuMAggKKk6MvmcO8rpivvWERoJ9M GNVcJKPFcp2cvNND3eWvxyOQi5dDRM7Y0ImX2uPxPQnRCSDDfW3/a9nNOwYy7k7dHlQMsjn6zwMMR QtiJ51pGkUS5l9vCLmxc9iW/G4FjB9gE2dziUX0Mf0BtEAtmbdvaqF20bp4Qs5YOpKACjy/QguFG7 TqlpbxK+2cISNYi4csvYxAf+G0v20aJjtRZ18gjjX3PgBIN7N2KAA9IXSFsml/GnPw+aUfPi9kApO mZ3TN1ADQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDVyZ-0001MH-Gr; Wed, 02 Sep 2020 16:51:11 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDVyV-0001L0-VV for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 16:51:09 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 082Gp5Pi033319; Wed, 2 Sep 2020 11:51:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599065465; bh=dDTC0gpdXie8DL9+hkg/Fiz8VsxEy70PtTPaF9NGk88=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=MbZXF4kHAWsQrSOmCIKVq4M7gPmwVSHjYUy0LvUa0K1wiYX8R+md9/hnxngJrx/im q5371/6H3GfnClaIE2TUPU5Zl8O10v6Mc7NcxK9UxW9DjlEd3Rxwn0MkxZ3pYwnltx VO2LyhJUciRtsGOWOtSKDP2PKL2/9s1z7C4igTAE= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 082Gp4eq095150 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Sep 2020 11:51:05 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 2 Sep 2020 11:51:04 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 2 Sep 2020 11:51:04 -0500 Received: from [10.250.34.112] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 082Gp4rc046690; Wed, 2 Sep 2020 11:51:04 -0500 Subject: Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names To: Nishanth Menon , Rob Herring , Tero Kristo References: <20200901223059.14801-1-nm@ti.com> <20200901223059.14801-7-nm@ti.com> From: Suman Anna Message-ID: <60e6b790-360a-6eaf-03a3-5bb256adf215@ti.com> Date: Wed, 2 Sep 2020 11:51:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200901223059.14801-7-nm@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_125108_135092_0C1CF396 X-CRM114-Status: GOOD ( 16.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, grygorii.strashko@ti.com, Vignesh Raghavendra , lokeshvutla@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/1/20 5:30 PM, Nishanth Menon wrote: > Use adc@ naming for nodes following standard conventions of device > tree (section 2.2.2 Generic Names recommendation in [1]). > > [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3 > > Suggested-by: Suman Anna > Signed-off-by: Nishanth Menon > --- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 51ca4b4d4c21..6dfec68ac865 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -80,7 +80,7 @@ > #size-cells = <0>; > }; > > - tscadc0: tscadc@40200000 { > + tscadc0: adc@40200000 { OK with these changes, since these seem to be only have the adc child nodes. This node is essentially a parent node for touchscreen and adc child nodes. The driver is currently looking for "tsc" on touchscreen child nodes, but none of the K3 SoCs have them atm. regards Suman > compatible = "ti,am654-tscadc", "ti,am3359-tscadc"; > reg = <0x0 0x40200000 0x0 0x1000>; > interrupts = ; > @@ -98,7 +98,7 @@ > }; > }; > > - tscadc1: tscadc@40210000 { > + tscadc1: adc@40210000 { > compatible = "ti,am654-tscadc", "ti,am3359-tscadc"; > reg = <0x0 0x40210000 0x0 0x1000>; > interrupts = ; > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > index 9ad0266598ad..81801f519a61 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > @@ -211,7 +211,7 @@ > }; > }; > > - tscadc0: tscadc@40200000 { > + tscadc0: adc@40200000 { > compatible = "ti,am3359-tscadc"; > reg = <0x0 0x40200000 0x0 0x1000>; > interrupts = ; > @@ -230,7 +230,7 @@ > }; > }; > > - tscadc1: tscadc@40210000 { > + tscadc1: adc@40210000 { > compatible = "ti,am3359-tscadc"; > reg = <0x0 0x40210000 0x0 0x1000>; > interrupts = ; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel