From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbdAQQjL (ORCPT ); Tue, 17 Jan 2017 11:39:11 -0500 Received: from mout.web.de ([212.227.17.12]:55772 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbdAQQjG (ORCPT ); Tue, 17 Jan 2017 11:39:06 -0500 Subject: Re: [PATCH 15/46] selinux: One check and function call less in genfs_read() after error detection To: Casey Schaufler , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov References: Cc: Eric Paris , James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <60ed4f02-4ff8-2ef2-bcc3-ae62bc61cda9@users.sourceforge.net> Date: Tue, 17 Jan 2017 17:37:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:L3lvULT1znSKYsqtMB2QvgP9nmRHBGahhLqYhAiyebAIY6yOR5/ up4oEMiEPY9gfLTAZ0VBUeZf+18SWKFqv5dGDALj1Px3RvHtvYtOVnLkL8F+Q5CZXhzwCGI jprYiiWigdXkU2QH4yxJIHUs8YLsusE4eK7TwELm1B0Gd58YscGNWD6fuHz6QEBeiFAfXly oOC9Mx5UyPalsGH1ZVEQQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Hor4Rs2z8vc=:p87sJrVbIO6MjDbnJttlUM MgNJHcg52SoHJpZ0oUIvbcII1Xf5NAQS02s96X1Agevq7nNxGBW3oXtPdGnKrn0BQlkBibVS8 IKovU+5eKqXoWKYphAbVU7/Ce4X+ZqbG/7vbf+1ltvppUxfh8ezUIeWXQIxfbLNENMTdF6UJo AK/G07VIjnp4bnYcI1ozzsM/IsrVpPZERhC+fIWbsoAVpGgW11wVRGs1XDS5XWokEswdZTt0x 78AMFa9u6AYBFQXZ+MJY1fYR4KFGrIGKd0hSghLV60Ur5YUQwBpKolx9vq8uBOZlRKPt6bp1A GI6T/NI7Mo8SYeS9YVnF2u5M1cOFqF5Sz2geBJN282d6yJMf+KTiG332P0ZvgF1+7hRtbkNBK d4skTxCDlBNyxDlDqbKP/K84Z3lwnzkCrXng0/j4gbCRNuJqlmX2XseiGrJ7cR8HO5iD60dgp Tuaq3mesZN3pH06FxBGIHEtCuRjDo+f22/GbrryGGqHcmRmtm7o9M04m8bABDcCeqs7E8VyZ8 JCz8h8grrKUjj/pvmtrmB/PcqHR4LzeEttUdBHQ3MexezPHeL2ZVYOAYDGKbguZ35v0w/SUtT vG9+cBcBUL8xkLfB6MxLNg/yl/m7jEjISgYNMBHdpX+0A/QAZG3zOPTbDsm9SBhdTb4FvQP4F rGKin6agLl4U/KvbMhezXuD4497rfAqPK8qSeANacDT2UNXlYymIu0vlCYRK1EuD+faOZw5D2 6WoYBjQ3VmITWNMGXT+vMTmAc/bJmdWISk28TN1OVHyQ452d0NTfFItY0Huy4W/y3yJT2e3Gv gST7AAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> @@ -2015,7 +2015,7 @@ static int genfs_read(struct policydb *p, void *fp) >> newgenfs = kzalloc(sizeof(*newgenfs), GFP_KERNEL); >> if (!newgenfs) { >> rc = -ENOMEM; >> - goto out; >> + goto exit; >> } >> >> rc = str_read(&newgenfs->fstype, GFP_KERNEL, fp, len); >> @@ -2101,7 +2101,7 @@ static int genfs_read(struct policydb *p, void *fp) >> kfree(newgenfs); >> } >> ocontext_destroy(newc, OCON_FSUSE); >> - >> +exit: >> return rc; > > Why not replace the "goto out" with "return rc" rather > than add a target? Would you accept to use the statement "return -ENOMEM;" there instead? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 17 Jan 2017 16:37:41 +0000 Subject: Re: [PATCH 15/46] selinux: One check and function call less in genfs_read() after error detection Message-Id: <60ed4f02-4ff8-2ef2-bcc3-ae62bc61cda9@users.sourceforge.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Casey Schaufler , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov Cc: Eric Paris , James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org >> @@ -2015,7 +2015,7 @@ static int genfs_read(struct policydb *p, void *fp) >> newgenfs = kzalloc(sizeof(*newgenfs), GFP_KERNEL); >> if (!newgenfs) { >> rc = -ENOMEM; >> - goto out; >> + goto exit; >> } >> >> rc = str_read(&newgenfs->fstype, GFP_KERNEL, fp, len); >> @@ -2101,7 +2101,7 @@ static int genfs_read(struct policydb *p, void *fp) >> kfree(newgenfs); >> } >> ocontext_destroy(newc, OCON_FSUSE); >> - >> +exit: >> return rc; > > Why not replace the "goto out" with "return rc" rather > than add a target? Would you accept to use the statement "return -ENOMEM;" there instead? Regards, Markus