All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Luke Shumaker <lukeshu@lukeshu.com>,
	Junio C Hamano <gitster@pobox.com>,
	Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH v3 1/1] completion: graduate out of contrib
Date: Thu, 15 Jul 2021 14:12:48 -0500	[thread overview]
Message-ID: <60f088b054e74_519c2084d@natae.notmuch> (raw)
In-Reply-To: <878s28zdmz.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> 
> On Thu, Jul 15 2021, Ævar Arnfjörð Bjarmason wrote:
> 
> > On Wed, Jul 14 2021, Felipe Contreras wrote:
> >> [...]
> >> @@ -2399,7 +2399,7 @@ test_expect_success 'sourcing the completion script clears cached --options' '
> >>  	verbose test -n "$__gitcomp_builtin_checkout" &&
> >>  	__gitcomp_builtin notes_edit &&
> >>  	verbose test -n "$__gitcomp_builtin_notes_edit" &&
> >> -	. "$GIT_BUILD_DIR/contrib/completion/git-completion.bash" &&
> >> +	. "$GIT_BUILD_DIR/extra/completion/git-completion.bash" &&
> >>  	verbose test -z "$__gitcomp_builtin_checkout" &&
> >>  	verbose test -z "$__gitcomp_builtin_notes_edit"
> >>  '
> >>
> >> diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh
> >> index bbd513bab0..784e523fd4 100755
> >> --- a/t/t9903-bash-prompt.sh
> >> +++ b/t/t9903-bash-prompt.sh
> >> @@ -10,7 +10,7 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
> >>  
> >>  . ./lib-bash.sh
> >>  
> >> -. "$GIT_BUILD_DIR/contrib/completion/git-prompt.sh"
> >> +. "$GIT_BUILD_DIR/extra/completion/git-prompt.sh"
> >>  
> >>  actual="$TRASH_DIRECTORY/actual"
> >>  c_red='\\[\\e[31m\\]'
> >
> > It's more of a "for bonus points", but a nic way to round-trip this
> > would be to make this work with GIT_TEST_INSTALLED.
> >
> > I.e. source these relative to GIT_EXEC_PATH, not $GIT_BUILD_DIR, I think
> > that just sourcing them as e.g.:
> >
> >     . git-completion.bash
> >
> > But the GIT_TEST_INSTALLED case is tricker, maybe we'd need to add a
> > "git --share-path" :(
> 
> I forgot to include this not-working patch, i.e. I've got no idea what
> the "something" should be other than the harder thing of compiling
> "sharedir" into git and making "git --share-path" work.

I don't think there's a "something" that would make sense.

It would be something like '/opt/git/bin/completion'?

-- 
Felipe Contreras

  reply	other threads:[~2021-07-15 19:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 23:46 [PATCH v2 0/2] extra: new concept of extra components Felipe Contreras
2021-07-10 23:46 ` [PATCH v2 1/2] completion: graduate out of contrib Felipe Contreras
2021-07-10 23:46 ` [PATCH v2 2/2] git-new-workdir: " Felipe Contreras
2021-07-12 17:43 ` [PATCH v2 0/2] extra: new concept of extra components Philippe Blain
2021-07-12 17:55   ` Felipe Contreras
2021-07-13  0:17   ` Junio C Hamano
2021-07-13  1:19     ` Felipe Contreras
2021-07-14 20:23 ` [PATCH v3 0/1] " Felipe Contreras
2021-07-14 20:23   ` [PATCH v3 1/1] completion: graduate out of contrib Felipe Contreras
2021-07-14 23:03     ` Ævar Arnfjörð Bjarmason
2021-07-14 23:17       ` Ævar Arnfjörð Bjarmason
2021-07-15 19:12         ` Felipe Contreras [this message]
2021-07-16  6:36           ` Ævar Arnfjörð Bjarmason
2021-07-16 20:14             ` Felipe Contreras
2021-07-15 18:59       ` Felipe Contreras
2021-07-16 20:14 ` [PATCH v4 0/1] extra: new concept of extra components Felipe Contreras
2021-07-16 20:14   ` [PATCH v4 1/1] completion: graduate out of contrib Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60f088b054e74_519c2084d@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=levraiphilippeblain@gmail.com \
    --cc=lukeshu@lukeshu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.