Re: [PATCH] drm: actually remove the newline for CRC source name.

[Harry Wentland <hwentlan@amd.com>]

Thanks for the quick follow-up to Sam.

Drop the word "actually" from the patch subject line.

It's generally helpful to generate a 2nd version of the patch with '-v
2', and to leave a description what v2 changed.

Also CC anyone who previously commented.

On 2019-06-05 2:35 p.m., Dingchen Zhang wrote:
> 'n-1' is the index to replace the newline character of CRC source name.
> 

Add here:
v2: Update patch subject (Sam)

> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Harry Wentland<Harry.Wentland@amd.com>
> Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com>
> ---
>  drivers/gpu/drm/drm_debugfs_crc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
> index 585169f0dcc5..e20adef9d623 100644
> --- a/drivers/gpu/drm/drm_debugfs_crc.c
> +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
>  	if (IS_ERR(source))
>  		return PTR_ERR(source);
>  
> -	if (source[len] == '\n')
> -		source[len] = '\0';
> +	if (source[len-1] == '\n')
> +		source[len-1] = '\0';
>  

As Sam mentioned, you'll want this to be

+	if (source[len - 1] == '\n')
+		source[len - 1] = '\0';

I forgot to mention this to you before, but please run
./scripts/checkpatch.pl on your patches before sending them and fix up
any errors or warnings.

Harry

>  	ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt);
>  	if (ret)
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel