All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org, Julien Meunier <julien.meunier@6wind.com>
Subject: Re: [PATCH v2] i40e: fix vlan filtering
Date: Thu, 04 Feb 2016 09:38:54 +0100	[thread overview]
Message-ID: <6113889.ZXPIxxScSZ@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A992C27@SHSMSX104.ccr.corp.intel.com>

2016-02-04 00:41, Zhang, Helin:
> From: Julien Meunier [mailto:julien.meunier@6wind.com]
> > INFO log level is used in order to keep code homogeneity:
> > i40e_vsi_config_vlan_stripping or i40e_dev_init_vlan use this log level during
> > failure for example.
> > 
> > Tell me if ERR log level for VLAN filtering issue must be set.
> There is a failure, and may result in uncertain behaviors which cannot be ignored.
> I'd suggest to use ERR but not INFO, though I am not so confident on that.
> Could Thomas help give some guidance on that?

Helin, about i40e internals, I follow your guidance :)
If you consider it as a real error, yes we must log an error.

About code homogeneity, Julien seems to have seen some errors in the
driver which should be logged as such, right?
It may be a separate effort to fix them.
Thanks

  parent reply	other threads:[~2016-02-04  8:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 17:18 [PATCH] i40e: fix vlan filtering Julien Meunier
2016-01-19  0:39 ` Zhang, Helin
2016-01-20  3:54 ` Pei, Yulong
2016-01-20  5:00 ` Zhang, Helin
2016-01-20 14:56   ` Julien Meunier
2016-02-02 13:50 ` [PATCH v2] " Julien Meunier
2016-02-03  1:15   ` Zhang, Helin
2016-02-03 11:32     ` Julien Meunier
2016-02-04  0:41       ` Zhang, Helin
2016-02-04  0:53         ` Stephen Hemminger
2016-02-04  8:38         ` Thomas Monjalon [this message]
2016-02-04 11:02   ` [PATCH v3] " Julien Meunier
2016-02-05  0:20     ` Zhang, Helin
2016-02-24 17:51       ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6113889.ZXPIxxScSZ@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=julien.meunier@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.