All of lore.kernel.org
 help / color / mirror / Atom feed
From: Casey Bodley <cbodley@redhat.com>
To: The Sacred Order of the Squid Cybernetic <ceph-devel@vger.kernel.org>
Subject: Re: rgw: feedback on auth engine selection
Date: Wed, 7 Sep 2016 17:05:34 -0400	[thread overview]
Message-ID: <6113bdf0-10fb-a30d-e4a0-797df61f8bd0@redhat.com> (raw)
In-Reply-To: <CA+H5UW1Qf++2R36y05GFAFTcJO2YN77W4z1yjpUMgAHitnsG-Q@mail.gmail.com>


On 09/07/2016 01:19 PM, Radoslaw Zarzynski wrote:
> Anyway, before we start discussing the whole
> auth stuff further, I guess it would be helpful to
> write in one place all requirements/plans that
> might affect this area. For instance, the idea of
> RGWHandler rework can have such impact.
>
> Let me start the requirements with an item found
> after a session with Swift's FormPost middleware:
>
> * the auth infrastructure must allow for easy-adoption
>    of new AuthEngines as even FormPost would need
>    one :-).

Some specific requirements that I recall from our past discussions include:

- don't heap allocate auth state per request
- don't construct or call into AuthEngines that shouldn't be enabled for 
the given handler

I'll add some of the other refactoring goals we've discussed, but I 
don't think they place any strict requirements on the auth subsystem:

- RGWHandler: being able to reuse handler instances, instead of 
allocating a new one for each request
- req_state: contains too many unrelated fields, some of which are 
transformed in confusing ways over the lifetime of the request. needs to 
be broken up into smaller, better encapsulated sub-objects
- concurrency: move away from a synchronous process_request() to build 
on asio frontend work

  reply	other threads:[~2016-09-07 21:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e2a2e0c9-51e7-b703-2c8d-7b489d4e8994@redhat.com>
2016-09-07 17:19 ` rgw: feedback on auth engine selection Radoslaw Zarzynski
2016-09-07 21:05   ` Casey Bodley [this message]
2016-09-08 17:19     ` Radoslaw Zarzynski
2016-09-08 18:23       ` Casey Bodley
2016-09-12  9:48         ` Radoslaw Zarzynski
2016-09-12 18:35           ` Casey Bodley
2016-09-08 21:05       ` Matt Benjamin
2016-09-08 17:21     ` Pritha Srivastava
2016-09-09 15:43       ` Radoslaw Zarzynski
2016-09-07 21:09   ` Casey Bodley
2016-09-08 15:46     ` Radoslaw Zarzynski
2016-09-08 20:49       ` Casey Bodley
2016-09-11 23:20         ` Radoslaw Zarzynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6113bdf0-10fb-a30d-e4a0-797df61f8bd0@redhat.com \
    --to=cbodley@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.