From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37ABFC433EF for ; Mon, 21 Mar 2022 01:38:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8893C83B02; Mon, 21 Mar 2022 02:38:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Uxo4ttMl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3DDE883B06; Mon, 21 Mar 2022 02:38:39 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0614.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe05::614]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6961083AF7 for ; Mon, 21 Mar 2022 02:38:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vd0/nac1o0X5KKJcoMg2sBy/T/VuAccAvp3SCAb+wQ/k0c+HhyNqQZO0v+uE0FP7/pTg04Cdd6RRwtcJ9AWuQe+8jfA9pEyucWKmS1Uuch7GZj/sSYB4O4e9Lfa5N6SfD+xBToQtaywdjKAT3zurf5eMri060bB+z65r8BxetrX8eNgyU3NG+j5FlmFaKkmtjaDRCQYXsgefPknBrtDmWCXF3b19jY7viBgeuBXEDIeqZIVU1sWm1eQTBx7E36hoLfSVewEQURmn7PEGjYQQeASABOJCEFUdc7iaK/A4nXNb7b9qpolEkwdl/aYvrkgBcsDDN5TTwhUnSjVC+JkcAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DEAGs8/atRWTg1Mv4Qdo0UL1Ebe41N+93wwjhAuqrUk=; b=YsCk1yEu11qrVATtF9WZNelLAtzGlv8E78qSPASb1gBOUiNrwwUg4Sq5O7nsT07SG05SDYAf9dncEkTPfeu2vzIdzev30oI/NeSQlCvrTFMPuLvpeHlM7PuPFZj0bYI1Oxlz/3YNDotK1L+qfTwkDzA0qGas5JvmOdYyKn2si2qo3pS0cyeRPS/w0F/Pc1vOJyE4CLpGX0et6oL7Nmn+Wj8l3p9bVQstaOVaF65Z+OlIUu79USRlQ1tDaqEg7GG5WyYthwwsK8ZWmEGDHF17gP2SK51d1tfrGkBPMFdZnvUBY0yeU7qbNImOcTkR4yD6DkGKy/bsgOAWS55Ly64k3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DEAGs8/atRWTg1Mv4Qdo0UL1Ebe41N+93wwjhAuqrUk=; b=Uxo4ttMl08CzywdVNGbcG+bpwa9XW3Q17+93tmRJGEA0bP+W33LJK/ufw6e2Gup44aZeQdqrJXkVTwnX37ZY/dqTgJq2LRgWl9TlB+fPQqdZPig1TLecRgx5787FwT3PMVlF2NQTeT7KTpHjq4vfSn2he1zJNMHyi33b/yyMYrs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM0PR04MB4147.eurprd04.prod.outlook.com (2603:10a6:208:65::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.22; Mon, 21 Mar 2022 01:38:33 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::cd28:b224:dbce:5f5e]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::cd28:b224:dbce:5f5e%7]) with mapi id 15.20.5081.022; Mon, 21 Mar 2022 01:38:33 +0000 Subject: Re: [PATCH v4 2/4] clk: imx8mq: Add a clock driver for the imx8mq To: Heiko Thiery , Angus Ainslie Cc: Angus Ainslie , "u-boot@lists.denx.de" , Marek Vasut , "lukma@denx.de" , "seanga2@gmail.com" , "sbabic@denx.de" , "festevam@gmail.com" , "kernel@puri.sm" , dl-uboot-imx , Peng Fan , Michael Walle References: <20220315130820.1054186-1-angus@akkea.ca> <20220315130820.1054186-3-angus@akkea.ca> <59a8d3a19ef0d7f7a982083b5002cb51@akkea.ca> <7f7e0935bb7450b8fdf856b7a3d724ee@akkea.ca> From: "Peng Fan (OSS)" Message-ID: <6115b69d-a956-88be-6a1b-154a5f77d629@oss.nxp.com> Date: Mon, 21 Mar 2022 09:38:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR06CA0013.apcprd06.prod.outlook.com (2603:1096:4:186::18) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69ba3caf-e122-453e-20f0-08da0adb828a X-MS-TrafficTypeDiagnostic: AM0PR04MB4147:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 21gf62baYLK63lJquwPYIQbT7fFm0lltmkhXcJ7y79SzmhEPGZB9/x5s7H/hb76K14Gp2UcJsnvONN0JNn8YnTdXpI/92W3360XxbF3rdW0vRxGLeeFanG68rpJkPyGTLKkEbhEuYPore3oQS5K7sxp8r24MC1Jyjd0Bv7nIr793/Iu8sIXxy/WmD8y62NvhgXvt/iGCdJs21D/WlBXmijoHcrifKr+0wAO3OEUgF2MCwPj8qcTOvv53u/o8lPs2rixXw8siJb+divIOIstwcejKqmOBLTpx+iyAYJ6aI5scbKUiUvWOPwMueOch80hFDPkszWu/vuiCrtRQdtlZyOlro1oUoAKWAXc30hWFSL5lk7IG2Czs1F5jBZi9aihlx8DyzP2pr60y9kMtMoyKMSi3dw8+elXUTgNriYWNIiLYOgjIGNkZIzDuW4DFGVhzeSfmNz10HnONJYsGCKqfA8yarco6/rESww54NTUP6vh0njqwSb4xQbVCcpWXy7xIvmTOH4I6xo2DDFcAKCQO7zRjk2H6gAuF+WExxllyfJDvEb1LrZbGZEeaPiqEyRli58Wf+mWuPM23WZyGpjW5ZerRJZK49tnOT+Hzp9TvePrcQpH+YUE3PVMwWWuiBRk0ueqduc/33+Ue/qGKiNyUCGCHEScax/HWFMTdVGEQRoXw1pjipAy7xOYhDfTP581JhaYhsNgBKIn6luZ5S3O7gfX3j8FYz8U0KgWRG0fhUQSjC1QrizVzHHwBJhqPdJItiE0w1TUgfZqmo38LQvI/4LQoVCR6TQ3MmIzSDAsWINJQO/v6dCiECsfyDzmJnHMjw2uN9iME5BWIoEkWKrLNIPjfsqh7jZGFpl+t2vN/1SRe7HweCEkHvbfl0n9/GNyo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(7416002)(45080400002)(66946007)(508600001)(2906002)(8936002)(6666004)(966005)(6486002)(186003)(26005)(66556008)(66476007)(8676002)(4326008)(86362001)(31696002)(316002)(110136005)(53546011)(54906003)(52116002)(6506007)(6512007)(38100700002)(38350700002)(31686004)(2616005)(83380400001)(32563001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nlc4dmhwM1VGTnAwRURjMFI4clF2YU95NTVMNUdwSXc0TTZFVDNRNWpuNjFW?= =?utf-8?B?WW5WUGxjeU4yNm9OaEU5am9udTFkYzJCTmd1cjIrNmFxOUt4MURMVmNrMVd1?= =?utf-8?B?UEFrUFNUWDA5TEI4YkwrbGhhME9TbWIrOVdMcW9TU1ZLR3ZRNGphdmt5MGc4?= =?utf-8?B?T1A5YjdpWUI2ZkdycmxlZ3Ivc0Y0MjFTQXFEdWhueGM2a3hTQXJMUDhxanFS?= =?utf-8?B?ODNBNThyWTJxbi9BSHY3RW9BU09YMjhxWnM3MUNzS2VjdHlYT1VWSEpWZmxY?= =?utf-8?B?K3NXQ3owQVpwM1dyKzQwbExndUZqUUN5N3EzNS82TGtOMmNsbk5lUi9ZZU1U?= =?utf-8?B?Tzh5aW13WjJidFJ3M0owM2lCUHZCSFV2U2tSR3k4NnRCRXZUZSs0aXdkLzAw?= =?utf-8?B?RHJyamZORzVnSVBaUE1FbTd0NytmZlZSbzZJR3Jibmh2WjIwV2REMzlUbEJh?= =?utf-8?B?Q1ViajZJWjdaSEdqTlZDaURCQVBacWpvZnlpeUgrR3FXU1B4VS80Z1piNXZX?= =?utf-8?B?RDFMaGo3OWd1aDg3dFFYTHFHWlZkbExMcDBjVndoYi9Nb21zTXpkZE0xMjFR?= =?utf-8?B?NzRyaWFYd29iemtXNWRhK05Vc25sRm1tMnJQTmcxMDJaajNERDFyNXZhd0Rq?= =?utf-8?B?RHNHVVU0M2hXSExJdUpBc0NpRjNWRys1d01ZVjh1Q2g3Zi9rWW1Rdk9SWmVX?= =?utf-8?B?N0l6TTlVV1RPZ2xEeDlGKzRlQ1ljN3ArTEcwWWtndVlWc1BsdEN1TlJ4RTlp?= =?utf-8?B?eGE1SmowMC82L3Y4cm4rTTVUMVhHRjVFSFpPK2o4cHhDN2JqQk5FZjdvV1p2?= =?utf-8?B?akRiUTZrV0UrYWl3Q1F6dndhMFloNk9FQllkWTBMTFVmYVdxd3RNRmptN2gr?= =?utf-8?B?Qi8rYktZWjJnR3VqSHBBUXBCcWVjLzl3bHRybnZjb01wYllxYTgyWHJFZ1dT?= =?utf-8?B?RHhmS1VqSWxHRmp6c2plclhBUjFwR2laWUFKeXgyYmJZajR4b3dKS3R0UlJy?= =?utf-8?B?Q2NNTjAvWnVrdVNJVTZwRnF4cjNMOEtoVDR2Wk1IVFYrRzloTGxQWGJEd241?= =?utf-8?B?QWtjNldzYlUxemZWaHdReGtRUThCMTBvM29UWXJKK2FiNmtpNHVnbWZPd3RP?= =?utf-8?B?QmJMMzBadk1yN1BQbVkxNGUvUjQ2Qmp3RHBDbU1mUzlDaVRxYWNqSmR6ZTNt?= =?utf-8?B?LzhPWHRSQ2ZFYWVYb0VicWdhbUp1MDl3bE5qN1VlekY5ZlgvTG9WYjhSaklo?= =?utf-8?B?YjBDU3JYKy9vdW94TjZUY2hKaDNxYXVYQjhrcXlkNU80ZWJkV016V0pseURV?= =?utf-8?B?aGM1WUh0aVI2VC8yQ2p1TmJqOTF4Q2ZDb016bGtzZnB5SWdsZmN2OHJjS3ZT?= =?utf-8?B?ckhpeENtbExnZmxrK01uMEpzeXZYeFh5cFlGaldReko4YXg1NHR0Um40bzJh?= =?utf-8?B?b0hFbkN0cGZoWDJVV0RaSTFSSFFZRkg3WnFrVDJKbUdTSWRQcFVBcmxpa0lF?= =?utf-8?B?dUhSejJIQkhPUFYwYU41MEtWYTVwOXBMUHRwMDlxLzhSUjhRNVc5ZmtMcTlp?= =?utf-8?B?b2FYYS9vREZRVW50ekRZQWk4aUtFaTJBZWtmZ3VSbDh0MnNwOWcwMEp1UmZl?= =?utf-8?B?NWNUd0QyOHFPOTN0cVVGZ1JoQWJ2cDFzZGFKdEdxSnNmTVdicHd2dXBLNXBq?= =?utf-8?B?Z3p1dm9sVWF0UXg3TnlycHpBYmVkNTdCOWgveGtOejNqdUVhZEhhck1sUmkw?= =?utf-8?B?R0NvZWU5dzd6NEZoMndqV3JETlVmLzNQY3d4ZWIzY1VleTl5V2FydDJHZ2pm?= =?utf-8?B?VEZvNVBxcElFMWJtNlEzZE9xUWQybC9XcVlLK0dxUzE0ZllkYVRiZW5HNTB1?= =?utf-8?B?UEhoTUd5MUpvODVKSUkxZ0FRdW1SdFI0UWhLSzJXeGxidWkvTkszR282SlY5?= =?utf-8?Q?9Z6U3I2ANpALNYQlZcOqERmIsZzA61A0?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69ba3caf-e122-453e-20f0-08da0adb828a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 01:38:33.2739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IlYcb6So0ZZIYMBRLGETGOYB/6JBCrHJhuLi5pl94oxmdyNYsWVg9rx0wIEk514ki5+xH1NY+6vr2x30eMlQDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4147 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2022/3/16 23:55, Heiko Thiery wrote: > Hi Angus, > > [snip] >>>> But then something went wrong when probing uart3 ... the baudrate >>>> switched for the uart2 (console) and the serial output became broken. >>>> Later when the kernel starts the output becomes correct again. So the >>>> kernel seems to configure it correctly. >>>> >>>> see here: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpastebin.com%2Fraw%2FqXVShb3Q&data=04%7C01%7Cpeng.fan%40nxp.com%7C7f70ec10fbe643a9dc8808da07656eef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637830429481235934%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KYnwAT%2Bw2Vnc559Ff3QYcqjKCjpEo6mdG8lyzaeGBZo%3D&reserved=0 >>>> >>>> When I remove the "assigned-clock-parents = <&clk >>>> IMX8MQ_SYS1_PLL_80M>;" for uart3 the output of uart2 (console) keeps >>>> ok. >>> >>> If that "fixes" it then it means that the parent IMX8MQ_SYS1_PLL_80M >>> clock rate is getting changed by the uart3 stanza. >>> >>> Are you using the mainline devicetree file for your board ? If not could >>> you provide a link ? >> >> I use the mainline u-boot/linux one. > > We (thanks to Michael) found the issue. For the imx8mq the > imx_get_uartclk() returns always the values for UART1_CLK_ROOT [1]. > This is wrong. Here we have to get the value dependent on the used > UART. Yes, this needs to be fixed! Previously in U-Boot, we suppose people not configure CCM for Uart, so all uart works at 25M OSC if not configure CCM to other mux. Since you have CLK DM with assigned clock parents, so this needs update. Regards, Peng. > > [1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.denx.de%2Fu-boot%2Fu-boot%2F-%2Fblob%2Fmaster%2Farch%2Farm%2Fmach-imx%2Fimx8m%2Fclock_imx8mq.c%23L381&data=04%7C01%7Cpeng.fan%40nxp.com%7C7f70ec10fbe643a9dc8808da07656eef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637830429481235934%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=e8CrijnqZVy2P8aVViYeiZm8jJcD6NjLqAhIriJRrt8%3D&reserved=0 >