From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbcF2PbQ (ORCPT ); Wed, 29 Jun 2016 11:31:16 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:50301 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbcF2PbN (ORCPT ); Wed, 29 Jun 2016 11:31:13 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , Russell King , devicetree@vger.kernel.org, Thomas Gleixner , Daniel Lezcano , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] ARM: NUC900: Add NUC970 SoC support Date: Wed, 29 Jun 2016 17:32:47 +0200 Message-ID: <6119546.EJZ9lH2GPk@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466851042-22239-1-git-send-email-vw@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:wJIRWyhBZk+GIfNGkdAjKqZW32Ama/KSSYlb8I/kg/bngiKlagC m7YvPcz0YQ5a1Ixyr8CSKaHLkQ2xdGHKe7zLdS3YVibKiKiiiNdvPVq2p4xeIQ3SBNLc7Tj hUZKHDjY05aEeXgnFNlggBbv0zIxSecrlsBeSZVmPJ/VqJCsdJ0EW+TtokQZ5B0MFMLoks3 nmKyehmKPnV9mbo357eoA== X-UI-Out-Filterresults: notjunk:1;V01:K0:tDrse9iuy+s=:0WRVPpZQW6EGacPi5pRdu8 2Yrex9kQGMdkrGwkrmDQQfgoIC5MR8wIX6+X9RqUZJYbNwHP5Y32Xz+o4XMpZ4mww9lbravmw 5mE6/YfYj6mf1TTPUklKq5yHTkoRWTu3JAH0lzkhRY9LA50EJ2MbpGBx+QrL8cUYrgwjYP4g0 BJMqfyCQsJyN7rBiEcZVXq808ji9DNLKeyKGDHG7DMDXNABUbFHCsZtX0TdfJJQeWtqtTmPFq pIMV9FlX+o9PORo6bsQn0yTL6+kf4pJABTvypc5V3XSMSiwqkWX1kRhqMFg7GkkJ/Qphl6D52 bBfdHtVZsKe4HkpYS8yWWxfEuPLw+I+FJIhc5YYTZsmXV+dRr+YzZkFO/MkE/Yl5FCQLLC/yg ivtmTImIeu4XPc6Yq5pIGX6bApKdf3X1I9JoQrXWzSEn+Lx0qaruNUecROTc85AZUxdnbP7JS Sa0Ou2Hf/U7Z0I+agrp/449wjukjaw55WucQWA0kKmHHsuCPaG6yB1kBUpfw7SqF52OJJbaV6 CV5YUUsL5XOMPn91b8EQMNmppgmY6rpBrplTan0OYANxaV6DiKq/L0wLRTSlBjVVYCBUtFda2 ItTzOwiMP955oqryKN9hJlJLieKgDL3KsRcEvxWo3j03eUB4UXrE1GIcsdkETk8o2Qb/MtikB kJLs1yALbYVC1WiJQA4v5Nk809CjKYzb+S0Bxa6V2bCHu9Q4y1pKhalKA5ExdYZfuQP2OuRMr lat9iL+K4WQF3uzo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, June 25, 2016 6:37:16 PM CEST Wan Zongshun wrote: > This patch series added Nuvoton new SoC NUC970 development board > support, this nuc970 belongs to nuc900 series, but many features are > not compatible with old nuc900 SoCs like nuc910, nuc920. > > Those patches are basing on old w90x900 codes, and are using standard > linux subsystem interface, such as dts, driver/clk, driver/clocksource > , driver/irqchip drivers. > > The old w90x900 plat such as nuc910,nuc960 codes will also be changed > to new style according to nuc970 codes after those patches was accepted. Looks good overall. I have a number of comments but they should all be easy to address, and the general approach of adding this first makes sense to me as well. The three drivers should be merged through the respective subsystem maintainer trees. There is one dependency with the clk header, but we can resolve that if we merge the header along with the dts files (actually before the dts files) so that it's possible to build the .dtb without the clk driver being merged. That driver in turn will not be selectable in Kconfig because it depends on CONFIG_SOC_NUC970 (or whatever the symbol is called). Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 0/6] ARM: NUC900: Add NUC970 SoC support Date: Wed, 29 Jun 2016 17:32:47 +0200 Message-ID: <6119546.EJZ9lH2GPk@wuerfel> References: <1466851042-22239-1-git-send-email-vw@iommu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1466851042-22239-1-git-send-email-vw@iommu.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel@vger.kernel.org, Thomas Gleixner List-Id: devicetree@vger.kernel.org On Saturday, June 25, 2016 6:37:16 PM CEST Wan Zongshun wrote: > This patch series added Nuvoton new SoC NUC970 development board > support, this nuc970 belongs to nuc900 series, but many features are > not compatible with old nuc900 SoCs like nuc910, nuc920. > > Those patches are basing on old w90x900 codes, and are using standard > linux subsystem interface, such as dts, driver/clk, driver/clocksource > , driver/irqchip drivers. > > The old w90x900 plat such as nuc910,nuc960 codes will also be changed > to new style according to nuc970 codes after those patches was accepted. Looks good overall. I have a number of comments but they should all be easy to address, and the general approach of adding this first makes sense to me as well. The three drivers should be merged through the respective subsystem maintainer trees. There is one dependency with the clk header, but we can resolve that if we merge the header along with the dts files (actually before the dts files) so that it's possible to build the .dtb without the clk driver being merged. That driver in turn will not be selectable in Kconfig because it depends on CONFIG_SOC_NUC970 (or whatever the symbol is called). Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 29 Jun 2016 17:32:47 +0200 Subject: [PATCH 0/6] ARM: NUC900: Add NUC970 SoC support In-Reply-To: <1466851042-22239-1-git-send-email-vw@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> Message-ID: <6119546.EJZ9lH2GPk@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday, June 25, 2016 6:37:16 PM CEST Wan Zongshun wrote: > This patch series added Nuvoton new SoC NUC970 development board > support, this nuc970 belongs to nuc900 series, but many features are > not compatible with old nuc900 SoCs like nuc910, nuc920. > > Those patches are basing on old w90x900 codes, and are using standard > linux subsystem interface, such as dts, driver/clk, driver/clocksource > , driver/irqchip drivers. > > The old w90x900 plat such as nuc910,nuc960 codes will also be changed > to new style according to nuc970 codes after those patches was accepted. Looks good overall. I have a number of comments but they should all be easy to address, and the general approach of adding this first makes sense to me as well. The three drivers should be merged through the respective subsystem maintainer trees. There is one dependency with the clk header, but we can resolve that if we merge the header along with the dts files (actually before the dts files) so that it's possible to build the .dtb without the clk driver being merged. That driver in turn will not be selectable in Kconfig because it depends on CONFIG_SOC_NUC970 (or whatever the symbol is called). Arnd