All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Talbot <chris@talbothome.com>
To: ofono@ofono.org
Subject: [PATCH 2/9] Ensure Compatibility with Telus Canada
Date: Wed, 24 Feb 2021 19:43:50 -0500	[thread overview]
Message-ID: <612b64129ae7385497475897653d566868b73de3.camel@talbothome.com> (raw)
In-Reply-To: <20210225003933.2871.63570@ml01.vlan13.01.org>

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]


mmsd decodes a header that is not in the standard.
This patch allows this header to be decoded
---
 src/mmsutil.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/mmsutil.c b/src/mmsutil.c
index 5fcf358..9430bf1 100644
--- a/src/mmsutil.c
+++ b/src/mmsutil.c
@@ -732,10 +732,9 @@ static header_handler handler_for_type(enum
mms_header header)
 		return extract_text;
 	case MMS_HEADER_INVALID:
 	case __MMS_HEADER_MAX:
+	default:
 		return NULL;
 	}
-
-	return NULL;
 }
 
 struct header_handler_entry {
@@ -781,8 +780,17 @@ static gboolean mms_parse_headers(struct
wsp_header_iter *iter,
 
 		handler = handler_for_type(h);
 		if (handler == NULL) {
-			DBG("no handler for type %u", h);
-			return FALSE;
+			if(h == MMS_HEADER_INVALID) {
+				DBG("no handler for type %u", h);
+				return FALSE;
+			} else if (h == __MMS_HEADER_MAX) {
+				DBG("no handler for type %u", h);
+				return FALSE;
+			} else {
+				/*  Telus has strange headers, so this
handles it */
+				DBG("type isn't a part of the standard?
Skipping %u", h);
+				continue;
+			}
 		}
 
 		DBG("saw header of type %u", h);
-- 
2.30.0

  parent reply	other threads:[~2021-02-25  0:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25  0:39 Patches For MMSD chris
2021-02-25  0:42 ` [PATCH 1/9] Fix mmsd to work with T-mobile Christopher Talbot
2021-02-25  0:43 ` Christopher Talbot [this message]
2021-02-25  0:44 ` [PATCH 3/9] Ensure Compatibility with AT&T Christopher Talbot
2021-02-25  0:45 ` [PATCH 4/9] Fix issue if there is an empty string in encoded text Christopher Talbot
2021-02-25  0:46 ` [PATCH 5/9] Allow for a user configurable maximum attachment size Christopher Talbot
2021-02-25  0:46 ` [PATCH 6/9] Update README Christopher Talbot
2021-02-25  0:47 ` [PATCH 7/9] Fix Draft and Sent Bugs Christopher Talbot
2021-02-25  0:48 ` [PATCH 8/9] Allow Maintainer mode to compile without -WError Christopher Talbot
2021-02-25  0:50 ` [PATCH 9/9] Add a Modem Manager Plugin Christopher Talbot
2021-03-26 10:50 [PATCH 2/9] Ensure Compatibility with Telus Canada Christopher Talbot
2021-04-10 14:13 [PATCH 0/9] Updates for mmsd Chris Talbot
2021-04-10 14:17 ` [PATCH 1/9] Fix mmsd to work with T-mobile Chris Talbot
2021-04-10 14:20   ` [PATCH 2/9] Ensure Compatibility with Telus Canada Chris Talbot
2021-04-10 14:20     ` Chris Talbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=612b64129ae7385497475897653d566868b73de3.camel@talbothome.com \
    --to=chris@talbothome.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.