From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v3 00/17] Introduce ACPI for ARM64 based on ACPI 5.1 Date: Thu, 11 Sep 2014 16:23:04 +0200 Message-ID: <61335531.hz91PL2Gdf@vostro.rjw.lan> References: <1409583475-6978-1-git-send-email-hanjun.guo@linaro.org> <20140911132935.068DCC408F6@trevor.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: Received: from v094114.home.net.pl ([79.96.170.134]:60983 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753356AbaIKODe (ORCPT ); Thu, 11 Sep 2014 10:03:34 -0400 In-Reply-To: <20140911132935.068DCC408F6@trevor.secretlab.ca> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Grant Likely Cc: Hanjun Guo , Catalin Marinas , Mark Rutland , Olof Johansson , Graeme Gregory , Arnd Bergmann , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles.Garcia-Tobin@arm.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acp On Thursday, September 11, 2014 02:29:34 PM Grant Likely wrote: > On Mon, 1 Sep 2014 22:57:38 +0800, Hanjun Guo wrote: > > ACPI 5.1 has been released and now be freely available for > > download [1]. It fixed some major gaps to run ACPI on ARM, > > this patch just follow the ACPI 5.1 spec and prepare the > > code to run ACPI on ARM64. > > > > ACPI 5.1 has some major changes for the following tables and > > method which are essential for ARM platforms: > > 1) MADT table updates. > > 2) FADT updates for PSCI > > 3) GTDT > > > > This patch set is the ARM64 ACPI core patches covered MADT, FADT > > and GTDT, platform board specific drivers are not covered by this > > patch set, but we provide drivers for Juno to boot with ACPI only > > in the follwing patch set for review purpose. > > > > We first introduce acpi.c and its related head file which are needed > > by ACPI core, and then get RSDP to extract all the ACPI boot-time tables. > > When all the boot-time tables (FADT, MADT, GTDT) are ready, then > > parse them to init the sytem when booted. Specifically, > > a) we use FADT to init PSCI and use PSCI to boot SMP; > > b) Use MADT for GIC init and SMP init; > > c) GTDT for arch timer init. > > > > This patch set is based on 3.17-rc2 and was tested by Graeme on Juno > > and FVP base model boot with ACPI only OK, if you want to test them, > > you can pull from acpi-5.1-v3 branch in leg/acpi repo: > > git://git.linaro.org/leg/acpi/acpi.git > > > > Updates since v2: > > - Refactor the code to make SMP/PSCI init with less sperated init > > path by Tomasz > > - make ACPI depend on EXPERT > > - Address lots of comments from Catalin, Sudeep, Geoff > > - Add Juno device ACPI driver patches for review > > > > Updates since v1: > > - Set ACPI default off on ARM64 suggested by Olof; > > - Rebase the patch set on top of linux-next branch/linux-pm tree which > > includes the ACPICA for full ACPI 5.1 support. > > - Update the document as suggested; > > - Adress lots of comments from Mark, Sudeep, Randy, Naresh, Olof, Geoff > > and more... > > > > [1]: http://www.uefi.org/sites/default/files/resources/ACPI_5_1release.pdf > > I've read through this entire series now. In my mind, aside from a few > comments that I know you're addressing, this is ready. The hooks into > arm64 core code are not terribly invasive, it is nicely organized and > manageable. Get the next version out ASAP, but I would also like to see > the diffs from this version to the next so I don't need to review the > entire series again. > > Regarding the requests to refactor ACPICA to work better for ARM. I > completely agree that it should be done, but I do not think it should be > a prerequisite to getting this core support merged. That kind of > refactoring is far easier to justify when it has immediate improvement > on the mainline codebase, and it gives us a working baseline to test > against. Doing it the other way around just makes things harder. > > I would really like to see the next version of this series go into > linux-next. I think this is ready for some wider exposure. Have you got > a branch being pulled into Fengguang's autobuilder yet? Having looked at the patches recently, I don't see any major problems in them from the ACPI core perspective, so to me they are good to go. Question is who's going to handle them? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755434AbaIKODi (ORCPT ); Thu, 11 Sep 2014 10:03:38 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:60983 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753356AbaIKODe (ORCPT ); Thu, 11 Sep 2014 10:03:34 -0400 From: "Rafael J. Wysocki" To: Grant Likely Cc: Hanjun Guo , Catalin Marinas , Mark Rutland , Olof Johansson , Graeme Gregory , Arnd Bergmann , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles.Garcia-Tobin@arm.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org Subject: Re: [PATCH v3 00/17] Introduce ACPI for ARM64 based on ACPI 5.1 Date: Thu, 11 Sep 2014 16:23:04 +0200 Message-ID: <61335531.hz91PL2Gdf@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20140911132935.068DCC408F6@trevor.secretlab.ca> References: <1409583475-6978-1-git-send-email-hanjun.guo@linaro.org> <20140911132935.068DCC408F6@trevor.secretlab.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 11, 2014 02:29:34 PM Grant Likely wrote: > On Mon, 1 Sep 2014 22:57:38 +0800, Hanjun Guo wrote: > > ACPI 5.1 has been released and now be freely available for > > download [1]. It fixed some major gaps to run ACPI on ARM, > > this patch just follow the ACPI 5.1 spec and prepare the > > code to run ACPI on ARM64. > > > > ACPI 5.1 has some major changes for the following tables and > > method which are essential for ARM platforms: > > 1) MADT table updates. > > 2) FADT updates for PSCI > > 3) GTDT > > > > This patch set is the ARM64 ACPI core patches covered MADT, FADT > > and GTDT, platform board specific drivers are not covered by this > > patch set, but we provide drivers for Juno to boot with ACPI only > > in the follwing patch set for review purpose. > > > > We first introduce acpi.c and its related head file which are needed > > by ACPI core, and then get RSDP to extract all the ACPI boot-time tables. > > When all the boot-time tables (FADT, MADT, GTDT) are ready, then > > parse them to init the sytem when booted. Specifically, > > a) we use FADT to init PSCI and use PSCI to boot SMP; > > b) Use MADT for GIC init and SMP init; > > c) GTDT for arch timer init. > > > > This patch set is based on 3.17-rc2 and was tested by Graeme on Juno > > and FVP base model boot with ACPI only OK, if you want to test them, > > you can pull from acpi-5.1-v3 branch in leg/acpi repo: > > git://git.linaro.org/leg/acpi/acpi.git > > > > Updates since v2: > > - Refactor the code to make SMP/PSCI init with less sperated init > > path by Tomasz > > - make ACPI depend on EXPERT > > - Address lots of comments from Catalin, Sudeep, Geoff > > - Add Juno device ACPI driver patches for review > > > > Updates since v1: > > - Set ACPI default off on ARM64 suggested by Olof; > > - Rebase the patch set on top of linux-next branch/linux-pm tree which > > includes the ACPICA for full ACPI 5.1 support. > > - Update the document as suggested; > > - Adress lots of comments from Mark, Sudeep, Randy, Naresh, Olof, Geoff > > and more... > > > > [1]: http://www.uefi.org/sites/default/files/resources/ACPI_5_1release.pdf > > I've read through this entire series now. In my mind, aside from a few > comments that I know you're addressing, this is ready. The hooks into > arm64 core code are not terribly invasive, it is nicely organized and > manageable. Get the next version out ASAP, but I would also like to see > the diffs from this version to the next so I don't need to review the > entire series again. > > Regarding the requests to refactor ACPICA to work better for ARM. I > completely agree that it should be done, but I do not think it should be > a prerequisite to getting this core support merged. That kind of > refactoring is far easier to justify when it has immediate improvement > on the mainline codebase, and it gives us a working baseline to test > against. Doing it the other way around just makes things harder. > > I would really like to see the next version of this series go into > linux-next. I think this is ready for some wider exposure. Have you got > a branch being pulled into Fengguang's autobuilder yet? Having looked at the patches recently, I don't see any major problems in them from the ACPI core perspective, so to me they are good to go. Question is who's going to handle them? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rjw@rjwysocki.net (Rafael J. Wysocki) Date: Thu, 11 Sep 2014 16:23:04 +0200 Subject: [PATCH v3 00/17] Introduce ACPI for ARM64 based on ACPI 5.1 In-Reply-To: <20140911132935.068DCC408F6@trevor.secretlab.ca> References: <1409583475-6978-1-git-send-email-hanjun.guo@linaro.org> <20140911132935.068DCC408F6@trevor.secretlab.ca> Message-ID: <61335531.hz91PL2Gdf@vostro.rjw.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday, September 11, 2014 02:29:34 PM Grant Likely wrote: > On Mon, 1 Sep 2014 22:57:38 +0800, Hanjun Guo wrote: > > ACPI 5.1 has been released and now be freely available for > > download [1]. It fixed some major gaps to run ACPI on ARM, > > this patch just follow the ACPI 5.1 spec and prepare the > > code to run ACPI on ARM64. > > > > ACPI 5.1 has some major changes for the following tables and > > method which are essential for ARM platforms: > > 1) MADT table updates. > > 2) FADT updates for PSCI > > 3) GTDT > > > > This patch set is the ARM64 ACPI core patches covered MADT, FADT > > and GTDT, platform board specific drivers are not covered by this > > patch set, but we provide drivers for Juno to boot with ACPI only > > in the follwing patch set for review purpose. > > > > We first introduce acpi.c and its related head file which are needed > > by ACPI core, and then get RSDP to extract all the ACPI boot-time tables. > > When all the boot-time tables (FADT, MADT, GTDT) are ready, then > > parse them to init the sytem when booted. Specifically, > > a) we use FADT to init PSCI and use PSCI to boot SMP; > > b) Use MADT for GIC init and SMP init; > > c) GTDT for arch timer init. > > > > This patch set is based on 3.17-rc2 and was tested by Graeme on Juno > > and FVP base model boot with ACPI only OK, if you want to test them, > > you can pull from acpi-5.1-v3 branch in leg/acpi repo: > > git://git.linaro.org/leg/acpi/acpi.git > > > > Updates since v2: > > - Refactor the code to make SMP/PSCI init with less sperated init > > path by Tomasz > > - make ACPI depend on EXPERT > > - Address lots of comments from Catalin, Sudeep, Geoff > > - Add Juno device ACPI driver patches for review > > > > Updates since v1: > > - Set ACPI default off on ARM64 suggested by Olof; > > - Rebase the patch set on top of linux-next branch/linux-pm tree which > > includes the ACPICA for full ACPI 5.1 support. > > - Update the document as suggested; > > - Adress lots of comments from Mark, Sudeep, Randy, Naresh, Olof, Geoff > > and more... > > > > [1]: http://www.uefi.org/sites/default/files/resources/ACPI_5_1release.pdf > > I've read through this entire series now. In my mind, aside from a few > comments that I know you're addressing, this is ready. The hooks into > arm64 core code are not terribly invasive, it is nicely organized and > manageable. Get the next version out ASAP, but I would also like to see > the diffs from this version to the next so I don't need to review the > entire series again. > > Regarding the requests to refactor ACPICA to work better for ARM. I > completely agree that it should be done, but I do not think it should be > a prerequisite to getting this core support merged. That kind of > refactoring is far easier to justify when it has immediate improvement > on the mainline codebase, and it gives us a working baseline to test > against. Doing it the other way around just makes things harder. > > I would really like to see the next version of this series go into > linux-next. I think this is ready for some wider exposure. Have you got > a branch being pulled into Fengguang's autobuilder yet? Having looked at the patches recently, I don't see any major problems in them from the ACPI core perspective, so to me they are good to go. Question is who's going to handle them? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.