From: Davide Caratti <dcaratti at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [MPTCP][PATCH v6 mptcp-next 5/9] mptcp: add port number announced check
Date: Wed, 25 Nov 2020 11:06:25 +0100 [thread overview]
Message-ID: <613bb9f26a3056cc637319c444aea9e93b8002f0.camel@redhat.com> (raw)
In-Reply-To: e13e47c7e041e577598101df70bd7e64e789b61e.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Wed, 2020-11-25 at 10:54 +0100, Paolo Abeni wrote:
> Note: I think this later change is actually an independed bug fix, I
> fear a peer sending an MP_JOIN with an invalid token will get back an
> MPJ_SYNACK, while the subflow_req->msk will be cleared. Later
> in subflow_syn_recv_sock(), we will probably get a NULL ptr dereference
> in mptcp_can_accept_new_subflow().
>
> @Davide: can we somehow easily check the above with a packet drill?
>
> Thanks!
yes I can try that. I'm now looking once again at the MP_JOIN script
(issue #94) and trying to fix this in a way or another (the problem is
apparently bad values of [s,c]addr[0,1] in the environment. But at least
generation of an inbound MP_JOIN SYN should be under control. I do a
quicjk tyest and let you know, ok?
--
davide
next reply other threads:[~2020-11-25 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 10:06 Davide Caratti [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-26 10:06 [MPTCP] Re: [MPTCP][PATCH v6 mptcp-next 5/9] mptcp: add port number announced check Matthieu Baerts
2020-11-26 10:03 Davide Caratti
2020-11-26 10:01 Matthieu Baerts
2020-11-26 9:56 Paolo Abeni
2020-11-25 20:33 Davide Caratti
2020-11-25 9:54 Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613bb9f26a3056cc637319c444aea9e93b8002f0.camel@redhat.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.