From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE55CC28CC5 for ; Wed, 5 Jun 2019 12:08:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4DA92067C for ; Wed, 5 Jun 2019 12:08:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="ZhbkAVc1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727559AbfFEMIp (ORCPT ); Wed, 5 Jun 2019 08:08:45 -0400 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:29863 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbfFEMIp (ORCPT ); Wed, 5 Jun 2019 08:08:45 -0400 Received-SPF: Pass (esa6.microchip.iphmx.com: domain of Eugen.Hristev@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Eugen.Hristev@microchip.com"; x-sender="Eugen.Hristev@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa6.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Eugen.Hristev@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa6.microchip.iphmx.com; spf=Pass smtp.mailfrom=Eugen.Hristev@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com X-IronPort-AV: E=Sophos;i="5.60,550,1549954800"; d="scan'208";a="33174611" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Jun 2019 05:08:43 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.87.151) by chn-vm-ex03.mchp-main.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 5 Jun 2019 05:08:43 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 5 Jun 2019 05:08:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=91e0t0Nuqmb6b0khNhfo9Y9EqXIZL4gnIVBkUQAOZRI=; b=ZhbkAVc1eCG4RAOoGsDPyPMC8OOVBSzjWMWUggoA2vmPz1rDZwUda2d6LwQb1sb9eI1f9URPC+GX9Cyselwrt2kKPVhNdhr9oz9bCudtvr6P3KpZ9/rOrZyIWll0cQp+gLG+LH0TDTqihM8D3X+pQQQXT9q9YVRefRHyq5DpPUw= Received: from DM5PR11MB1242.namprd11.prod.outlook.com (10.168.108.8) by DM5PR11MB1676.namprd11.prod.outlook.com (10.172.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Wed, 5 Jun 2019 12:08:41 +0000 Received: from DM5PR11MB1242.namprd11.prod.outlook.com ([fe80::2807:f606:3b7c:cce9]) by DM5PR11MB1242.namprd11.prod.outlook.com ([fe80::2807:f606:3b7c:cce9%9]) with mapi id 15.20.1943.018; Wed, 5 Jun 2019 12:08:41 +0000 From: To: , , , CC: Subject: Re: [PATCH v2] media: atmel: atmel-isc: split driver into driver base and isc Thread-Topic: [PATCH v2] media: atmel: atmel-isc: split driver into driver base and isc Thread-Index: AQHVFrxThsCvxgIDlEymA9iRK8Mn9qaM/daAgAACVwA= Date: Wed, 5 Jun 2019 12:08:40 +0000 Message-ID: <613e2e74-6ac7-93ce-6fb7-d570852bf1e3@microchip.com> References: <1559202331-15397-1-git-send-email-eugen.hristev@microchip.com> <4f1925a5-9361-7f57-4526-3d28be8291dd@xs4all.nl> In-Reply-To: <4f1925a5-9361-7f57-4526-3d28be8291dd@xs4all.nl> Accept-Language: ro-RO, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1P194CA0010.EURP194.PROD.OUTLOOK.COM (2603:10a6:800:be::20) To DM5PR11MB1242.namprd11.prod.outlook.com (2603:10b6:3:14::8) x-ms-exchange-messagesentrepresentingtype: 1 x-tagtoolbar-keys: D20190605150428781 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2887ec3-ceaa-4683-0666-08d6e9ae8c4a x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM5PR11MB1676; x-ms-traffictypediagnostic: DM5PR11MB1676: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 00594E8DBA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(346002)(376002)(366004)(199004)(189003)(8676002)(72206003)(14454004)(7736002)(25786009)(53936002)(305945005)(2501003)(76176011)(110136005)(316002)(81156014)(2201001)(99286004)(81166006)(73956011)(53546011)(52116002)(102836004)(386003)(6506007)(66066001)(8936002)(6512007)(478600001)(6246003)(86362001)(31696002)(36756003)(31686004)(14444005)(5660300002)(71190400001)(71200400001)(4326008)(229853002)(2906002)(26005)(186003)(6486002)(66946007)(11346002)(66446008)(64756008)(66556008)(66476007)(68736007)(476003)(2616005)(6436002)(486006)(256004)(446003)(6116002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR11MB1676;H:DM5PR11MB1242.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: bYPpOMbIK+zKkHtIFbNbo0mEJfRPfMqeqatM1ezlGeQBGwbrvjkZMxTgCfh3OWudrtyf42s6Z32Ap3Jk0M84cG9K4S+4ZrfFrmxg+ajo80BIYot73IEjJ5SeLIRu22+k4zWoqwjqp2CiwzChj5qYu/Lwm4smj6IQrSI9xeA7Pd1SDtvtssBqfGfMf1haFzB6SgjgmrrCy8TehA7QGqseuaJtycjQcglGS238xl5OiOuN3kQhkIRN6b9P7kx5h6EVwIV3KV65iFtqapUkS/YJv6nhIIMtx9oEPBjdvCm5lHkPRQ0hLlu/MJiM2QL9ZrW+8SNGemp+qp4m0rZ+5cZpVCtPB1mEJV96sGQv/1bb4l6FN0AA0Kh/y3KGfDXvxwxe5arWvzmkWOj4ifspCWHFTi8tL2ur/V1D2BN2KMjwajc= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f2887ec3-ceaa-4683-0666-08d6e9ae8c4a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2019 12:08:40.9869 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eugen.hristev@microchip.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1676 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQoNCk9uIDA1LjA2LjIwMTkgMTQ6NTYsIEhhbnMgVmVya3VpbCB3cm90ZToNCg0KPiANCj4gSGkg RXVnZW4sDQo+IA0KPiBPbiA1LzMwLzE5IDk6NTAgQU0sIEV1Z2VuLkhyaXN0ZXZAbWljcm9jaGlw LmNvbSB3cm90ZToNCj4+IEZyb206IEV1Z2VuIEhyaXN0ZXYgPGV1Z2VuLmhyaXN0ZXZAbWljcm9j aGlwLmNvbT4NCj4+DQo+PiBUaGlzIHNwbGl0cyB0aGUgQXRtZWwgSVNDIGRyaXZlciBpbnRvIGEg Y29tbW9uIGJhc2U6IGF0bWVsLWlzYy1iYXNlLmMNCj4+IGFuZCB0aGUgZHJpdmVyIHByb2JlL2R0 IHBhcnQgLCBhdG1lbC1zYW1hNWQyLWlzYy5jDQo+PiBUaGlzIGlzIG5lZWRlZCB0byBrZWVwIGEg Y29tbW9uIGdyb3VuZCBmb3IgdGhlIHNlbnNvciBjb250cm9sbGVyIHdoaWNoIHdpbGwNCj4+IGJl IHJldXNlZC4NCj4+IFRoZSBhdG1lbC1pc2Mgd2lsbCB1c2UgdGhlIGNvbW1vbiBzeW1ib2xzIGlu c2lkZSB0aGUgYXRtZWwtaXNjLWJhc2UNCj4+IEZ1dHVyZSBkcml2ZXIgd2lsbCBhbHNvIHVzZSB0 aGUgc2FtZSBzeW1ib2xzIGFuZCByZWRlZmluZSBkaWZmZXJlbnQgYXNwZWN0cywNCj4+IGZvciBh IGRpZmZlcmVudCB2ZXJzaW9uIG9mIHRoZSBJU0MuDQo+PiBUaGlzIGlzIGRvbmUgdG8gYXZvaWQg Y29tcGxldGUgY29kZSBkdXBsaWNhdGlvbiBieSBjcmVhdGluZyBhIHRvdGFsbHkNCj4+IGRpZmZl cmVudCBkcml2ZXIgZm9yIHRoZSBuZXcgdmFyaWFudCBvZiB0aGUgSVNDLg0KPj4NCj4+IFNpZ25l ZC1vZmYtYnk6IEV1Z2VuIEhyaXN0ZXYgPGV1Z2VuLmhyaXN0ZXZAbWljcm9jaGlwLmNvbT4NCj4+ IC0tLQ0KPj4NCj4+IEhlbGxvIEhhbnMsDQo+Pg0KPj4gSSBhbSByZXNlbmRpbmcgdGhpcyB3aXRo IHRoZSByZXF1aXJlZCBmaXhlcy4NCj4+IFlvdSBhc2tlZCBtZSBhYm91dCB0aGUgI2lmZGVmIGFy b3VuZCBBVE1FTF9JU0NfTkFNRSwgaXQncyBiZWNhdXNlIEkgd2FzDQo+PiB0aGlua2luZyB0byBo YXZlIHRoZSBBVE1FTF9JU0NfTkFNRSBkaWZmZXJlbnQgYnkgZWFjaCBkcml2ZXIgdGhhdCB1c2UN Cj4+IHRoZSBhdG1lbC1pc2MuaCwgYnV0IGZvciBub3cgSSByZW1vdmVkIGFueSBpZmRlZiBhcm91 bmQgaXQsIGFuZCB3aWxsDQo+PiBjb25zaWRlciBhIGRpZmZlcmVudCBkZWZpbmUgZm9yIG5ldyBk cml2ZXJzLg0KPj4NCj4+IENoYW5nZXMgaW4gdjI6DQo+PiAtIHJlbmFtZWQgYXRtZWwtaXNjLmMg dG8gYXRtZWwtc2FtYTVkMi1pc2MuYyBhcyBzYW1hNWQyIGlzIHRoZSBTb0MgdGhhdA0KPj4gICAg aW5jbHVkZXMgdGhpcyBoYXJkd2FyZSBibG9jay4gVGhlIG1vZHVsZSB3aWxsIHN0aWxsIGJlIG5h bWVkIGF0bWVsLWlzYy5rbw0KPj4gLSByZW1vdmVkIGlmZGVmIGFyb3VuZCBkZWZpbml0aW9uIG9m IEFUTUVMX0lTQ19OQU1FDQo+PiAtIG1vdmVkIGV4dGVybmFsIGRlY2xhcmF0aW9ucyBpbiB0aGUg c3BlY2lmaWMgZmlsZXMsIHRoaXMgd2FzIGJyZWFraW5nDQo+PiAgICBtb2R1bGUgbG9hZGluZw0K Pj4NCj4+IHY0bDItY29tcGxpYW5jZSBTSEE6IDBkNjFkZGVkZTdkMzQwZmZhMWM3NWEyODgyZTMw YzQ1NWVmM2Q4YjgsIDMyIGJpdGF0bWVsLWlzYyBmMDAwODAwMC5pc2M6ID09PT09PT09PT09PT09 PT09ICBTVEFSVCBTVEFUVVMgID09PT09PT09PT09PT09PT09DQo+Pg0KPj4gYXRtZWxwbGlhbmNl IHRlc3QgZm9yIGF0bWVsLWlzYyBkZXZpY2UgL2Rldi92aWRlbzA6DQo+Pg0KPj4gRHJpdmVyIElu Zm86DQo+PiAgICAgICAgICBEcml2ZXIgbmFtZSAgICAgIDogYXRtZWwtaXNjDQo+PiAgICAgICAg ICBDYXJkIHR5cGUgICAgICAgIDogQXRtZWwgSW1hZ2UgU2Vuc29yIENvbnRyb2xsZXINCj4+ICAg ICAgICAgIEJ1cyBpbmZvICAgICAgICAgOiBwbGF0Zm9ybTphdG1lbC1pc2MgZjAwMDgwMDAuaXNj DQo+PiAgICAgICAgICBEcml2ZXIgdmVyc2lvbiAgIDogNS4yLjANCj4+ICAgICAgICAgIENhcGFi aWxpdGllcyAgICAgOiAweDg0MjAwMDAxDQo+PiAgICAgICAgICAgICAgICAgIFZpZGVvIENhcHR1 cmUNCj4+ICAgICAgICAgICAgICAgICAgU3RyZWFtaW5nDQo+PiAgICAgICAgICAgICAgICAgIEV4 dGVuZGVkIFBpeCBGb3JtYXQNCj4+ICAgICAgICAgICAgICAgICAgRGV2aWNlIENhcGFiaWxpdGll cw0KPj4gICAgICAgICAgRGV2aWNlIENhcHMgICAgICA6IDB4MDQyMDAwMDENCj4+ICAgICAgICAg ICAgICAgICAgVmlkZW8gQ2FwdHVyZQ0KPj4gICAgICAgICAgICAgICAgICBTdHJlYW1pbmcNCj4+ ICAgICAgICAgICAgICAgICAgRXh0ZW5kZWQgUGl4IEZvcm1hdA0KPj4NCj4+IFJlcXVpcmVkIGlv Y3RsczoNCj4+ICAgICAgICAgIHRlc3QgVklESU9DX1FVRVJZQ0FQOiBPSw0KPj4NCj4+IEFsbG93 IGZvciBtdWx0aXBsZSBvcGVuczoNCj4+ICAgICAgICAgIHRlc3Qgc2Vjb25kIC9kZXYvdmlkZW8w IG9wZW46IE9LDQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19RVUVSWUNBUDogT0sNCj4+ICAgICAg ICAgIHRlc3QgVklESU9DX0cvU19QUklPUklUWTogT0sNCj4+ICAgICAgICAgIHRlc3QgZm9yIHVu bGltaXRlZCBvcGVuczogT0sNCj4+DQo+PiBEZWJ1ZyBpb2N0bHM6DQo+PiAgICAgICAgICB0ZXN0 IFZJRElPQ19EQkdfRy9TX1JFR0lTVEVSOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+IC1pc2MgZjAw MDgwMDAuaXNjOiBCcmlnaHRuZXNzOiAwDQo+PiBhdG1lbC1pc2MgZjAwMDgwMDAuaXNjOiBDb250 cmFzdDogMjU2DQo+PiBhdG1lbC1pc2MgZjAwMDgwMDAuaXNjOiBHYW1tYTogMg0KPj4gYXRtZWwt aXNjIGYwMDA4MDAwLmlzYzogV2hpdGUgQmFsYW5jZSwgQXV0b21hdGljOiB0cnVlDQo+PiBhdG1l bC1pc2MgZjAwMDgwMDAuaXNjOiA9PT09PT09PT09PT09PT09PT0gIEVORCBTVEFUVVMgID09PT09 PT09PT09PT09PT09PQ0KPj4gICAgICAgICAgdGVzdCBWSURJT0NfTE9HX1NUQVRVUzogT0sNCj4+ DQo+PiBJbnB1dCBpb2N0bHM6DQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19HL1NfVFVORVIvRU5V TV9GUkVRX0JBTkRTOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+ICAgICAgICAgIHRlc3QgVklESU9D X0cvU19GUkVRVUVOQ1k6IE9LIChOb3QgU3VwcG9ydGVkKQ0KPj4gICAgICAgICAgdGVzdCBWSURJ T0NfU19IV19GUkVRX1NFRUs6IE9LIChOb3QgU3VwcG9ydGVkKQ0KPj4gICAgICAgICAgdGVzdCBW SURJT0NfRU5VTUFVRElPOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+ICAgICAgICAgIHRlc3QgVklE SU9DX0cvUy9FTlVNSU5QVVQ6IE9LDQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19HL1NfQVVESU86 IE9LIChOb3QgU3VwcG9ydGVkKQ0KPj4gICAgICAgICAgSW5wdXRzOiAxIEF1ZGlvIElucHV0czog MCBUdW5lcnM6IDANCj4+DQo+PiBPdXRwdXQgaW9jdGxzOg0KPj4gICAgICAgICAgdGVzdCBWSURJ T0NfRy9TX01PRFVMQVRPUjogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAgICAgICB0ZXN0IFZJ RElPQ19HL1NfRlJFUVVFTkNZOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+ICAgICAgICAgIHRlc3Qg VklESU9DX0VOVU1BVURPVVQ6IE9LIChOb3QgU3VwcG9ydGVkKQ0KPj4gICAgICAgICAgdGVzdCBW SURJT0NfRy9TL0VOVU1PVVRQVVQ6IE9LIChOb3QgU3VwcG9ydGVkKQ0KPj4gICAgICAgICAgdGVz dCBWSURJT0NfRy9TX0FVRE9VVDogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAgICAgICBPdXRw dXRzOiAwIEF1ZGlvIE91dHB1dHM6IDAgTW9kdWxhdG9yczogMA0KPj4NCj4+IElucHV0L091dHB1 dCBjb25maWd1cmF0aW9uIGlvY3RsczoNCj4+ICAgICAgICAgIHRlc3QgVklESU9DX0VOVU0vRy9T L1FVRVJZX1NURDogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19F TlVNL0cvUy9RVUVSWV9EVl9USU1JTkdTOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+ICAgICAgICAg IHRlc3QgVklESU9DX0RWX1RJTUlOR1NfQ0FQOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+ICAgICAg ICAgIHRlc3QgVklESU9DX0cvU19FRElEOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+DQo+PiBDb250 cm9sIGlvY3RscyAoSW5wdXQgMCk6DQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19RVUVSWV9FWFRf Q1RSTC9RVUVSWU1FTlU6IE9LDQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19RVUVSWUNUUkw6IE9L DQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19HL1NfQ1RSTDogT0sNCj4+ICAgICAgICAgIHRlc3Qg VklESU9DX0cvUy9UUllfRVhUX0NUUkxTOiBPSw0KPj4gICAgICAgICAgdGVzdCBWSURJT0NfKFVO KVNVQlNDUklCRV9FVkVOVC9EUUVWRU5UOiBPSw0KPj4gICAgICAgICAgdGVzdCBWSURJT0NfRy9T X0pQRUdDT01QOiBPSyAoTm90IFN1cHBvcnRlZCkNCj4+ICAgICAgICAgIFN0YW5kYXJkIENvbnRy b2xzOiA2IFByaXZhdGUgQ29udHJvbHM6IDANCj4+DQo+PiBGb3JtYXQgaW9jdGxzIChJbnB1dCAw KToNCj4+ICAgICAgICAgIHRlc3QgVklESU9DX0VOVU1fRk1UL0ZSQU1FU0laRVMvRlJBTUVJTlRF UlZBTFM6IE9LDQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19HL1NfUEFSTTogT0sNCj4+ICAgICAg ICAgIHRlc3QgVklESU9DX0dfRkJVRjogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAgICAgICB0 ZXN0IFZJRElPQ19HX0ZNVDogT0sNCj4+ICAgICAgICAgIHRlc3QgVklESU9DX1RSWV9GTVQ6IE9L DQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19TX0ZNVDogT0sNCj4+ICAgICAgICAgIHRlc3QgVklE SU9DX0dfU0xJQ0VEX1ZCSV9DQVA6IE9LIChOb3QgU3VwcG9ydGVkKQ0KPj4gICAgICAgICAgdGVz dCBDcm9wcGluZzogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAgICAgICB0ZXN0IENvbXBvc2lu ZzogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAgICAgICB0ZXN0IFNjYWxpbmc6IE9LIChOb3Qg U3VwcG9ydGVkKQ0KPj4NCj4+IENvZGVjIGlvY3RscyAoSW5wdXQgMCk6DQo+PiAgICAgICAgICB0 ZXN0IFZJRElPQ18oVFJZXylFTkNPREVSX0NNRDogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAg ICAgICB0ZXN0IFZJRElPQ19HX0VOQ19JTkRFWDogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+PiAgICAg ICAgICB0ZXN0IFZJRElPQ18oVFJZXylERUNPREVSX0NNRDogT0sgKE5vdCBTdXBwb3J0ZWQpDQo+ Pg0KPj4gQnVmZmVyIGlvY3RscyAoSW5wdXQgMCk6DQo+PiAgICAgICAgICB0ZXN0IFZJRElPQ19S RVFCVUZTL0NSRUFURV9CVUZTL1FVRVJZQlVGOiBPSw0KPj4gICAgICAgICAgdGVzdCBWSURJT0Nf RVhQQlVGOiBPSw0KPj4gICAgICAgICAgdGVzdCBSZXF1ZXN0czogT0sgKE5vdCBTdXBwb3J0ZWQp DQo+Pg0KPj4gVG90YWwgZm9yIGF0bWVsLWlzYyBkZXZpY2UgL2Rldi92aWRlbzA6IDQ0LCBTdWNj ZWVkZWQ6IDQ0LCBGYWlsZWQ6IDAsIFdhcm5pbmdzOiAwDQo+Pg0KPj4NCj4+ICAgTUFJTlRBSU5F UlMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArLQ0KPj4gICBk cml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL01ha2VmaWxlICAgICAgICAgICAgfCAgICA0ICst DQo+PiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRtZWwvYXRtZWwtaXNjLWJhc2UuYyAgICB8 IDIxNDggKysrKysrKysrKysrKysrKysrDQo+PiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRt ZWwvYXRtZWwtaXNjLmMgICAgICAgICB8IDI2MzQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPj4g ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVsLWlzYy5oICAgICAgICAgfCAgMTky ICsrDQo+PiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRtZWwvYXRtZWwtc2FtYTVkMi1pc2Mu YyB8ICAzNjUgKysrDQo+PiAgIDYgZmlsZXMgY2hhbmdlZCwgMjcxMSBpbnNlcnRpb25zKCspLCAy NjM2IGRlbGV0aW9ucygtKQ0KPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9hdG1lbC9hdG1lbC1pc2MtYmFzZS5jDQo+PiAgIGRlbGV0ZSBtb2RlIDEwMDY0NCBk cml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVsLWlzYy5jDQo+PiAgIGNyZWF0ZSBtb2Rl IDEwMDY0NCBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVsLWlzYy5oDQo+PiAgIGNy ZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVsLXNhbWE1 ZDItaXNjLmMNCj4+DQo+IA0KPiBDaGVja3BhdGNoIGdhdmUgbWUgdmFyaW91cyB3YXJuaW5ncyB0 aGF0IEkgdGhpbmsgc2hvdWxkIGJlIGFkZHJlc3NlZDoNCg0KDQpIZWxsbyBIYW5zLA0KDQpJIHNh dyB0aGUgY2hlY2twYXRjaCBpc3N1ZXMgYXMgd2VsbCwgYnV0IG1vc3Qgb2YgdGhlbSBhcmUgaW5o ZXJpdGVkIGFuZCANCmFwcGVhciBub3cgYmVjYXVzZSBvZiBjb2RlIG1vdmUuLi4NCkkgd291bGQg dGhpbmsgaXQgd291bGQgYmUgY2xlYW5lciB0byBzb2x2ZSB0aGVzZSBpc3N1ZXMgaW4gYSBhbiBh LXByaW9yaSANCnBhdGNoLCBhbmQgdGhlbiBkbyB0aGUgc3BsaXQgYXMgYSAiY2xlYW4sanVzdC1z cGxpdCIgcGF0Y2ggYWZ0ZXJ3YXJkcy4NCldoYXQgZG8geW91IHRoaW5rPw0KDQpBbmQgZm9yIHRo ZSBleHRlcm5zLCBJIGNhbiBoYW5kbGUgaXQsIGJ1dCBJIHdvdWxkIGNyZWF0ZSBhIHNlcGFyYXRl IA0KaGVhZGVyIGZpbGUgZm9yIHRoZW0gdGhhdCB3b3VsZCBiZSBpbmNsdWRlZCBpbiBuZXcgYXRt ZWwtc2FtYTVkMi1pc2MuYw0KDQpBcmUgeW91IG9rIHdpdGggdGhpcyBhcHByb2FjaCA/DQoNClRo YW5rcyBmb3IgcmV2aWV3LA0KRXVnZW4NCg0KPiANCj4gV0FSTklORzogZXh0ZXJucyBzaG91bGQg YmUgYXZvaWRlZCBpbiAuYyBmaWxlcw0KPiAjMjQ5OiBGSUxFOiBkcml2ZXJzL21lZGlhL3BsYXRm b3JtL2F0bWVsL2F0bWVsLWlzYy1iYXNlLmM6NDA6DQo+ICtleHRlcm4gdW5zaWduZWQgaW50IHNl bnNvcl9wcmVmZXJyZWQ7DQo+IA0KPiBJdCBsb29rcyBsaWtlIHRoZXNlIG1vZHVsZSBwYXJhbWV0 ZXJzIGNhbiBiZSBtb3ZlZCB0byBhdG1lbC1pc2MtYmFzZS5jDQo+IGFuZCBvbmx5IGFuIGV4dGVy biB1bnNpZ25lZCBpbnQgZGVidWcgc2hvdWxkIGJlIGFkZGVkIHRvIHRoZSBhdG1lbC1pc2MuaC4N Cj4gDQo+IEV4dGVybnMgaW4gYSBzb3VyY2UgaXMgaW5kZWVkIGR1YmlvdXMuDQo+IA0KPiBDSEVD Szogc3BpbmxvY2tfdCBkZWZpbml0aW9uIHdpdGhvdXQgY29tbWVudA0KPiAjNjgxOiBGSUxFOiBk cml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVsLWlzYy5oOjI3Og0KPiArICAgICAgIHNw aW5sb2NrX3QgICAgICBsb2NrOw0KPiANCj4gSSBrbm93IHRoZXJlIHdhcyBubyBjb21tZW50IGJl Zm9yZSwgYnV0IGl0IG1pZ2h0IGJlIG5pY2UgdG8gYWRkIG9uZQ0KPiBub3cuDQo+IA0KPiBDSEVD SzogTWFjcm8gYXJndW1lbnQgcmV1c2UgJ2h3JyAtIHBvc3NpYmxlIHNpZGUtZWZmZWN0cz8NCj4g IzY4ODogRklMRTogZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9hdG1lbC9hdG1lbC1pc2MuaDozNDoN Cj4gKyNkZWZpbmUgdG9faXNjX2NsayhodykgY29udGFpbmVyX29mKGh3LCBzdHJ1Y3QgaXNjX2Ns aywgaHcpDQo+IA0KPiBUaGlzIHNlZW1zIHJlYWxseSB3cm9uZy4gT25lIGh3IHJlZmVycyB0byB0 aGUgYXJndW1lbnQsIHRoZQ0KPiBvdGhlciBpcyB0aGUgbmFtZSBvZiBhIGZpZWxkIGluIGEgc3Ry dWN0LiBVc2UgYSBkaWZmZXJlbnQNCj4gbmFtZSBhcyB0aGUgbWFjcm8gYXJndW1lbnQgdG8gYXZv aWQgdGhpcyBjb25mdXNpb24uDQo+IA0KPiANCj4gQ0hFQ0s6IHNwaW5sb2NrX3QgZGVmaW5pdGlv biB3aXRob3V0IGNvbW1lbnQNCj4gIzgxNDogRklMRTogZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9h dG1lbC9hdG1lbC1pc2MuaDoxNjA6DQo+ICsgICAgICAgc3BpbmxvY2tfdCAgICAgICAgICAgICAg ZG1hX3F1ZXVlX2xvY2s7DQo+IA0KPiBDSEVDSzogc3RydWN0IG11dGV4IGRlZmluaXRpb24gd2l0 aG91dCBjb21tZW50DQo+ICM4MzI6IEZJTEU6IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRtZWwv YXRtZWwtaXNjLmg6MTc4Og0KPiArICAgICAgIHN0cnVjdCBtdXRleCAgICAgICAgICAgIGxvY2s7 DQo+IA0KPiBDSEVDSzogc3BpbmxvY2tfdCBkZWZpbml0aW9uIHdpdGhvdXQgY29tbWVudA0KPiAj ODMzOiBGSUxFOiBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVsLWlzYy5oOjE3OToN Cj4gKyAgICAgICBzcGlubG9ja190ICAgICAgICAgICAgICBhd2JfbG9jazsNCj4gDQo+IENvbW1l bnRzIHdvdWxkIGJlIG5pY2UuDQo+IA0KPiBXQVJOSU5HOiBleHRlcm5zIHNob3VsZCBiZSBhdm9p ZGVkIGluIC5jIGZpbGVzDQo+ICM5MDk6IEZJTEU6IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRt ZWwvYXRtZWwtc2FtYTVkMi1pc2MuYzo1NzoNCj4gK2V4dGVybiBzdHJ1Y3QgaXNjX2Zvcm1hdCBm b3JtYXRzX2xpc3RbXTsNCj4gDQo+IFdBUk5JTkc6IGV4dGVybnMgc2hvdWxkIGJlIGF2b2lkZWQg aW4gLmMgZmlsZXMNCj4gIzkxMDogRklMRTogZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9hdG1lbC9h dG1lbC1zYW1hNWQyLWlzYy5jOjU4Og0KPiArZXh0ZXJuIHN0cnVjdCBpc2NfZm9ybWF0IGNvbnRy b2xsZXJfZm9ybWF0c1tdOw0KPiANCj4gV0FSTklORzogZXh0ZXJucyBzaG91bGQgYmUgYXZvaWRl ZCBpbiAuYyBmaWxlcw0KPiAjOTExOiBGSUxFOiBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVs L2F0bWVsLXNhbWE1ZDItaXNjLmM6NTk6DQo+ICtleHRlcm4gY29uc3QgdTMyIGlzY19nYW1tYV90 YWJsZVtHQU1NQV9NQVggKyAxXVtHQU1NQV9FTlRSSUVTXTsNCj4gDQo+IFdBUk5JTkc6IGV4dGVy bnMgc2hvdWxkIGJlIGF2b2lkZWQgaW4gLmMgZmlsZXMNCj4gIzkxMjogRklMRTogZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS9hdG1lbC9hdG1lbC1zYW1hNWQyLWlzYy5jOjYwOg0KPiArZXh0ZXJuIGNv bnN0IHN0cnVjdCByZWdtYXBfY29uZmlnIGlzY19yZWdtYXBfY29uZmlnOw0KPiANCj4gV0FSTklO RzogZXh0ZXJucyBzaG91bGQgYmUgYXZvaWRlZCBpbiAuYyBmaWxlcw0KPiAjOTEzOiBGSUxFOiBk cml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVsLXNhbWE1ZDItaXNjLmM6NjE6DQo+ICtl eHRlcm4gY29uc3Qgc3RydWN0IHY0bDJfYXN5bmNfbm90aWZpZXJfb3BlcmF0aW9ucyBpc2NfYXN5 bmNfb3BzOw0KPiANCj4gVGhpcyBzaG91bGQgYmUgaW4gYSBoZWFkZXIuDQo+IA0KPiBXQVJOSU5H OiBleHRlcm5zIHNob3VsZCBiZSBhdm9pZGVkIGluIC5jIGZpbGVzDQo+ICM5MTU6IEZJTEU6IGRy aXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRtZWwvYXRtZWwtc2FtYTVkMi1pc2MuYzo2MzoNCj4gK2V4 dGVybiBpcnFyZXR1cm5fdCBpc2NfaW50ZXJydXB0KGludCBpcnEsIHZvaWQgKmRldl9pZCk7DQo+ IA0KPiBXQVJOSU5HOiBleHRlcm5zIHNob3VsZCBiZSBhdm9pZGVkIGluIC5jIGZpbGVzDQo+ICM5 MTY6IEZJTEU6IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRtZWwvYXRtZWwtc2FtYTVkMi1pc2Mu Yzo2NDoNCj4gK2V4dGVybiBpbnQgaXNjX3BpcGVsaW5lX2luaXQoc3RydWN0IGlzY19kZXZpY2Ug KmlzYyk7DQo+IA0KPiBXQVJOSU5HOiBleHRlcm5zIHNob3VsZCBiZSBhdm9pZGVkIGluIC5jIGZp bGVzDQo+ICM5MTc6IEZJTEU6IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXRtZWwvYXRtZWwtc2Ft YTVkMi1pc2MuYzo2NToNCj4gK2V4dGVybiBpbnQgaXNjX2Nsa19pbml0KHN0cnVjdCBpc2NfZGV2 aWNlICppc2MpOw0KPiANCj4gV0FSTklORzogZXh0ZXJucyBzaG91bGQgYmUgYXZvaWRlZCBpbiAu YyBmaWxlcw0KPiAjOTE4OiBGSUxFOiBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL2F0bWVsL2F0bWVs LXNhbWE1ZDItaXNjLmM6NjY6DQo+ICtleHRlcm4gdm9pZCBpc2Nfc3ViZGV2X2NsZWFudXAoc3Ry dWN0IGlzY19kZXZpY2UgKmlzYyk7DQo+IA0KPiBXQVJOSU5HOiBleHRlcm5zIHNob3VsZCBiZSBh dm9pZGVkIGluIC5jIGZpbGVzDQo+ICM5MTk6IEZJTEU6IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0v YXRtZWwvYXRtZWwtc2FtYTVkMi1pc2MuYzo2NzoNCj4gK2V4dGVybiB2b2lkIGlzY19jbGtfY2xl YW51cChzdHJ1Y3QgaXNjX2RldmljZSAqaXNjKTsNCj4gDQo+IFNob3VsZCBhbHNvIGJlIGluIGEg aGVhZGVyLiBObyBuZWVkIHRvIGV4dGVybiB3aGVuIGp1c3QgZGVjbGFyaW5nIHRoZQ0KPiBmdW5j dGlvbiBwcm90b3R5cGUsIEJUVy4NCj4gDQo+IENIRUNLOiBBbGlnbm1lbnQgc2hvdWxkIG1hdGNo IG9wZW4gcGFyZW50aGVzaXMNCj4gIzk2NDogRklMRTogZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9h dG1lbC9hdG1lbC1zYW1hNWQyLWlzYy5jOjExMjoNCj4gKyAgICAgICAgICAgICAgIHN1YmRldl9l bnRpdHkgPSBkZXZtX2t6YWxsb2MoZGV2LA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzaXplb2YoKnN1YmRldl9lbnRpdHkpLCBHRlBfS0VSTkVMKTsNCj4gDQo+ IFBsZWFzZSBmaXggdGhpcyBhcyB3ZWxsLg0KPiANCj4gUmVnYXJkcywNCj4gDQo+IAlIYW5zDQo+ IA0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88E2C28CC5 for ; Wed, 5 Jun 2019 12:08:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91B432067C for ; Wed, 5 Jun 2019 12:08:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cB3xGL8A"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="ZhbkAVc1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91B432067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9oWM3LxBcWYpqjBsAdMr7qMmgGBp8xDTiw+secDOGOA=; b=cB3xGL8AEVki6P /0daJ90DZnwF17u6vOh1MJPWh+kMPso+Y4P4/4Qjd/p64IJ/de5DycUUxI8PMM4WSrWjFFn2mMP2l bdzIxQ+b/FGZUtT+5/VuqgnSr2jXmSe+EDAFNMffmQivOaxvzn1E98QldP71HCK1NQCK9H0fw7zJt Lp5zkWLLI8jDOooLccKuJiVuMHFWl+2q1xxPPmxKQce5pvDzW1pvVu2NCCjBco2bz59UaOJNSKKy+ Pe9guOYlxCJDrvMil0lOtrHt7FeWmHT303j2elZYsLFft1dXMKph9j4Ryr6mP7sY5ud5Cbab9YZUc RPanK0nlflpiz+/V6o3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYUio-0002DX-Qi; Wed, 05 Jun 2019 12:08:50 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYUik-0002Cl-3J for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 12:08:48 +0000 Received-SPF: Pass (esa6.microchip.iphmx.com: domain of Eugen.Hristev@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Eugen.Hristev@microchip.com"; x-sender="Eugen.Hristev@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa6.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Eugen.Hristev@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa6.microchip.iphmx.com; spf=Pass smtp.mailfrom=Eugen.Hristev@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com X-IronPort-AV: E=Sophos;i="5.60,550,1549954800"; d="scan'208";a="33174611" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Jun 2019 05:08:43 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.87.151) by chn-vm-ex03.mchp-main.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 5 Jun 2019 05:08:43 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 5 Jun 2019 05:08:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=91e0t0Nuqmb6b0khNhfo9Y9EqXIZL4gnIVBkUQAOZRI=; b=ZhbkAVc1eCG4RAOoGsDPyPMC8OOVBSzjWMWUggoA2vmPz1rDZwUda2d6LwQb1sb9eI1f9URPC+GX9Cyselwrt2kKPVhNdhr9oz9bCudtvr6P3KpZ9/rOrZyIWll0cQp+gLG+LH0TDTqihM8D3X+pQQQXT9q9YVRefRHyq5DpPUw= Received: from DM5PR11MB1242.namprd11.prod.outlook.com (10.168.108.8) by DM5PR11MB1676.namprd11.prod.outlook.com (10.172.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Wed, 5 Jun 2019 12:08:41 +0000 Received: from DM5PR11MB1242.namprd11.prod.outlook.com ([fe80::2807:f606:3b7c:cce9]) by DM5PR11MB1242.namprd11.prod.outlook.com ([fe80::2807:f606:3b7c:cce9%9]) with mapi id 15.20.1943.018; Wed, 5 Jun 2019 12:08:41 +0000 From: To: , , , Subject: Re: [PATCH v2] media: atmel: atmel-isc: split driver into driver base and isc Thread-Topic: [PATCH v2] media: atmel: atmel-isc: split driver into driver base and isc Thread-Index: AQHVFrxThsCvxgIDlEymA9iRK8Mn9qaM/daAgAACVwA= Date: Wed, 5 Jun 2019 12:08:40 +0000 Message-ID: <613e2e74-6ac7-93ce-6fb7-d570852bf1e3@microchip.com> References: <1559202331-15397-1-git-send-email-eugen.hristev@microchip.com> <4f1925a5-9361-7f57-4526-3d28be8291dd@xs4all.nl> In-Reply-To: <4f1925a5-9361-7f57-4526-3d28be8291dd@xs4all.nl> Accept-Language: ro-RO, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1P194CA0010.EURP194.PROD.OUTLOOK.COM (2603:10a6:800:be::20) To DM5PR11MB1242.namprd11.prod.outlook.com (2603:10b6:3:14::8) x-ms-exchange-messagesentrepresentingtype: 1 x-tagtoolbar-keys: D20190605150428781 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2887ec3-ceaa-4683-0666-08d6e9ae8c4a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:DM5PR11MB1676; x-ms-traffictypediagnostic: DM5PR11MB1676: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 00594E8DBA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(346002)(376002)(366004)(199004)(189003)(8676002)(72206003)(14454004)(7736002)(25786009)(53936002)(305945005)(2501003)(76176011)(110136005)(316002)(81156014)(2201001)(99286004)(81166006)(73956011)(53546011)(52116002)(102836004)(386003)(6506007)(66066001)(8936002)(6512007)(478600001)(6246003)(86362001)(31696002)(36756003)(31686004)(14444005)(5660300002)(71190400001)(71200400001)(4326008)(229853002)(2906002)(26005)(186003)(6486002)(66946007)(11346002)(66446008)(64756008)(66556008)(66476007)(68736007)(476003)(2616005)(6436002)(486006)(256004)(446003)(6116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR11MB1676; H:DM5PR11MB1242.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: bYPpOMbIK+zKkHtIFbNbo0mEJfRPfMqeqatM1ezlGeQBGwbrvjkZMxTgCfh3OWudrtyf42s6Z32Ap3Jk0M84cG9K4S+4ZrfFrmxg+ajo80BIYot73IEjJ5SeLIRu22+k4zWoqwjqp2CiwzChj5qYu/Lwm4smj6IQrSI9xeA7Pd1SDtvtssBqfGfMf1haFzB6SgjgmrrCy8TehA7QGqseuaJtycjQcglGS238xl5OiOuN3kQhkIRN6b9P7kx5h6EVwIV3KV65iFtqapUkS/YJv6nhIIMtx9oEPBjdvCm5lHkPRQ0hLlu/MJiM2QL9ZrW+8SNGemp+qp4m0rZ+5cZpVCtPB1mEJV96sGQv/1bb4l6FN0AA0Kh/y3KGfDXvxwxe5arWvzmkWOj4ifspCWHFTi8tL2ur/V1D2BN2KMjwajc= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f2887ec3-ceaa-4683-0666-08d6e9ae8c4a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2019 12:08:40.9869 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eugen.hristev@microchip.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1676 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_050846_242113_AED98E72 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ksloat@aampglobal.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05.06.2019 14:56, Hans Verkuil wrote: > > Hi Eugen, > > On 5/30/19 9:50 AM, Eugen.Hristev@microchip.com wrote: >> From: Eugen Hristev >> >> This splits the Atmel ISC driver into a common base: atmel-isc-base.c >> and the driver probe/dt part , atmel-sama5d2-isc.c >> This is needed to keep a common ground for the sensor controller which will >> be reused. >> The atmel-isc will use the common symbols inside the atmel-isc-base >> Future driver will also use the same symbols and redefine different aspects, >> for a different version of the ISC. >> This is done to avoid complete code duplication by creating a totally >> different driver for the new variant of the ISC. >> >> Signed-off-by: Eugen Hristev >> --- >> >> Hello Hans, >> >> I am resending this with the required fixes. >> You asked me about the #ifdef around ATMEL_ISC_NAME, it's because I was >> thinking to have the ATMEL_ISC_NAME different by each driver that use >> the atmel-isc.h, but for now I removed any ifdef around it, and will >> consider a different define for new drivers. >> >> Changes in v2: >> - renamed atmel-isc.c to atmel-sama5d2-isc.c as sama5d2 is the SoC that >> includes this hardware block. The module will still be named atmel-isc.ko >> - removed ifdef around definition of ATMEL_ISC_NAME >> - moved external declarations in the specific files, this was breaking >> module loading >> >> v4l2-compliance SHA: 0d61ddede7d340ffa1c75a2882e30c455ef3d8b8, 32 bitatmel-isc f0008000.isc: ================= START STATUS ================= >> >> atmelpliance test for atmel-isc device /dev/video0: >> >> Driver Info: >> Driver name : atmel-isc >> Card type : Atmel Image Sensor Controller >> Bus info : platform:atmel-isc f0008000.isc >> Driver version : 5.2.0 >> Capabilities : 0x84200001 >> Video Capture >> Streaming >> Extended Pix Format >> Device Capabilities >> Device Caps : 0x04200001 >> Video Capture >> Streaming >> Extended Pix Format >> >> Required ioctls: >> test VIDIOC_QUERYCAP: OK >> >> Allow for multiple opens: >> test second /dev/video0 open: OK >> test VIDIOC_QUERYCAP: OK >> test VIDIOC_G/S_PRIORITY: OK >> test for unlimited opens: OK >> >> Debug ioctls: >> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) >> -isc f0008000.isc: Brightness: 0 >> atmel-isc f0008000.isc: Contrast: 256 >> atmel-isc f0008000.isc: Gamma: 2 >> atmel-isc f0008000.isc: White Balance, Automatic: true >> atmel-isc f0008000.isc: ================== END STATUS ================== >> test VIDIOC_LOG_STATUS: OK >> >> Input ioctls: >> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) >> test VIDIOC_G/S_FREQUENCY: OK (Not Supported) >> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) >> test VIDIOC_ENUMAUDIO: OK (Not Supported) >> test VIDIOC_G/S/ENUMINPUT: OK >> test VIDIOC_G/S_AUDIO: OK (Not Supported) >> Inputs: 1 Audio Inputs: 0 Tuners: 0 >> >> Output ioctls: >> test VIDIOC_G/S_MODULATOR: OK (Not Supported) >> test VIDIOC_G/S_FREQUENCY: OK (Not Supported) >> test VIDIOC_ENUMAUDOUT: OK (Not Supported) >> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) >> test VIDIOC_G/S_AUDOUT: OK (Not Supported) >> Outputs: 0 Audio Outputs: 0 Modulators: 0 >> >> Input/Output configuration ioctls: >> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) >> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) >> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) >> test VIDIOC_G/S_EDID: OK (Not Supported) >> >> Control ioctls (Input 0): >> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK >> test VIDIOC_QUERYCTRL: OK >> test VIDIOC_G/S_CTRL: OK >> test VIDIOC_G/S/TRY_EXT_CTRLS: OK >> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK >> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) >> Standard Controls: 6 Private Controls: 0 >> >> Format ioctls (Input 0): >> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK >> test VIDIOC_G/S_PARM: OK >> test VIDIOC_G_FBUF: OK (Not Supported) >> test VIDIOC_G_FMT: OK >> test VIDIOC_TRY_FMT: OK >> test VIDIOC_S_FMT: OK >> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) >> test Cropping: OK (Not Supported) >> test Composing: OK (Not Supported) >> test Scaling: OK (Not Supported) >> >> Codec ioctls (Input 0): >> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) >> test VIDIOC_G_ENC_INDEX: OK (Not Supported) >> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) >> >> Buffer ioctls (Input 0): >> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK >> test VIDIOC_EXPBUF: OK >> test Requests: OK (Not Supported) >> >> Total for atmel-isc device /dev/video0: 44, Succeeded: 44, Failed: 0, Warnings: 0 >> >> >> MAINTAINERS | 4 +- >> drivers/media/platform/atmel/Makefile | 4 +- >> drivers/media/platform/atmel/atmel-isc-base.c | 2148 ++++++++++++++++++ >> drivers/media/platform/atmel/atmel-isc.c | 2634 ---------------------- >> drivers/media/platform/atmel/atmel-isc.h | 192 ++ >> drivers/media/platform/atmel/atmel-sama5d2-isc.c | 365 +++ >> 6 files changed, 2711 insertions(+), 2636 deletions(-) >> create mode 100644 drivers/media/platform/atmel/atmel-isc-base.c >> delete mode 100644 drivers/media/platform/atmel/atmel-isc.c >> create mode 100644 drivers/media/platform/atmel/atmel-isc.h >> create mode 100644 drivers/media/platform/atmel/atmel-sama5d2-isc.c >> > > Checkpatch gave me various warnings that I think should be addressed: Hello Hans, I saw the checkpatch issues as well, but most of them are inherited and appear now because of code move... I would think it would be cleaner to solve these issues in a an a-priori patch, and then do the split as a "clean,just-split" patch afterwards. What do you think? And for the externs, I can handle it, but I would create a separate header file for them that would be included in new atmel-sama5d2-isc.c Are you ok with this approach ? Thanks for review, Eugen > > WARNING: externs should be avoided in .c files > #249: FILE: drivers/media/platform/atmel/atmel-isc-base.c:40: > +extern unsigned int sensor_preferred; > > It looks like these module parameters can be moved to atmel-isc-base.c > and only an extern unsigned int debug should be added to the atmel-isc.h. > > Externs in a source is indeed dubious. > > CHECK: spinlock_t definition without comment > #681: FILE: drivers/media/platform/atmel/atmel-isc.h:27: > + spinlock_t lock; > > I know there was no comment before, but it might be nice to add one > now. > > CHECK: Macro argument reuse 'hw' - possible side-effects? > #688: FILE: drivers/media/platform/atmel/atmel-isc.h:34: > +#define to_isc_clk(hw) container_of(hw, struct isc_clk, hw) > > This seems really wrong. One hw refers to the argument, the > other is the name of a field in a struct. Use a different > name as the macro argument to avoid this confusion. > > > CHECK: spinlock_t definition without comment > #814: FILE: drivers/media/platform/atmel/atmel-isc.h:160: > + spinlock_t dma_queue_lock; > > CHECK: struct mutex definition without comment > #832: FILE: drivers/media/platform/atmel/atmel-isc.h:178: > + struct mutex lock; > > CHECK: spinlock_t definition without comment > #833: FILE: drivers/media/platform/atmel/atmel-isc.h:179: > + spinlock_t awb_lock; > > Comments would be nice. > > WARNING: externs should be avoided in .c files > #909: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:57: > +extern struct isc_format formats_list[]; > > WARNING: externs should be avoided in .c files > #910: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:58: > +extern struct isc_format controller_formats[]; > > WARNING: externs should be avoided in .c files > #911: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:59: > +extern const u32 isc_gamma_table[GAMMA_MAX + 1][GAMMA_ENTRIES]; > > WARNING: externs should be avoided in .c files > #912: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:60: > +extern const struct regmap_config isc_regmap_config; > > WARNING: externs should be avoided in .c files > #913: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:61: > +extern const struct v4l2_async_notifier_operations isc_async_ops; > > This should be in a header. > > WARNING: externs should be avoided in .c files > #915: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:63: > +extern irqreturn_t isc_interrupt(int irq, void *dev_id); > > WARNING: externs should be avoided in .c files > #916: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:64: > +extern int isc_pipeline_init(struct isc_device *isc); > > WARNING: externs should be avoided in .c files > #917: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:65: > +extern int isc_clk_init(struct isc_device *isc); > > WARNING: externs should be avoided in .c files > #918: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:66: > +extern void isc_subdev_cleanup(struct isc_device *isc); > > WARNING: externs should be avoided in .c files > #919: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:67: > +extern void isc_clk_cleanup(struct isc_device *isc); > > Should also be in a header. No need to extern when just declaring the > function prototype, BTW. > > CHECK: Alignment should match open parenthesis > #964: FILE: drivers/media/platform/atmel/atmel-sama5d2-isc.c:112: > + subdev_entity = devm_kzalloc(dev, > + sizeof(*subdev_entity), GFP_KERNEL); > > Please fix this as well. > > Regards, > > Hans > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel