From: Rohit Kumar <rohitkr@codeaurora.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org,
srinivas.kandagatla@linaro.org,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver
Date: Mon, 24 Sep 2018 12:38:33 +0530 [thread overview]
Message-ID: <614ab0e7-b751-4bf9-72f9-33fdd57594ec@codeaurora.org> (raw)
In-Reply-To: <79bee282-e8a4-a1e6-56e3-6ea7e20c0233@codeaurora.org>
On 9/24/2018 12:19 PM, Rohit Kumar wrote:
> Thanks Sibi for reviewing.
>
>
> On 9/22/2018 1:11 AM, Sibi Sankar wrote:
>> Hi Rohit,
>>
>> On 2018-09-03 17:22, Rohit kumar wrote:
>>> This adds Non PAS ADSP PIL driver for Qualcomm
>>> Technologies Inc SoCs.
>>> Added initial support for SDM845 with ADSP bootup and
>>> shutdown operation handled from Application Processor
>>> SubSystem(APSS).
>>>
>>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>>> ---
>> ....
...
>> ....
>> Also I see the following warns on stopping the adsp remoteproc,
>> couldn't root cause it though:
>
> It should be issue in Q6 drivers. I will check and update q6 drivers.
> Thanks for reporting.
>
Checked this warning. This is a core driver issue fixed with
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/base/core.c?h=next-20180924&id=2ec16150179888b81717d1d3ce84e634f4736af2
>> device_del+0x84/0x29c
>> platform_device_del+0x2c/0x88
>> platform_device_unregister+0x1c/0x30
>> of_platform_device_destroy+0x98/0xa8
>> device_for_each_child+0x54/0xa4
>> of_platform_depopulate+0x38/0x54
>> q6asm_remove+0x1c/0x2c
>> apr_device_remove+0x38/0x70
>> device_release_driver_internal+0x124/0x1c8
>> device_release_driver+0x24/0x30
>> bus_remove_device+0xcc/0xe4
>> device_del+0x1f8/0x29c
>> device_unregister+0x1c/0x30
>> apr_remove_device+0x1c/0x2c
>> device_for_each_child+0x54/0xa4
>> apr_remove+0x28/0x34
>> rpmsg_dev_remove+0x48/0x70
>> device_release_driver_internal+0x124/0x1c8
>> device_release_driver+0x24/0x30
>> bus_remove_device+0xcc/0xe4
>> device_del+0x1f8/0x29c
>> device_unregister+0x1c/0x30
>> qcom_glink_remove_device+0x1c/0x2c
>> device_for_each_child+0x54/0xa4
>> qcom_glink_native_remove+0x54/0x15c
>> qcom_glink_smem_unregister+0x1c/0x30
>> glink_subdev_stop+0x1c/0x2c [qcom_common]
>> rproc_stop+0x40/0xc0
>> rproc_shutdown+0x6c/0xc0
>> rproc_del+0x28/0xa0
>> adsp_remove+0x20/0x5c [qcom_adsp_pil]
>> platform_drv_remove+0x28/0x50
>> device_release_driver_internal+0x124/0x1c8
>> driver_detach+0x44/0x80
>> bus_remove_driver+0x78/0x9c
>> driver_unregister+0x34/0x54
>> platform_driver_unregister+0x1c/0x28
>> cleanup_module+0x14/0x6bc [qcom_adsp_pil]
>> SyS_delete_module+0x1c4/0x214
>>
>
> Thanks,
> Rohit
Thanks
next prev parent reply other threads:[~2018-09-24 7:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 11:52 [PATCH v3 0/2] Add ADSP PIL driver for SDM845 Rohit kumar
2018-09-03 11:52 ` [PATCH v3 1/2] dt-binding: remoteproc: Add QTI ADSP PIL bindings Rohit kumar
2018-09-10 18:27 ` Bjorn Andersson
2018-09-10 20:01 ` Rob Herring
2018-09-11 3:46 ` Rohit Kumar
2018-09-03 11:52 ` [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver Rohit kumar
2018-09-10 18:31 ` Bjorn Andersson
2018-09-11 3:49 ` Rohit Kumar
2018-09-21 19:41 ` Sibi Sankar
2018-09-24 6:49 ` Rohit Kumar
2018-09-24 7:08 ` Rohit Kumar [this message]
2018-09-24 12:02 ` Sibi Sankar
2018-09-24 12:04 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614ab0e7-b751-4bf9-72f9-33fdd57594ec@codeaurora.org \
--to=rohitkr@codeaurora.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.