From: Matthieu Baerts <matthieu.baerts at tessares.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net v2] mptcp: fix length of ADD_ADDR with port suboption
Date: Mon, 08 Mar 2021 11:49:22 +0100 [thread overview]
Message-ID: <614f4ddb-fdc5-1cd7-b651-570cdcbd72e6@tessares.net> (raw)
In-Reply-To: dfea8e080c5e8bbcbeefa64a4b8d7ff2becea639.1614874814.git.dcaratti@redhat.com
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Hi Davide, Geliang, Mat,
On 04/03/2021 17:23, Davide Caratti wrote:
> in current Linux, MPTCP peers advertising endpoints with port numbers use
> a sub-option length that wrongly accounts for the trailing TCP NOP. Also,
> receivers will only process incoming ADD_ADDR with port having such wrong
> sub-option length. Fix this, making ADD_ADDR compliant to RFC8684 §3.4.1.
>
> this can be verified running tcpdump on the kselftests artifacts:
Thank you for the patch, review and testing!
Sorry for the delay to apply it, I was doing other modifications in the
tree to ease CI scripts and because I got a conflict with the export
branch, I didn't apply it before :)
- 268780afbf25: mptcp: fix length of ADD_ADDR with port sub-option
- d16c1995a017: conflict in t/mptcp-add-rm_list-in-mptcp_out_options
- Results: b6772f0348c6..ec0b131d1b83
Tests + export are going to be started soon!
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next reply other threads:[~2021-03-08 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 10:49 Matthieu Baerts [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-05 2:14 [MPTCP] Re: [PATCH net v2] mptcp: fix length of ADD_ADDR with port suboption Geliang Tang
2021-03-05 0:28 Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614f4ddb-fdc5-1cd7-b651-570cdcbd72e6@tessares.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.