From: Valdis.Kletnieks@vt.edu
To: Ravishankar K Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: comedi: fix line over 80 character issue in s626.c
Date: Fri, 02 Sep 2011 06:52:59 -0400 [thread overview]
Message-ID: <6154.1314960779@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Fri, 02 Sep 2011 12:58:07 +0530." <1314948487-3475-1-git-send-email-ravishankar.km@greenturtles.in>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On Fri, 02 Sep 2011 12:58:07 +0530, Ravishankar K Mallikarjunayya said:
> This is a patch to the s626.c file that fixes up a line over 80 character
Patch looks mostly good - but a question:
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> @@ -266,7 +267,11 @@ module_exit(driver_s626_cleanup_module);
> static int s626_ai_insn_config(struct comedi_device *dev,
> struct comedi_subdevice *s,
> struct comedi_insn *insn, unsigned int *data);
> -/* static int s626_ai_rinsn(struct comedi_device *dev,struct comedi_subdevice *s,struct comedi_insn *insn,unsigned int *data); */
> +/*
> + * static int s626_ai_rinsn(struct comedi_device *dev,
> + * struct comedi_subdevice *s, struct comedi_insn *insn,
> + * unsigned int *data);
> + */
At 4 places, you fix commented-out function prototypes. Maybe they should
just be deleted instead?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-09-02 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 1/2]Staging: comedi: fix line over 80 character issue in s626.c>
2011-09-02 7:28 ` [PATCH 1/2] Staging: comedi: fix line over 80 character issue in s626.c Ravishankar K Mallikarjunayya
2011-09-02 10:52 ` Valdis.Kletnieks [this message]
2011-09-08 18:09 ` Ravishankar K Mallikarjunayya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6154.1314960779@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.