From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prashant Bhole Subject: Re: [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout Date: Mon, 21 May 2018 14:15:36 +0900 Message-ID: <615c089e-47a6-e36c-9ad4-2c86a8edeaa1@lab.ntt.co.jp> References: <20180518071753.4768-1-bhole_prashant_q7@lab.ntt.co.jp> <20180518071753.4768-4-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Shuah Khan , netdev@vger.kernel.org To: John Fastabend , Alexei Starovoitov , Daniel Borkmann Return-path: Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:60932 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbeEUFQa (ORCPT ); Mon, 21 May 2018 01:16:30 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/19/2018 1:47 AM, John Fastabend wrote: > On 05/18/2018 12:17 AM, Prashant Bhole wrote: >> In order to reduce runtime of tests, recently timout for select() call >> was reduced from 1sec to 10usec. This was causing many tests failures. >> It was caught with failure handling commits in this series. >> >> Restoring the timeout from 10usec to 1sec >> >> Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests") >> Signed-off-by: Prashant Bhole >> --- > > Whats the runtime for the entire test suite after this? I agree > I was probably to aggressive in setting this but on the other > hand I was trying to avoid letting the test run for minutes. > Currently any failure stops further tests. So I made local change to force cork=0. With this change, it takes around 60 seconds for all 648 tests. It will change after fixing cork tests. -Prashant