From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbcA0Kdd (ORCPT ); Wed, 27 Jan 2016 05:33:33 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:58057 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624AbcA0Kd3 (ORCPT ); Wed, 27 Jan 2016 05:33:29 -0500 From: Arnd Bergmann To: James Liao Cc: linux-arm-kernel@lists.infradead.org, kbuild test robot , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, Mike Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kbuild-all@01.org, Sascha Hauer , Matthias Brugger , linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section Date: Wed, 27 Jan 2016 11:32:29 +0100 Message-ID: <6167008.u8jfFpmfhy@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1453888578.28646.7.camel@mtksdaap41> References: <201601271708.gQUxXACW%fengguang.wu@intel.com> <4711589.Ig064LES4c@wuerfel> <1453888578.28646.7.camel@mtksdaap41> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:VkDKArxD/8X6AkGtShnBqollsd9Iyc0OSQhlXhQ0VECEyR6wgVg VzCh8SVgan2Y43UINn1USpMHlMmaPpUtDskYsRHQxOQT5bImDueNgHk3IGPlPvUdIX1lOQA MzVeHRJ1ZBwKLi+JXTJ3K9Bfr8DkNbE+Y7rRmvWCNCWy4JSKrgg6ibBXAt2Rsj82oIynHJ+ H+129KyX29hWgMbGNX3aw== X-UI-Out-Filterresults: notjunk:1;V01:K0:sGPUY+nvQiY=:f9e3nlLh/7vLtAokN4QjOo vfs+CMhalW+RSiAE4XgQZE8oM/OGQzg2b6qPSakXVhjb2+vaFlmRsn1yNHYKWBvvBawGelU/V 5Oof4epM8XjL4wh8mqiVJkNEWuUzIcnfyQGt2wLhJr5Us92c7VHa0rae+p/1l6Z7IDfnsk4EE IYcxAn7BMb8qSnPdlIYCj9GR8kd+1NhemBAfKJScx+80wIiYhPySgrTGv3Jx7zhNSwI0dnGEi 9xwC+KBlyxNKJNz0BUuLKM2uoMsz8QtTfM6a08e1MzE4Z0FbPWn2OTJeIvU6V4yuC0CTW7UA/ EAqoXaG/KUFx72snIQ4FGbgo5yk6YtDFxxxL6xRoLjYu+c9og/vqSsIi2ELqWWiXAEnXgKdP9 l27xtRNUxqUxvdZG/Si1FhnMDwVfPeOh0wKJAekVPkAnsJuZCm7jv4ATHh2UktwCdeWa1Zz0A 7obnw1aPuKrAIE6FyOlfFimpnuzenGAnabbCcMI0CMv/M8tq5z/9Jgg2V3tqGGUvCyR6B813q ii7hLfvkWVRqQYkAGZwi9MHyiMJRtmXmssKWRFtF/9aGE8L9ZhjTcRJJ4nCJezQcz3Io+1TYh 39B8ABs+AxDcJx0hPhQ4GoJOVKZOERXCIA2fNbB8x+kiWvL0YsdKepR9WgCM6Bag8e+hy5q2L 9b4Az3WDTRbaz5cAdMjf/wXM2Zi8hqzb+qlhAyfuRfaIRQuUKcXbBtXy+Wf0ANhbZY/xVHWz5 ZOBHgbxHWBpfkzfy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 27 January 2016 17:56:18 James Liao wrote: > > > > I think you should include this change in your patch, or as a preparation. > > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM, > > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that > > selects COMMON_CLK. > > Oops, I didn't notice there are warnings after moving these Kconfigs > into menu section. > > The original motivation of this patch is preventing new clk drivers > include their Kconfig in a wrong place, so it's not critical. Do you > think we should apply this patch (with your changes below) or drop this > patch directly? I think your patch is good, we just need to fix S3C24xx, which is doing things in a strange way for historic reasons. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 27 Jan 2016 11:32:29 +0100 Subject: [PATCH] clk: Move vendor's Kconfig into CCF menu section In-Reply-To: <1453888578.28646.7.camel@mtksdaap41> References: <201601271708.gQUxXACW%fengguang.wu@intel.com> <4711589.Ig064LES4c@wuerfel> <1453888578.28646.7.camel@mtksdaap41> Message-ID: <6167008.u8jfFpmfhy@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 27 January 2016 17:56:18 James Liao wrote: > > > > I think you should include this change in your patch, or as a preparation. > > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM, > > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that > > selects COMMON_CLK. > > Oops, I didn't notice there are warnings after moving these Kconfigs > into menu section. > > The original motivation of this patch is preventing new clk drivers > include their Kconfig in a wrong place, so it's not critical. Do you > think we should apply this patch (with your changes below) or drop this > patch directly? I think your patch is good, we just need to fix S3C24xx, which is doing things in a strange way for historic reasons. Arnd