All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Branden <scott.branden@broadcom.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Eric Anholt <eric@anholt.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: defconfig: Enable BCM2835_POWER for bcm2835 and multi_v7
Date: Wed, 23 Jan 2019 08:41:17 -0800	[thread overview]
Message-ID: <616d33b6-a8c8-3ead-c0f5-f87ca71b84b6@broadcom.com> (raw)
In-Reply-To: <1548252470-17920-1-git-send-email-stefan.wahren@i2se.com>

Hi Stefan,

On 2019-01-23 6:07 a.m., Stefan Wahren wrote:
> Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the
> PM driver instead of firmware.") VC4 on BCM2835 requires the power driver.
>
> Otherwise the driver won't probe and HDMI output stays black:
> vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>   arch/arm/configs/bcm2835_defconfig  | 1 +
>   arch/arm/configs/multi_v7_defconfig | 1 +
>   2 files changed, 2 insertions(+)

Seems more fool proof to add a default ARCH_BCM3825 in the Kconfig

instead of modifying multiple defconfig files.

And that way users with custom defconfig files for 2835 will get the 
config change automatically.

>
> diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig
> index bb6a35f..28aacdd 100644
> --- a/arch/arm/configs/bcm2835_defconfig
> +++ b/arch/arm/configs/bcm2835_defconfig
> @@ -132,6 +132,7 @@ CONFIG_SND_BCM2835=m
>   CONFIG_MAILBOX=y
>   CONFIG_BCM2835_MBOX=y
>   # CONFIG_IOMMU_SUPPORT is not set
> +CONFIG_BCM2835_POWER=y
>   CONFIG_RASPBERRYPI_POWER=y
>   CONFIG_PWM=y
>   CONFIG_PWM_BCM2835=y
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index ffaf5c0..7deb404 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -900,6 +900,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y
>   CONFIG_REMOTEPROC=m
>   CONFIG_ST_REMOTEPROC=m
>   CONFIG_RPMSG_VIRTIO=m
> +CONFIG_BCM2835_POWER=y
>   CONFIG_RASPBERRYPI_POWER=y
>   CONFIG_QCOM_GSBI=y
>   CONFIG_QCOM_PM=y

Regards,

  Scott


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-23 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 14:07 [PATCH 1/2] ARM: defconfig: Enable BCM2835_POWER for bcm2835 and multi_v7 Stefan Wahren
2019-01-23 14:07 ` [PATCH 2/2] arm64: defconfig: Enable BCM2835_POWER Stefan Wahren
2019-01-23 16:41 ` Scott Branden [this message]
2019-01-23 17:22   ` [PATCH 1/2] ARM: defconfig: Enable BCM2835_POWER for bcm2835 and multi_v7 Stefan Wahren
2019-01-23 17:26     ` Scott Branden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=616d33b6-a8c8-3ead-c0f5-f87ca71b84b6@broadcom.com \
    --to=scott.branden@broadcom.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.