All of lore.kernel.org
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
	"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
	Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] quotactl.2: Remove kernel version for Q_XQUOTARM ioctl
Date: Thu, 4 Nov 2021 00:58:02 +0000	[thread overview]
Message-ID: <6183302D.8080102@fujitsu.com> (raw)
In-Reply-To: <3dfbc2c2-72d9-89f2-1c72-e54ab2f610e7@gmail.com>

Hi  Alejandro
> [CC += Jan]
>
> Hi Yang,
>
> On 11/3/21 10:29, xuyang2018.jy@fujitsu.com wrote:
>> [Fix Alejandro mail address ]
>>> Hi Alejandro
>>>
>>> You merged another quotactl patch, but I guess you missed this.
>
> Thanks!
>
>>>
>>>
>>> Best Regards
>>> Yang Xu
>>>> Hi Alejandro, Michael
>>>>
>>>> Ping!
>>>>
>>>> Best Regards
>>>> Yang Xu
>>>>> This patch[1] is designed to fix bug for Q_XQUOTARM ioctl not for
>>>>> introduced.
>>>>> So remove it.
>>>>>
>>>>> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9da93f9b7c
>>>>>
>>>>>
>>>>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>>>>> ---
>>>>> man2/quotactl.2 | 3 +--
>>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/man2/quotactl.2 b/man2/quotactl.2
>>>>> index d22d8c584..46f77a8b1 100644
>>>>> --- a/man2/quotactl.2
>>>>> +++ b/man2/quotactl.2
>>>>> @@ -651,8 +651,7 @@ The
>>>>> .I id
>>>>> argument is ignored.
>>>>> .TP
>>>>> -.B Q_XQUOTARM " (since Linux 3.16)"
>>>>> -.\" 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc
>
> Okay. Since you added that line (man-pages commit ae848b1d80), I'm fine
> removing it. Was it a mistake? The commit message of that commit is a
> bit unrelated to Q_XQUOTARM, isn't it?
Yes.
>
> Maybe a better fix would be to replace the kernel version and the commit
> hash when it was really added?
Yes, but I can't find this commit hash and it seems been supported since 
long time ago.

Best Regards
Yang Xu
>
> I'll wait for your answer before applying the patch.
>
> Thanks,
>
> Alex
>
>>>>> +.B Q_XQUOTARM
>>>>> Free the disk space taken by disk quotas.
>>>>> The
>>>>> .I addr
>
>

  reply	other threads:[~2021-11-04  1:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  1:46 [PATCH] quotactl.2: Remove kernel version for Q_XQUOTARM ioctl Yang Xu
2021-11-01  3:38 ` xuyang2018.jy
2021-11-03  9:19   ` xuyang2018.jy
2021-11-03  9:29     ` xuyang2018.jy
2021-11-03 14:29       ` Alejandro Colomar (man-pages)
2021-11-04  0:58         ` xuyang2018.jy [this message]
2021-11-04 10:43           ` Eugene Syromyatnikov
2021-11-04 11:02             ` Eugene Syromyatnikov
2021-11-04 10:53           ` Jan Kara
2021-11-04 20:10             ` Alejandro Colomar (man-pages)
2021-11-05  3:05               ` xuyang2018.jy
2021-11-05 11:34                 ` Jan Kara
2021-11-08  2:37                   ` xuyang2018.jy
2021-11-05 11:20               ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6183302D.8080102@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=alx.manpages@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.