All of lore.kernel.org
 help / color / mirror / Atom feed
From: cgxu <cgxu519@mykernel.net>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: delete incorrect comment for ext2_blks_to_allocate()
Date: Fri, 3 Jul 2020 19:32:15 +0800	[thread overview]
Message-ID: <619147f3-89f5-3e8c-ff12-0f2115ae6d73@mykernel.net> (raw)
In-Reply-To: <20200703102019.GC4355@quack2.suse.cz>

On 7/3/20 6:20 PM, Jan Kara wrote:
> On Thu 02-07-20 17:56:36, Chengguang Xu wrote:
>> ext2_blks_to_allocate() only counts direct blocks need to be allocated,
>> return value does not include indirect blocks.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
>> ---
>>   fs/ext2/inode.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
>> index c8b371c82b4f..4df849e694dd 100644
>> --- a/fs/ext2/inode.c
>> +++ b/fs/ext2/inode.c
>> @@ -355,9 +355,6 @@ static inline ext2_fsblk_t ext2_find_goal(struct inode *inode, long block,
>>    *	@k: number of blocks need for indirect blocks
>>    *	@blks: number of data blocks to be mapped.
>>    *	@blocks_to_boundary:  the offset in the indirect block
>> - *
>> - *	return the total number of blocks to be allocate, including the
>> - *	direct and indirect blocks.
> 
> You're right the comment is wrong but instead of deleting it, I'd rather
> fix it like: "Return the number of direct blocks to allocate."
> 

That's fine, I can resend it with another comment fix together.

Thanks,
cgxu

      reply	other threads:[~2020-07-03 11:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  9:56 [PATCH] ext2: delete incorrect comment for ext2_blks_to_allocate() Chengguang Xu
2020-07-03 10:20 ` Jan Kara
2020-07-03 11:32   ` cgxu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=619147f3-89f5-3e8c-ff12-0f2115ae6d73@mykernel.net \
    --to=cgxu519@mykernel.net \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.