All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 4/4] board: gateworks: imx8mm: Add Gateworks Venice board support
Date: Tue, 2 Mar 2021 09:14:39 +0100	[thread overview]
Message-ID: <619cce29-8b0c-9a35-a2b3-58651bd878e7@denx.de> (raw)
In-Reply-To: <CAJ+vNU24LnRat7kd=uUKaH6EFGp-9kKmjM-79W0pmfez7dob1A@mail.gmail.com>

On 01.03.21 23:18, Tim Harvey wrote:
> On Mon, Mar 1, 2021 at 8:04 AM Stefano Babic <sbabic@denx.de> wrote:
>>
>> Hi Tim,
>>
>> On 06.02.21 01:11, Tim Harvey wrote:
>>> Add initial support for Gateworks Venice product family based on the
>>> i.MX 8M Mini SoC
>>>
>>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>>> ---
>>
>> [snip]
>>
>>> diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
>>> index c455f7b..7117650 100644
>>> --- a/arch/arm/mach-imx/imx8m/Kconfig
>>> +++ b/arch/arm/mach-imx/imx8m/Kconfig
>>> @@ -43,7 +43,13 @@ config TARGET_IMX8MM_EVK
>>>        select SUPPORT_SPL
>>>        select IMX8M_LPDDR4
>>>
>>> -config TARGET_IMX8MN_DDR4_EVK
>>
>> This board is silently dropped...
>>
>>> +config TARGET_IMX8MM_VENICE
>>> +     bool "Support Gateworks Venice iMX8M Mini module"
>>> +     select IMX8MM
>>> +     select SUPPORT_SPL
>>> +     select IMX8M_LPDDR4
>>> +
>>
>> This is your board, ok
>>
>>> +config TARGET_IMX8MN_EVK
>>
>> and this is the old board with wrong name. Somethin went wrong....
>>
> 
> Stefano,
> 
> Oops... looks like I lost that in a rebase.
> 
> Does everything else look good or should I wait for further review
> before sending a v3?

IMHO was ok, and I have already applied 1/4 and 2/4. Just resend the 
last two patches.

Thanks,
Stefano

> 
> Thanks,
> 
> Tim
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      reply	other threads:[~2021-03-02  8:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06  0:11 [PATCH v2 0/4] Add Gateworks Venice board support Tim Harvey
2021-02-06  0:11 ` [PATCH v2 1/4] thermal: imx_tmu: enable monitoring and default alert/critical Tim Harvey
2021-03-01 11:55   ` sbabic at denx.de
2021-02-06  0:11 ` [PATCH v2 2/4] Respect that some compression algos can be enabled separately for SPL Tim Harvey
2021-03-01 11:56   ` sbabic at denx.de
2021-02-06  0:11 ` [PATCH v2 3/4] arm: dts: imx8mm: add Gateworks i.MX8 Mini Dev kits Tim Harvey
2021-02-06  0:11 ` [PATCH v2 4/4] board: gateworks: imx8mm: Add Gateworks Venice board support Tim Harvey
2021-03-01 16:04   ` Stefano Babic
2021-03-01 22:18     ` Tim Harvey
2021-03-02  8:14       ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=619cce29-8b0c-9a35-a2b3-58651bd878e7@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.