From: Martin Sperl <kernel@martin.sperl.org>
To: Matthias Reichl <hias@horus.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dmaengine_pcm: Add support for packed transfers
Date: Wed, 27 Apr 2016 16:33:12 +0200 [thread overview]
Message-ID: <61FCB16D-76ED-4862-8D39-A4ACCDBA0038@martin.sperl.org> (raw)
In-Reply-To: <1461763613-28714-1-git-send-email-hias@horus.com>
> On 27.04.2016, at 15:26, Matthias Reichl <hias@horus.com> wrote:
>
> dmaengine_pcm currently only supports setups where FIFO reads/writes
> correspond to exactly one sample, eg 16-bit sample data is transferred
> via 16-bit FIFO accesses, 32-bit data via 32-bit accesses.
>
> This patch adds support for setups with fixed width FIFOs where
> multiple samples are packed into a larger word.
>
> For example setups with a 32-bit wide FIFO register that expect
> 16-bit sample transfers to be done with the left+right sample data
> packed into a 32-bit word.
>
> Support for packed transfers is controlled via the
> SND_DMAENGINE_PCM_DAI_FLAG_PACK flag in snd_dmaengine_dai_dma_data.flags
>
> If this flag is set dmaengine_pcm doesn't put any restriction on the
> supported formats and sets the DMA transfer width to undefined.
>
> This means control over the constraints is now transferred to the DAI
> driver and it's responsible to provide proper configuration and
> check for possible corner cases that aren't handled by the ALSA core.
>
> Signed-off-by: Matthias Reichl <hias@horus.com>
Tested-by: Martin Sperl <kernel@martin.sperl.org>
next prev parent reply other threads:[~2016-04-27 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 13:26 [PATCH 1/2] ASoC: dmaengine_pcm: Add support for packed transfers Matthias Reichl
2016-04-27 13:26 ` [PATCH 2/2] ASoC: bcm2835: Add S16_LE support via packed DMA transfers Matthias Reichl
2016-04-27 13:26 ` Matthias Reichl
2016-04-27 14:33 ` Martin Sperl
2016-04-27 14:33 ` Martin Sperl
2016-04-27 16:36 ` Applied "ASoC: bcm2835: Add S16_LE support via packed DMA transfers" to the asoc tree Mark Brown
2016-04-27 16:36 ` Mark Brown
2016-04-27 16:36 ` Mark Brown
2016-04-27 18:54 ` [PATCH 2/2] ASoC: bcm2835: Add S16_LE support via packed DMA transfers Eric Anholt
2016-04-27 18:54 ` Eric Anholt
2016-04-27 14:14 ` [PATCH 1/2] ASoC: dmaengine_pcm: Add support for packed transfers Lars-Peter Clausen
2016-04-27 14:33 ` Martin Sperl [this message]
2016-04-27 16:34 ` Applied "ASoC: dmaengine_pcm: Add support for packed transfers" to the asoc tree Mark Brown
2016-04-27 16:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61FCB16D-76ED-4862-8D39-A4ACCDBA0038@martin.sperl.org \
--to=kernel@martin.sperl.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hias@horus.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.