From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81495C433E9 for ; Wed, 27 Jan 2021 11:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3343220754 for ; Wed, 27 Jan 2021 11:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236558AbhA0LWM (ORCPT ); Wed, 27 Jan 2021 06:22:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53640 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235298AbhA0KhW (ORCPT ); Wed, 27 Jan 2021 05:37:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611743755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GvvpdQmaoclN7F+XWBVjYRaUXCYn0Re2cC+2fW1RDDc=; b=W5j5qDxp9dBmMlwIixsbGARm3UIz1Nupk/FHQ5U7w4XmvRSbaNtcm0XOFih7vULX4U9yN3 MgT14eRhmqS2QliD1wVMja8z7gt6zShRO4PEeV9mtqyvD9HluxVhbJQ1B8JM8aFS4WGXLL uJKp9PMgo7VaMJBEV3T6QD02aFsSYLA= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-31Cfy8XTP7Wy1ZpyA5_j8Q-1; Wed, 27 Jan 2021 05:35:53 -0500 X-MC-Unique: 31Cfy8XTP7Wy1ZpyA5_j8Q-1 Received: by mail-ej1-f69.google.com with SMTP id dc21so483109ejb.19 for ; Wed, 27 Jan 2021 02:35:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GvvpdQmaoclN7F+XWBVjYRaUXCYn0Re2cC+2fW1RDDc=; b=khG91G5/BCFXMY7zzlyO+LkxvH7WauGYBneta256RVOzkIoarQWlllb5vrxApbpUPs Meww300fb+NiCvbUD0wtA/+F4lIAo3jTRkxl96aZF43Z2QcpNX1rvC4SBSyLXaHGTEWl 37jXxSNUAKeUiGn6dZq4dDWg4zgMJNf2OvhYfM5vdtgibkbpzkDuzRwCifSg5st6uf2G 4go8yijWkSJR0J/303aCDbGoeh28OP+HwFL5K5yN7oGaOWHSaeANSc8F+XezFesUmqFP AWaPdGcZ5CJEYZ/TddPGyTwkyDEzvEJwxxj584QEuP5eCMUwqMSX/3w42oFP++Nkcs+W J5jQ== X-Gm-Message-State: AOAM5303RceaCqGJ/Qum8873wiYbrokbh3UAAOSBkfy0s5TgmEeU4h97 dLKuy5wMpppNb13ozDkKIeRx8cfs0LLg42akAwo9pPGld1Xu2A6cF/MO677V3gXvlpX+6AhAF7r ugL50QQmCiq21tMA3Yfs19C2W X-Received: by 2002:a17:906:3a13:: with SMTP id z19mr6631473eje.317.1611743752534; Wed, 27 Jan 2021 02:35:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxS1LrXNx8IVq/PgQG53ZnNilYUBzQFa0IO7CuM218q0UU+ykV2WmllqhqyX7yM4HPt/WfXQQ== X-Received: by 2002:a17:906:3a13:: with SMTP id z19mr6631454eje.317.1611743752316; Wed, 27 Jan 2021 02:35:52 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id s2sm1019933edx.77.2021.01.27.02.35.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jan 2021 02:35:51 -0800 (PST) Subject: Re: Thoughts on sharing KVM tracepoints [was:Re: [PATCH 2/2] KVM: nVMX: trace nested vm entry] To: Sean Christopherson , Maxim Levitsky Cc: kvm@vger.kernel.org, Borislav Petkov , x86@kernel.org, Wanpeng Li , linux-kernel@vger.kernel.org, Jim Mattson , Thomas Gleixner , Ingo Molnar , Vitaly Kuznetsov , "H. Peter Anvin" , Joerg Roedel References: <20210121171043.946761-1-mlevitsk@redhat.com> <20210121171043.946761-3-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <61a387ca-ef02-2ba0-e48e-f25f7e62e6cf@redhat.com> Date: Wed, 27 Jan 2021 11:35:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/21 22:01, Sean Christopherson wrote: > I 100% think that VMX and SVM should share the bulk of the > code. Improvements to VMX almost always apply in some way to SVM, and vice > versa. I agree. > IMO, after debugging a few times, associating > error_code with the event being injected is second nature. Prepending > intr_info_ would just add extra characters and slow down mental processing. > >> of course both it and intr_info are VMX specific). > > Not really, SVM has the exact same fields with slightly different names. > I slightly prefer the SVM names, using eventinj and eventinjerr in the trace points wouldn't be bad. Having too many tracepoints are a problem. Having a lot of info in a single tracepoint is not a problem, though. Paolo