Re: [RESEND] cxl: Force psl data-cache flush during device shutdown

From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,
	frederic.barrat@fr.ibm.com, Ian Munsie <ianmunsi@au1.ibm.com>,
	Gregory Kurz <KURZGREG@fr.ibm.com>,
	Christophe Lombard <christophe_lombard@fr.ibm.com>
Subject: Re: [RESEND] cxl: Force psl data-cache flush during device shutdown
Date: Wed, 4 Jan 2017 17:43:58 +1100	[thread overview]
Message-ID: <61ab934e-12ba-2401-581e-1a2d17f5f9e2@au1.ibm.com> (raw)
In-Reply-To: <20170104061852.18512-1-vaibhav@linux.vnet.ibm.com>

On 04/01/17 17:18, Vaibhav Jain wrote:
> This change adds a force psl data cache flush during device shutdown
> callback. This should reduce a possibility of psl holding a dirty
> cache line while the CAPP is being reinitialized, which may result in
> a UE [load/store] machine check error.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>

Should this be cc: stable? (it does depend on aaa2245ed836 which only 
came in during 4.9)

Looks good.

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

> ---
> Resend: Fixed the author ident.
> ---
>  drivers/misc/cxl/pci.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index 80a87ab..73432e7 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -1610,6 +1610,9 @@ static void cxl_pci_remove_adapter(struct cxl *adapter)
>  	cxl_sysfs_adapter_remove(adapter);
>  	cxl_debugfs_adapter_remove(adapter);
>
> +	/* Flush adapter datacache as its about to be removed */
> +	cxl_data_cache_flush(adapter);
> +
>  	cxl_deconfigure_adapter(adapter);
>
>  	device_unregister(&adapter->dev);
>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited