From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Monnet Subject: [RFC bpf-next v2 8/8] bpf: add documentation for eBPF helpers (58-64) Date: Wed, 11 Apr 2018 16:45:50 +0100 Message-ID: <61abf6b0-854d-af3c-c2a3-b356f54ab84c@netronome.com> References: <20180410144157.4831-1-quentin.monnet@netronome.com> <20180410144157.4831-9-quentin.monnet@netronome.com> <20180411121759.4191e267@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, linux-doc@vger.kernel.org, linux-man@vger.kernel.org, John Fastabend To: Jesper Dangaard Brouer Return-path: Received: from mail-wm0-f50.google.com ([74.125.82.50]:39720 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbeDKPpx (ORCPT ); Wed, 11 Apr 2018 11:45:53 -0400 Received: by mail-wm0-f50.google.com with SMTP id b21so4659689wme.4 for ; Wed, 11 Apr 2018 08:45:53 -0700 (PDT) In-Reply-To: <20180411121759.4191e267@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: 2018-04-11 12:17 UTC+0200 ~ Jesper Dangaard Brouer > On Tue, 10 Apr 2018 15:41:57 +0100 > Quentin Monnet wrote: > >> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >> index 7343af4196c8..db090ad03626 100644 >> --- a/include/uapi/linux/bpf.h >> +++ b/include/uapi/linux/bpf.h >> @@ -1250,6 +1250,51 @@ union bpf_attr { >> * Return >> * 0 on success, or a negative error in case of failure. >> * >> + * int bpf_redirect_map(struct bpf_map *map, u32 key, u64 flags) >> + * Description >> + * Redirect the packet to the endpoint referenced by *map* at >> + * index *key*. Depending on its type, his *map* can contain >> + * references to net devices (for forwarding packets through other >> + * ports), or to CPUs (for redirecting XDP frames to another CPU; >> + * but this is not fully implemented as of this writing). > > Stating that CPUMAP redirect "is not fully implemented" is confusing. > The issue is that CPUMAP only works for "native" XDP. > > What about saying: > > "[...] or to CPUs (for redirecting XDP frames to another CPU; > but this is only implemented for native XDP as of this writing)" > Fine by me, I will change it. Thank you Jesper for the review! Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.6 required=5.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id DBF247DE78 for ; Wed, 11 Apr 2018 15:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbeDKPpz (ORCPT ); Wed, 11 Apr 2018 11:45:55 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38664 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753294AbeDKPpx (ORCPT ); Wed, 11 Apr 2018 11:45:53 -0400 Received: by mail-wm0-f47.google.com with SMTP id i3so4617644wmf.3 for ; Wed, 11 Apr 2018 08:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jg9fIRYIQUsgat4MdIS20JgzZJW8jnPjMLThjZrxmqI=; b=BIdRjKzXtZI9ZHzz5qRREkLxGjtGG5Pz743TiQ99LQhNs5mUb5V5ZTLKazbmSGqwMu OlOr3i1ICYuaa16KV/1IXCjjiLpmIZYVhaUTWcdtbrG7JNgPc53iJlJCxFZhZiOwcvVr jf24o+1yzec+Grczm1Y1DFBi9bwJBiD3aVVrVsfg/FsY93KfrArw4RFw2iJ4Q2tYBSHj Ey3GAlQbCzPm3z6ObtZqpdAT8vEOpG8eK+SMrv/4qNomA9UYXE+ONzsf/b9pAQCjIb27 m4yMXKCr+C1nC7AdW5clCo3N6SiTUujwtm+Lk5Yf+ss84hWGwsjafohcTrF0RPHNcdMw QeZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Jg9fIRYIQUsgat4MdIS20JgzZJW8jnPjMLThjZrxmqI=; b=ipKhSkP+KiuVPX7UEEOASTo56S8ULaobrzFMWKIddoAW5EC3ZRyu0dWc4NEVrpdm36 6i90lSxqvqeiDwl3ukEu8JIJAwUDVV5j2+D3RjYe4tKBQmdidk7ENk2svBhsALU1dxSF e19hRIa8JhnArSPd+QdJBRfc6mh4AFW1zwTMuFkPHACAzXjNkhahpIgpsU/kwoFGCXJH zPs+tTJjy0H1kd+c81YxKmDWhHa24MHCeIVLGO5GFdnv4rxoO4G/fUltYRSsIfNWxs6l 2ipHkYfdh2TZHHROq5ZHSASqeQ9bizKJtfZyVc+O68S214tEQT12W506ENEIlobnxilh OAww== X-Gm-Message-State: ALQs6tAwGaWuRjcqaJLJDIlQY5Iwc+jY5PHaVP3WbpyBK+1qQBzPJSoW p3YNZ5cbaBhYscMTy73vCUZwIg== X-Google-Smtp-Source: AIpwx49gFA0+nLIsMbXNIiFSMLlZGWkFdNdwrSQ8DOU+xovGq9HDpYT8y1lH2U9iQFA+KV+wqWKq/A== X-Received: by 10.80.234.205 with SMTP id u13mr10368032edp.288.1523461552413; Wed, 11 Apr 2018 08:45:52 -0700 (PDT) Received: from [172.20.1.93] (host-79-78-33-110.static.as9105.net. [79.78.33.110]) by smtp.gmail.com with ESMTPSA id p5sm922860edh.7.2018.04.11.08.45.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Apr 2018 08:45:51 -0700 (PDT) From: Quentin Monnet Subject: [RFC bpf-next v2 8/8] bpf: add documentation for eBPF helpers (58-64) To: Jesper Dangaard Brouer Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, linux-doc@vger.kernel.org, linux-man@vger.kernel.org, John Fastabend References: <20180410144157.4831-1-quentin.monnet@netronome.com> <20180410144157.4831-9-quentin.monnet@netronome.com> <20180411121759.4191e267@redhat.com> Openpgp: preference=signencrypt Autocrypt: addr=quentin.monnet@netronome.com; prefer-encrypt=mutual; keydata= xsFNBFnqRlsBEADfkCdH/bkkfjbglpUeGssNbYr/TD4aopXiDZ0dL2EwafFImsGOWmCIIva2 MofTQHQ0tFbwY3Ir74exzU9X0aUqrtHirQHLkKeMwExgDxJYysYsZGfM5WfW7j8X4aVwYtfs AVRXxAOy6/bw1Mccq8ZMTYKhdCgS3BfC7qK+VYC4bhM2AOWxSQWlH5WKQaRbqGOVLyq8Jlxk 2FGLThUsPRlXKz4nl+GabKCX6x3rioSuNoHoWdoPDKsRgYGbP9LKRRQy3ZeJha4x+apy8rAM jcGHppIrciyfH38+LdV1FVi6sCx8sRKX++ypQc3fa6O7d7mKLr6uy16xS9U7zauLu1FYLy2U N/F1c4F+bOlPMndxEzNc/XqMOM9JZu1XLluqbi2C6JWGy0IYfoyirddKpwzEtKIwiDBI08JJ Cv4jtTWKeX8pjTmstay0yWbe0sTINPh+iDw+ybMwgXhr4A/jZ1wcKmPCFOpb7U3JYC+ysD6m 6+O/eOs21wVag/LnnMuOKHZa2oNsi6Zl0Cs6C7Vve87jtj+3xgeZ8NLvYyWrQhIHRu1tUeuf T8qdexDphTguMGJbA8iOrncHXjpxWhMWykIyN4TYrNwnyhqP9UgqRPLwJt5qB1FVfjfAlaPV sfsxuOEwvuIt19B/3pAP0nbevNymR3QpMPRl4m3zXCy+KPaSSQARAQABzS1RdWVudGluIE1v bm5ldCA8cXVlbnRpbi5tb25uZXRAbmV0cm9ub21lLmNvbT7CwX0EEwEIACcFAlnqRlsCGyMF CQlmAYAFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQNvcEyYwwfB7tChAAqFWG30+DG3Sx B7lfPaqs47oW98s5tTMprA+0QMqUX2lzHX7xWb5v8qCpuujdiII6RU0ZhwNKh/SMJ7rbYlxK qCOw54kMI+IU7UtWCej+Ps3LKyG54L5HkBpbdM8BLJJXZvnMqfNWx9tMISHkd/LwogvCMZrP TAFkPf286tZCIz0EtGY/v6YANpEXXrCzboWEiIccXRmbgBF4VK/frSveuS7OHKCu66VVbK7h kyTgBsbfyQi7R0Z6w6sgy+boe7E71DmCnBn57py5OocViHEXRgO/SR7uUK3lZZ5zy3+rWpX5 nCCo0C1qZFxp65TWU6s8Xt0Jq+Fs7Kg/drI7b5/Z+TqJiZVrTfwTflqPRmiuJ8lPd+dvuflY JH0ftAWmN3sT7cTYH54+HBIo1vm5UDvKWatTNBmkwPh6d3cZGALZvwL6lo0KQHXZhCVdljdQ rwWdE25aCQkhKyaCFFuxr3moFR0KKLQxNykrVTJIRuBS8sCyxvWcZYB8tA5gQ/DqNKBdDrT8 F9z2QvNE5LGhWDGddEU4nynm2bZXHYVs2uZfbdZpSY31cwVS/Arz13Dq+McMdeqC9J2wVcyL DJPLwAg18Dr5bwA8SXgILp0QcYWtdTVPl+0s82h+ckfYPOmkOLMgRmkbtqPhAD95vRD7wMnm ilTVmCi6+ND98YblbzL64YHOwU0EWepGWwEQAM45/7CeXSDAnk5UMXPVqIxF8yCRzVe+UE0R QQsdNwBIVdpXvLxkVwmeu1I4aVvNt3Hp2eiZJjVndIzKtVEoyi5nMvgwMVs8ZKCgWuwYwBzU Vs9eKABnT0WilzH3gA5t9LuumekaZS7z8IfeBlZkGXEiaugnSAESkytBvHRRlQ8b1qnXha3g XtxyEqobKO2+dI0hq0CyUnGXT40Pe2woVPm50qD4HYZKzF5ltkl/PgRNHo4gfGq9D7dW2OlL 5I9qp+zNYj1G1e/ytPWuFzYJVT30MvaKwaNdurBiLc9VlWXbp53R95elThbrhEfUqWbAZH7b ALWfAotD07AN1msGFCES7Zes2AfAHESI8UhVPfJcwLPlz/Rz7/K6zj5U6WvH6aj4OddQFvN/ icvzlXna5HljDZ+kRkVtn+9zrTMEmgay8SDtWliyR8i7fvnHTLny5tRnE5lMNPRxO7wBwIWX TVCoBnnI62tnFdTDnZ6C3rOxVF6FxUJUAcn+cImb7Vs7M5uv8GufnXNUlsvsNS6kFTO8eOjh 4fe5IYLzvX9uHeYkkjCNVeUH5NUsk4NGOhAeCS6gkLRA/3u507UqCPFvVXJYLSjifnr92irt 0hXm89Ms5fyYeXppnO3l+UMKLkFUTu6T1BrDbZSiHXQoqrvU9b1mWF0CBM6aAYFGeDdIVe4x ABEBAAHCwWUEGAEIAA8FAlnqRlsCGwwFCQlmAYAACgkQNvcEyYwwfB4QwhAAqBTOgI9k8MoM gVA9SZj92vYet9gWOVa2Inj/HEjz37tztnywYVKRCRfCTG5VNRv1LOiCP1kIl/+crVHm8g78 iYc5GgBKj9O9RvDm43NTDrH2uzz3n66SRJhXOHgcvaNE5ViOMABU+/pzlg34L/m4LA8SfwUG ducP39DPbF4J0OqpDmmAWNYyHh/aWf/hRBFkyM2VuizN9cOS641jrhTO/HlfTlYjIb4Ccu9Y S24xLj3kkhbFVnOUZh8celJ31T9GwCK69DXNwlDZdri4Bh0N8DtRfrhkHj9JRBAun5mdwF4m yLTMSs4Jwa7MaIwwb1h3d75Ws7oAmv7y0+RgZXbAk2XN32VM7emkKoPgOx6Q5o8giPRX8mpc PiYojrO4B4vaeKAmsmVer/Sb5y9EoD7+D7WygJu2bDrqOm7U7vOQybzZPBLqXYxl/F5vOobC 5rQZgudR5bI8uQM0DpYb+Pwk3bMEUZQ4t497aq2vyMLRi483eqT0eG1QBE4O8dFNYdK5XUIz oHhplrRgXwPBSOkMMlLKu+FJsmYVFeLAJ81sfmFuTTliRb3Fl2Q27cEr7kNKlsz/t6vLSEN2 j8x+tWD8x53SEOSn94g2AyJA9Txh2xBhWGuZ9CpBuXjtPrnRSd8xdrw36AL53goTt/NiLHUd RHhSHGnKaQ6MfrTge5Q0h5A= Message-ID: <61abf6b0-854d-af3c-c2a3-b356f54ab84c@netronome.com> Date: Wed, 11 Apr 2018 16:45:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180411121759.4191e267@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org 2018-04-11 12:17 UTC+0200 ~ Jesper Dangaard Brouer > On Tue, 10 Apr 2018 15:41:57 +0100 > Quentin Monnet wrote: > >> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >> index 7343af4196c8..db090ad03626 100644 >> --- a/include/uapi/linux/bpf.h >> +++ b/include/uapi/linux/bpf.h >> @@ -1250,6 +1250,51 @@ union bpf_attr { >> * Return >> * 0 on success, or a negative error in case of failure. >> * >> + * int bpf_redirect_map(struct bpf_map *map, u32 key, u64 flags) >> + * Description >> + * Redirect the packet to the endpoint referenced by *map* at >> + * index *key*. Depending on its type, his *map* can contain >> + * references to net devices (for forwarding packets through other >> + * ports), or to CPUs (for redirecting XDP frames to another CPU; >> + * but this is not fully implemented as of this writing). > > Stating that CPUMAP redirect "is not fully implemented" is confusing. > The issue is that CPUMAP only works for "native" XDP. > > What about saying: > > "[...] or to CPUs (for redirecting XDP frames to another CPU; > but this is only implemented for native XDP as of this writing)" > Fine by me, I will change it. Thank you Jesper for the review! Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html