Re: [PATCH v2 3/3] add SPDX to arch/arm/*.c

[Julien Grall <julien@xen.org>]

Hi Stefano,

On 18/08/2022 23:03, Stefano Stabellini wrote:
> Add SPDX license information to all the *.c files under arch/arm.

There are some of the files below that didn't have copyright. It would 
be worth explaining in the commit message which license you selected and 
how. AFAICT you assumed they were GPLv2 but I am not sure this is 
correct at least one of them.

[...]

> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> index f5f6562600..2537dbebc1 100644
> --- a/xen/arch/arm/decode.c
> +++ b/xen/arch/arm/decode.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */

This license is not part of LICENSES. Was it intended?

If yes, this should be mentioned in one of the commit message (possible 
patch #2) and maybe in CONTRIBUTING (to tell user to not use it for new 
files) because one could expect all the LICENSES to be listed.

>   /*
>    * xen/arch/arm/decode.c
>    *
> @@ -5,16 +6,6 @@
>    *
>    * Julien Grall <julien.grall@linaro.org>
>    * Copyright (C) 2013 Linaro Limited.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
>    */
>   
>   #include <xen/guest_access.h>

[...]

> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 3fd1186b53..b29bdf3aa6 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

AFAIU, the assumption is all the files with no copyright are GPLv2. That 
works here. But ...

>   #include <xen/init.h>
>   #include <xen/compile.h>
>   #include <xen/lib.h>
> diff --git a/xen/arch/arm/domain_page.c b/xen/arch/arm/domain_page.c
> index 71182575f9..47405e0866 100644
> --- a/xen/arch/arm/domain_page.c
> +++ b/xen/arch/arm/domain_page.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

.... this file was split from mm.c which is gpl-2.0-or-later. So I don't 
think we can use GPL-2.0 here.

>   #include <xen/mm.h>
>   #include <xen/pmap.h>
>   #include <xen/vmap.h>

Cheers,

-- 
Julien Grall