Re: [PATCH v8 1/4] app/testpmd: add isolated mode parameter

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 7/5/2017 4:18 PM, Ferruh Yigit wrote:
> On 7/5/2017 9:14 AM, Vasily Philipov wrote:
>> Providing this parameter requests flow API isolated mode on all ports at
>> initialization time. It ensures all traffic is received through the
>> configured flow rules only (see flow command).
>>
>> Ports that do not support this mode are automatically discarded.
>>
>> Signed-off-by: Vasily Philipov <vasilyf@mellanox.com>
>> ---
>>  app/test-pmd/parameters.c |  3 +++
>>  app/test-pmd/testpmd.c    | 14 ++++++++++++++
>>  app/test-pmd/testpmd.h    |  1 +
>>  3 files changed, 18 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index fbe6284..e313871 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -623,6 +623,7 @@
>>  		{ "tx-queue-stats-mapping",	1, 0, 0 },
>>  		{ "rx-queue-stats-mapping",	1, 0, 0 },
>>  		{ "no-flush-rx",	0, 0, 0 },
>> +		{ "isolated-mode",	        0, 0, 0 },
> 
> Can you please document the new option [1] ?
> 
> And when you don't know nothing about isolated-mode, this option is not
> specific enough. What do you think adding a "flow" or similar keyword to
> the option?
> 
> [1]
> doc/guides/testpmd_app_ug/run_app.rst

Overall this testpmd patch seems can be seperated from patchset.

I will check other driver patches in the patchset, can you please send
new version of this patch as a standalone patch?

Thanks,
ferruh