From: Shuah Khan <skhan@linuxfoundation.org>
To: Anders Roxell <anders.roxell@linaro.org>,
shuah@kernel.org, christian@brauner.io
Cc: nathan@kernel.org, ndesaulniers@google.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Arnd Bergmann <arnd@arndb.de>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/2] selftests: cgroup: build error multiple outpt files
Date: Fri, 19 Nov 2021 17:22:20 -0700 [thread overview]
Message-ID: <61b21c4b-fc26-5e41-3aed-22a7e56b04ba@linuxfoundation.org> (raw)
In-Reply-To: <20211105162530.3307666-1-anders.roxell@linaro.org>
On 11/5/21 10:25 AM, Anders Roxell wrote:
> When building selftests/cgroup: with clang the following error are seen:
>
> clang -Wall -pthread test_memcontrol.c cgroup_util.c ../clone3/clone3_selftests.h -o /home/anders/.cache/tuxmake/builds/current/kselftest/cgroup/test_memcontrol
> clang: error: cannot specify -o when generating multiple output files
> make[3]: *** [../lib.mk:146: /home/anders/.cache/tuxmake/builds/current/kselftest/cgroup/test_memcontrol] Error 1
>
> Rework to add the header files to LOCAL_HDRS before including ../lib.mk,
> since the dependency is evaluated in '$(OUTPUT)/%:%.c $(LOCAL_HDRS)' in
> file lib.mk.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> tools/testing/selftests/cgroup/Makefile | 12 +++++++-----
> tools/testing/selftests/lib.mk | 2 +-
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/cgroup/Makefile b/tools/testing/selftests/cgroup/Makefile
> index 59e222460581..745fe25fa0b9 100644
> --- a/tools/testing/selftests/cgroup/Makefile
> +++ b/tools/testing/selftests/cgroup/Makefile
> @@ -11,10 +11,12 @@ TEST_GEN_PROGS += test_core
> TEST_GEN_PROGS += test_freezer
> TEST_GEN_PROGS += test_kill
>
> +LOCAL_HDRS += $(selfdir)/clone3/clone3_selftests.h $(selfdir)/pidfd/pidfd.h
> +
This looks odd to me. Why are we introducing dependencies between tests?
clone3 includes in cgroup? Looks odd to me.
thanks,
-- Shuah
next prev parent reply other threads:[~2021-11-20 0:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 16:25 [PATCH 1/2] selftests: cgroup: build error multiple outpt files Anders Roxell
2021-11-05 16:25 ` [PATCH 2/2] selftests: cgroup: use function 'labs()' over 'abs()' Anders Roxell
2021-11-05 20:15 ` Nick Desaulniers
2021-11-09 15:02 ` Christian Brauner
2021-11-05 20:10 ` [PATCH 1/2] selftests: cgroup: build error multiple outpt files Nick Desaulniers
2021-11-09 15:01 ` Christian Brauner
2021-11-20 0:22 ` Shuah Khan [this message]
2021-11-23 14:26 ` Christian Brauner
2021-11-30 16:41 ` Shuah Khan
2021-12-01 13:06 ` Christian Brauner
2021-12-03 17:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61b21c4b-fc26-5e41-3aed-22a7e56b04ba@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.