Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

["Changqing Li" <changqing.li@windriver.com>]

On 6/30/20 6:01 PM, Richard Purdie wrote:
> On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> fix error:
>> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
>> /var/tmp/rpm-tmp.mdYxY6: line 12: /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
>> query-loaders: No such file or directory
>> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961
>> status 7f00
>> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
>> failed, exit status 127
>>
>> when install adwaita-icon-theme, which inherit gtk-icon-cache
>> on target, above error reported,  fix by add needeed packages
>> in RDEPENDS
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>>   meta/classes/gtk-icon-cache.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-
>> icon-cache.bbclass
>> index 91cb4ad409..7f218ce7ae 100644
>> --- a/meta/classes/gtk-icon-cache.bbclass
>> +++ b/meta/classes/gtk-icon-cache.bbclass
>> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' ==
>> 'hicolor-icon-theme']} gtk
>>   
>>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>>   
>> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
>> +
>>   gtk_icon_cache_postinst() {
>>   if [ "x$D" != "x" ]; then
>>   	$INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG}
>> \
> This isn't quite right since the postinst may be added to a package
> other than ${PN}.
>
> You need to add the RDEPENDS to the code:
>
>          rdepends = ' ' + d.getVar('MLPREFIX', False) + "hicolor-icon-theme"
>          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>
> later in that class.
>
> Cheers,
>
> Richard
Thanks, I will correct it.
>