From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>,
Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: "Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
"Paul Durrant" <paul@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <iwj@xenproject.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Julien Grall" <julien.grall@arm.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu
Date: Thu, 28 Jan 2021 14:21:53 +0000 [thread overview]
Message-ID: <61c10e68-d3fe-af16-b22f-bac804a0a70a@xen.org> (raw)
In-Reply-To: <f4a4cbe6-89a1-3f80-2d03-fd62c5d7eda6@suse.com>
Hi Jan,
On 28/01/2021 13:53, Jan Beulich wrote:
> On 28.01.2021 14:41, Julien Grall wrote:
>> Hi Oleksandr,
>>
>> On 25/01/2021 19:08, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> The IOREQ is a common feature now and these fields will be used
>>> on Arm as is. Move them to common struct vcpu as a part of new
>>> struct vcpu_io and drop duplicating "io" prefixes. Also move
>>> enum hvm_io_completion to xen/sched.h and remove "hvm" prefixes.
>>>
>>> This patch completely removes layering violation in the common code.
>>>
>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> Reviewed-by: Julien Grall <jgrall@amazon.com>
>>> Reviewed-by: Paul Durrant <paul@xen.org>
>>> Acked-by: Jan Beulich <jbeulich@suse.com>
>>> CC: Julien Grall <julien.grall@arm.com>
>>> [On Arm only]
>>> Tested-by: Wei Chen <Wei.Chen@arm.com>
>>
>> I seem to have trouble running Xen on x86 platform after this patch is
>> applied (see trace below).
>>
>> The bisector pointed out to this patch but I can't quite figure out why
>> this is breaking.
>>
>> Does this ring any bell to someone?
>
> Memory overwriting / corruption? This ...
>
>> (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input)
>> (XEN) ----[ Xen-4.15-unstable x86_64 debug=n gcov=y Tainted: C ]----
>> (XEN) CPU: 1
>> (XEN) RIP: e008:[<ffff82d04041c1c7>]
>> x86_64/entry.S#restore_all_guest+0x7/0x145
>> (XEN) RFLAGS: 0000000000010002 CONTEXT: hypervisor (d0v0)
>> (XEN) rax: 00000000000000ff rbx: ffff83027c806000 rcx: ffff82d0406c9a80
>> (XEN) rdx: 0000000000000000 rsi: fffffffffffffed9 rdi: 0000000000000001
>> (XEN) rbp: ffff83027c887df0 rsp: ffff83027c887ef8 r8: 00000000aaa8946e
>> (XEN) r9: 0000000000000002 r10: ffff83027c806040 r11: ffff83027c8cc020
>> (XEN) r12: ffff83027c80f000 r13: ffff83027c895000 r14: 0000000000000000
>> (XEN) r15: 0000000000000000 cr0: 0000000080050033 cr4: 00000000003426e0
>> (XEN) cr3: 0000000273a2d000 cr2: 0000000000000000
>> (XEN) fsb: 0000000000000000 gsb: 0000000000000000 gss: 0000000000000000
>> (XEN) ds: 0000 es: 0000 fs: 0000 gs: 0000 ss: 0000 cs: e008
>> (XEN) Xen code around <ffff82d04041c1c7>
>> (x86_64/entry.S#restore_all_guest+0x7/0x145):
>> (XEN) 00 48 8b 93 98 0d 00 00 <44> 8b 3a 4c 8b 8b 68 0b 00 00 ba ff 7f
>
> ... is
>
> restore_all_guest:
> ASSERT_INTERRUPTS_DISABLED
>
> /* Stash guest SPEC_CTRL value while we can read struct vcpu. */
> mov VCPU_arch_msrs(%rbx), %rdx
> mov VCPUMSR_spec_ctrl_raw(%rdx), %r15d
>
> i.e. Dom0/vCPU0's v->arch.msrs got zeroed in an unintended way,
> hence %rdx is zero here (%rbx looks at least plausible).
>
> I take it that you double check this isn't an incremental build
> issue, i.e. entry.o for some reason not having got rebuilt
> despite struct vcpu's layout having changed?
I was going to reply back on my e-mail with more debugging information.
It seems that this is a build issue as if I clean the repo the error
disappear.
The error happens when I move from staging to a batch with this series
applied without a cleaning the tree. It also happens the other way
around as well.
Removing entry.o or asm-offsets.h before building doesn't help. Any
other idea?
On a side note, it looks like asm-offsets.h doesn't get rebuild when
Kconfig change. I noticed an issue when trying to turn on the perf counters.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-01-28 14:22 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 19:08 [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 01/22] x86/ioreq: Prepare IOREQ feature for making it common Oleksandr Tyshchenko
2021-01-27 16:48 ` Jan Beulich
2021-01-25 19:08 ` [PATCH V5 02/22] x86/ioreq: Add IOREQ_STATUS_* #define-s and update code for moving Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 03/22] x86/ioreq: Provide out-of-line wrapper for the handle_mmio() Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common Oleksandr Tyshchenko
2021-01-25 23:13 ` Julien Grall
2021-01-25 23:40 ` Oleksandr
2021-01-27 18:43 ` Julien Grall
2021-01-27 20:22 ` Oleksandr
2021-01-27 20:46 ` Stefano Stabellini
2021-01-28 11:01 ` Oleksandr
2021-01-28 11:21 ` Jan Beulich
2021-01-28 12:49 ` Oleksandr
2021-01-28 17:13 ` Stefano Stabellini
2021-01-27 16:58 ` Jan Beulich
2021-01-27 20:14 ` Oleksandr
2021-01-28 8:06 ` Jan Beulich
2021-01-28 11:16 ` Oleksandr
2021-01-28 11:24 ` Jan Beulich
2021-01-25 19:08 ` [PATCH V5 05/22] xen/ioreq: Make x86's hvm_ioreq_needs_completion() common Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 06/22] xen/ioreq: Make x86's hvm_mmio_first(last)_byte() common Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 07/22] xen/ioreq: Make x86's hvm_ioreq_(page/vcpu/server) structs common Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 08/22] xen/ioreq: Move x86's ioreq_server to struct domain Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 09/22] xen/ioreq: Make x86's IOREQ related dm-op handling common Oleksandr Tyshchenko
2021-01-26 13:31 ` Paul Durrant
2021-01-28 10:52 ` Jan Beulich
2021-01-28 12:06 ` Oleksandr
2021-01-28 13:18 ` Jan Beulich
2021-01-28 20:01 ` Oleksandr
2021-01-25 19:08 ` [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu Oleksandr Tyshchenko
2021-01-28 13:41 ` Julien Grall
2021-01-28 13:53 ` Jan Beulich
2021-01-28 14:21 ` Julien Grall [this message]
2021-01-28 14:36 ` Jan Beulich
2021-01-28 14:49 ` Andrew Cooper
2021-01-28 14:51 ` Ian Jackson
2021-01-28 14:54 ` Jan Beulich
2021-01-28 16:15 ` Andrew Cooper
2021-01-28 15:01 ` Julien Grall
2021-01-28 14:05 ` Oleksandr
2021-01-25 19:08 ` [PATCH V5 11/22] xen/mm: Make x86's XENMEM_resource_ioreq_server handling common Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 12/22] xen/ioreq: Remove "hvm" prefixes from involved function names Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 13/22] xen/ioreq: Use guest_cmpxchg64() instead of cmpxchg() Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features Oleksandr Tyshchenko
2021-01-25 20:19 ` Stefano Stabellini
2021-01-26 9:15 ` Jan Beulich
2021-01-27 9:54 ` Oleksandr
2021-01-27 10:15 ` Jan Beulich
2021-01-27 17:01 ` Julien Grall
2021-01-27 17:04 ` Jan Beulich
2021-01-27 18:33 ` Julien Grall
2021-01-27 19:20 ` Oleksandr
2021-01-28 9:40 ` Julien Grall
2021-01-28 11:33 ` Oleksandr
2021-01-28 13:39 ` Oleksandr
2021-01-28 14:29 ` Oleksandr
2021-01-28 14:41 ` Julien Grall
2021-01-28 14:52 ` Oleksandr
2021-01-28 15:08 ` Julien Grall
2021-01-28 17:50 ` Oleksandr
2021-01-25 19:08 ` [PATCH V5 15/22] xen/arm: Call vcpu_ioreq_handle_completion() in check_for_vcpu_work() Oleksandr Tyshchenko
2021-01-27 14:49 ` Julien Grall
2021-01-27 15:56 ` Oleksandr
2021-01-27 20:34 ` Stefano Stabellini
2021-01-25 19:08 ` [PATCH V5 16/22] xen/mm: Handle properly reference in set_foreign_p2m_entry() on Arm Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 17/22] xen/ioreq: Introduce domain_has_ioreq_server() Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 18/22] xen/dm: Introduce xendevicemodel_set_irq_level DM op Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 19/22] xen/arm: io: Abstract sign-extension Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 20/22] xen/arm: io: Harden sign extension check Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 21/22] xen/ioreq: Make x86's send_invalidate_req() common Oleksandr Tyshchenko
2021-01-25 19:08 ` [PATCH V5 22/22] xen/arm: Add mapcache invalidation handling Oleksandr Tyshchenko
2021-01-28 9:55 ` Julien Grall
2021-01-28 13:12 ` Oleksandr
2021-01-27 16:43 ` [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm Julien Grall
2021-01-27 16:50 ` Oleksandr
2021-01-27 17:33 ` Julien Grall
2021-01-27 17:37 ` Oleksandr
2021-01-27 17:42 ` Julien Grall
2021-01-27 17:45 ` Oleksandr
2021-01-28 14:37 ` Oleksandr
2021-01-28 15:14 ` Julien Grall
2021-01-28 17:55 ` Oleksandr
2021-01-28 16:11 ` Julien Grall
2021-01-28 17:24 ` Stefano Stabellini
2021-01-28 17:44 ` Julien Grall
2021-01-28 18:10 ` Andrew Cooper
2021-01-28 18:16 ` Julien Grall
2021-01-28 18:21 ` Julien Grall
2021-01-28 20:10 ` Andrew Cooper
2021-01-28 21:19 ` Julien Grall
2021-01-28 19:44 ` Oleksandr
2021-01-29 1:15 ` Oleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c10e68-d3fe-af16-b22f-bac804a0a70a@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=olekstysh@gmail.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.