All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arturo Borrero Gonzalez <arturo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	netfilter-devel@vger.kernel.org, Jan Engelhardt <jengelh@inai.de>
Subject: Re: [conntrack-tools PATCH] Makefile.am: Use ${} instead of @...@
Date: Tue, 12 Nov 2019 11:55:20 +0100	[thread overview]
Message-ID: <61d72fd1-99c6-c536-4779-daccfe0767d4@netfilter.org> (raw)
In-Reply-To: <20191111171921.14120-1-phil@nwl.cc>

On 11/11/19 6:19 PM, Phil Sutter wrote:
> Referencing to variables using @...@ means they will be replaced by
> configure. This is not needed and may cause problems later.
> 
> Suggested-by: Jan Engelhardt <jengelh@inai.de>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
>  Makefile.am             | 2 +-
>  src/Makefile.am         | 2 +-
>  src/helpers/Makefile.am | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 

Acked-by: Arturo Borrero Gonzalez <arturo@netfilter.org>


  reply	other threads:[~2019-11-12 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 17:19 [conntrack-tools PATCH] Makefile.am: Use ${} instead of @...@ Phil Sutter
2019-11-12 10:55 ` Arturo Borrero Gonzalez [this message]
2019-11-12 21:06 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61d72fd1-99c6-c536-4779-daccfe0767d4@netfilter.org \
    --to=arturo@netfilter.org \
    --cc=jengelh@inai.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.