All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 5/9] target/mips: Restrict some system specific declarations to sysemu
Date: Sat, 19 Jun 2021 16:44:00 +0200	[thread overview]
Message-ID: <61da0ebb-d5d7-cba5-7836-3654ff162e4b@amsat.org> (raw)
In-Reply-To: <0e884ae7-321f-ce37-44f6-1790b319e7c5@linaro.org>

On 6/19/21 12:38 AM, Richard Henderson wrote:
> On 6/17/21 10:43 AM, Philippe Mathieu-Daudé wrote:
>> Commit 043715d1e0f ("target/mips: Update ITU to utilize SAARI
>> and SAAR CP0 registers") declared itc_reconfigure() in public
>> namespace, while it is restricted to system emulation.
>>
>> Similarly commit 5679479b9a1 ("target/mips: Move CP0 helpers
>> to sysemu/cp0.c") restricted cpu_mips_soft_irq() definition to
>> system emulation, but forgot to restrict its declaration.
>>
>> Commit a2b0a27d33e ("target/mips: Move TCG source files under
>> tcg/ sub directory") restricted mips_cpu_do_unaligned_access()
>> to system emulation but forgot to guard the declaration.
> 
> FWIW, I think the unaligned_access tcg_ops hook should be available for
> user-only as well, like for tlb_fill.  That it is sysemu only at the
> moment is a bug that affects user-only atomic access.

OK understood, I'll drop that hunk.

> Anyway,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks!


  reply	other threads:[~2021-06-19 14:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 17:43 [PATCH 0/9] target/mips: Various fixes & cleanups Philippe Mathieu-Daudé
2021-06-17 17:43 ` [PATCH 1/9] target/mips: Do not abort on invalid instruction Philippe Mathieu-Daudé
2021-06-18 22:30   ` Richard Henderson
2021-06-17 17:43 ` [PATCH 2/9] target/mips: Fix more TCG temporary leaks in gen_pool32a5_nanomips_insn Philippe Mathieu-Daudé
2021-06-18 22:32   ` Richard Henderson
2021-06-17 17:43 ` [PATCH 3/9] target/mips: Move TCG trace events to tcg/ sub directory Philippe Mathieu-Daudé
2021-06-18 22:32   ` Richard Henderson
2021-06-17 17:43 ` [PATCH 4/9] target/mips: Move translate.h " Philippe Mathieu-Daudé
2021-06-18 22:34   ` Richard Henderson
2021-06-17 17:43 ` [PATCH 5/9] target/mips: Restrict some system specific declarations to sysemu Philippe Mathieu-Daudé
2021-06-18 22:38   ` Richard Henderson
2021-06-19 14:44     ` Philippe Mathieu-Daudé [this message]
2021-06-17 17:43 ` [PATCH 6/9] target/mips: Remove SmartMIPS / MDMX unuseful comments Philippe Mathieu-Daudé
2021-06-18 22:39   ` Richard Henderson
2021-06-17 17:43 ` [PATCH 7/9] target/mips: Remove microMIPS BPOSGE32 / BPOSGE64 unuseful cases Philippe Mathieu-Daudé
2021-06-18  9:44   ` Philippe Mathieu-Daudé
2021-06-18 22:40   ` Richard Henderson
2021-06-17 17:43 ` [PATCH 8/9] target/mips: Constify host_to_mips_errno[] Philippe Mathieu-Daudé
2021-06-18 22:40   ` Richard Henderson
2021-06-17 17:43 ` [PATCH 9/9] target/mips: Optimize regnames[] arrays Philippe Mathieu-Daudé
2021-06-18 22:42   ` Richard Henderson
2021-06-19 18:05 ` [PATCH 0/9] target/mips: Various fixes & cleanups Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61da0ebb-d5d7-cba5-7836-3654ff162e4b@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.