On 2017-07-07 23:26, Eric Blake wrote: > On 07/07/2017 09:30 AM, Pavel Butsykin wrote: >> This patch add shrinking of the image file for qcow2. As a result, this allows >> us to reduce the virtual image size and free up space on the disk without >> copying the image. Image can be fragmented and shrink is done by punching holes >> in the image file. >> >> Signed-off-by: Pavel Butsykin >> --- >> block/qcow2-cluster.c | 40 +++++++++++++++++++ >> block/qcow2-refcount.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++ >> block/qcow2.c | 42 +++++++++++++++----- >> block/qcow2.h | 14 +++++++ >> qapi/block-core.json | 3 +- >> 5 files changed, 191 insertions(+), 11 deletions(-) >> > >> +++ b/qapi/block-core.json >> @@ -2372,7 +2372,8 @@ >> 'cluster_alloc_bytes', 'cluster_free', 'flush_to_os', >> 'flush_to_disk', 'pwritev_rmw_head', 'pwritev_rmw_after_head', >> 'pwritev_rmw_tail', 'pwritev_rmw_after_tail', 'pwritev', >> - 'pwritev_zero', 'pwritev_done', 'empty_image_prepare' ] } >> + 'pwritev_zero', 'pwritev_done', 'empty_image_prepare', >> + 'l1_shrink_write_table', 'l1_shrink_free_l2_clusters' ] } > > Missing documentation for the additions. Well, I'd say there's missing documentation for everything, so.... Max