From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68BFC4363A for ; Mon, 12 Oct 2020 14:20:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 581572076E for ; Mon, 12 Oct 2020 14:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jQHVyRve" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 581572076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRygZ-0006sy-HD for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 10:20:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRyeb-0004hd-DR for qemu-devel@nongnu.org; Mon, 12 Oct 2020 10:18:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kRyeZ-0004vv-D7 for qemu-devel@nongnu.org; Mon, 12 Oct 2020 10:18:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602512298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JJIauyB9brTLsKdjJ06jnj0MmPe3S+Ieb4fwqajJELc=; b=jQHVyRvexsB2EEqQmxmuOB+gdWM48iO4MgpMrYc5hNtmSAJ3YBi/RmF+6iJN4wYMipgxu7 BsG8LBEa4EfhZ4MjfBZlLV6d42igSPXcKQm7VImqK2nCerElz0dUWgAJ8qMK+TZvCL3+LV /Se43gJf99tdjhO91w5PceC1ZWIeUHM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-2dAzBSA-PnqMvtZuCS6aNw-1; Mon, 12 Oct 2020 10:18:15 -0400 X-MC-Unique: 2dAzBSA-PnqMvtZuCS6aNw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C773E100E433; Mon, 12 Oct 2020 14:18:03 +0000 (UTC) Received: from [10.10.117.231] (ovpn-117-231.rdu2.redhat.com [10.10.117.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A85C5C22B; Mon, 12 Oct 2020 14:17:55 +0000 (UTC) Subject: Re: [PATCH 05/10] hw/isa: Add the ISA_IRQ_FDC_DEFAULT definition To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201011193229.3210774-1-f4bug@amsat.org> <20201011193229.3210774-6-f4bug@amsat.org> From: John Snow Message-ID: <61ddbe67-612d-0a19-a04a-d0dcd083b373@redhat.com> Date: Mon, 12 Oct 2020 10:17:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201011193229.3210774-6-f4bug@amsat.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/11 23:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-ppc@nongnu.org, Thomas Huth , Eduardo Habkost , Corey Minyard , Stefan Berger , Laurent Vivier , Jason Wang , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Reitz , qemu-trivial@nongnu.org, Igor Mammedov , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Artyom Tarasenko , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini , qemu-block@nongnu.org, Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote: > The floppy disk controller uses IRQ #6 by default. Add this > default definition to the IsaIrqNumber enum. > > Avoid magic values in the code, replace them by the > newly introduced definition. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: John Snow