From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Subject: Re: Ethernet on my CycloneV broke since 4.9.124 Date: Wed, 31 Oct 2018 09:42:46 -0500 Message-ID: <61e0ddf2-a2b5-189a-06bc-ee0cd7bfd8b5@kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Return-path: Received: from mail.kernel.org ([198.145.29.99]:42184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729492AbeJaXlH (ORCPT ); Wed, 31 Oct 2018 19:41:07 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi Clement, On 10/31/2018 08:01 AM, Clément Péron wrote: > Hi, > > The patch "net: stmmac: socfpga: add additional ocp reset line for > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > board. > > When I boot i have this issue : > > socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 > socfpga-dwmac: probe of ff702000.ethernet failed with error -2 > > Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue. > Are you sure? I just booted v4.9.124 and did not see any errors. The error should not appear because the commit is using devm_reset_control_get_optional(). Dinh