From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77E99C433EF for ; Tue, 5 Jul 2022 13:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mx61V4IfFeK5hGsyZtMfK/mc5Pd9Rqf5uI0Z/NwW7Gs=; b=4+7hYEOQsW77zq MlfFiB8xDNzB5TAi0qOfwYG7rqMZPNhzleL8rK72PeA/8mduNZWlnxhiNMJWMtTOmFRbtRWxzxbho tLr60DOYmwDaCfK0JzE9UncbGKXQwJfja/X65EbeG+sr7Nq17G8WXuYNTW3VuSj4j6IVQQZCx6BPc ESb0ntHBwOzLz0EqnWr4yRmuqYW2KPyRoUiF6gme5vj1+80rRUfNQQ0gnoI8rmQTL7+pEylItu+IM WrDKaUXbj39+tA2ecoYZkdvITvNvI+wJYG5AWyCZSDpRAhdKGKBbPjggdTRK2df6f0CayT9xO1INc /OHqRHB3QBt8K98/VBIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8iYq-000TuQ-H6; Tue, 05 Jul 2022 13:25:52 +0000 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8iYm-000TtS-6e for linux-arm-kernel@lists.infradead.org; Tue, 05 Jul 2022 13:25:49 +0000 Received: by mail-qk1-x72a.google.com with SMTP id n10so8623344qkn.10 for ; Tue, 05 Jul 2022 06:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=HguDNM2ryvAwNvVw3X1nI4XYjogH/9AJf4v+v8SPiNI=; b=x5yYdvsCXmmpnDNQl6naFlMQS/XRzVGIgeWc3mM+T8ojt0HUsx3I/0C3QQOgxcxjuu eWmplPF2CphWovJNTR+eM3fzJw4LWakoEBBftPkKE16eO/3hIMGeA5KSzD4WzDI6CkLq qmj/lTzWFtbfjk0cRznfTV29uqA/FGSCN7xoJ9CNoYG+Zx6C03bc8ogsKCk3/fr+ncpz dwPmPs/aYBdU3juKCgoH+c8Macu89wunr9nPQdb500ER4801Nb3lWsojMbpNv4HVXNZ+ WY1khmc6o99lem14pH93q/kJ2LGDvcqERTysOIvnDdLQUDIaMPOh/3a2kWiEYNBJt72P HqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=HguDNM2ryvAwNvVw3X1nI4XYjogH/9AJf4v+v8SPiNI=; b=Yy49fBS/Mud3ZLqVMQlHjWSfKSpRQaIPRD4U+F2BOMg7xa6KRtosbNEkvDp9foc40r 8KaEtgdQHV7QRxB/oxOBGDdkDaAOQPL9JB3ufkE4xfPZ7qT0/223lS1YT13uCKLgSGQc +6R7Lx63hhqvftKgfdwrCGo0alZW2RH9vCSCeLTpD1AwrKH/KL6aXD88RcMIup0wgan5 DH/TE+/Eu8tA7UTlggUcci8C9NtH3gkzOeNmIhIMNbK4lhTxdWywkxu55NVyuMShx0vq ZXO05Ms/BG5tniCaJNgLiM3/9v8hNhRSON9fwiUyPhiWlHFpdlT1gUHQTDm4hhFz5BdX ohnA== X-Gm-Message-State: AJIora+W/njTJdyBR2efuZF2MSuoJF8bXDFiOdA+STbfGMIPyBX000ud JOXl6TJKKGBzuSYv37w31ud0Ig== X-Google-Smtp-Source: AGRyM1unglZsJhJldcMdtSkf5ZhX/veAVjhQpvw4NWTnuEx/5DV1Gt52xS0AcdDfqVPRxC8uD780IQ== X-Received: by 2002:a37:db11:0:b0:6ae:f350:cbe0 with SMTP id e17-20020a37db11000000b006aef350cbe0mr23298323qki.196.1657027546710; Tue, 05 Jul 2022 06:25:46 -0700 (PDT) Received: from nicolas-tpx395.localdomain (mtl.collabora.ca. [66.171.169.34]) by smtp.gmail.com with ESMTPSA id de16-20020a05620a371000b006b46997c0a9sm4244131qkb.72.2022.07.05.06.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 06:25:45 -0700 (PDT) Message-ID: <61e26a184b87dea6b17d3ba7c4437da29486e167.camel@ndufresne.ca> Subject: Re: [PATCH] media: videobuf2: add V4L2_BUF_FLAG_CODECCONFIG flag From: Nicolas Dufresne To: Dave Stevenson Cc: Ming Qian , Mauro Carvalho Chehab , Hans Verkuil , Shawn Guo , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Linux Media Mailing List , LKML , Linux ARM Date: Tue, 05 Jul 2022 09:25:43 -0400 In-Reply-To: References: <20220628021909.14620-1-ming.qian@nxp.com> User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_062548_284456_2ABBD129 X-CRM114-Status: GOOD ( 39.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgbWFyZGkgMDUganVpbGxldCAyMDIyIMOgIDEzOjM0ICswMTAwLCBEYXZlIFN0ZXZlbnNvbiBh IMOpY3JpdMKgOgo+IEhpIE1pbmcgYW5kIE5pY29sYXMKPiAKPiBPbiBNb24sIDQgSnVsIDIwMjIg YXQgMTY6NTMsIE5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPiB3cm90ZToK PiA+IAo+ID4gTGUgbWFyZGkgMjgganVpbiAyMDIyIMOgIDEwOjE5ICswODAwLCBNaW5nIFFpYW4g YSDDqWNyaXQgOgo+ID4gPiBCeSBzZXR0aW5nIHRoZSBWNEwyX0JVRl9GTEFHX0NPREVDQ09ORklH IGZsYWcsCj4gPiA+IHVzZXItc3BhY2Ugc2hvdWxkIGJlIGFibGUgdG8gaGludCBkZWNvZGVyCj4g PiA+IHRoZSB2YjIgb25seSBjb250YWlucyBjb2RlYyBjb25maWcgaGVhZGVyLAo+ID4gPiBidXQg ZG9lcyBub3QgY29udGFpbiBhbnkgZnJhbWUgZGF0YS4KPiA+ID4gSXQncyBvbmx5IHVzZWQgZm9y IHBhcnNpbmcgaGVhZGVyLCBhbmQgY2FuJ3QgYmUgZGVjb2RlZC4KPiA+IAo+ID4gVGhpcyBpcyBj b3BpZWQgZnJvbSBPTVggc3BlY2lmaWNhdGlvbi4gSSB0aGluayB3ZSB3ZSBpbXBvcnQgdGhpcywg d2Ugc2hvdWxkIGF0Cj4gPiBsZWFzdCByZWZlciB0byB0aGUgb3JpZ2luYWwuCj4gPiAKPiA+ID4g Cj4gPiA+IEN1cnJlbnQsIGl0J3MgdXN1YWxseSB1c2VkIGJ5IGFuZHJvaWQuCj4gPiA+IAo+ID4g PiBTaWduZWQtb2ZmLWJ5OiBNaW5nIFFpYW4gPG1pbmcucWlhbkBueHAuY29tPgo+ID4gPiAtLS0K PiA+ID4gIERvY3VtZW50YXRpb24vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvYnVmZmVyLnJzdCB8 IDkgKysrKysrKysrCj4gPiA+ICBpbmNsdWRlL3VhcGkvbGludXgvdmlkZW9kZXYyLmggICAgICAg ICAgICAgICAgICAgfCAyICsrCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMo KykKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkv bWVkaWEvdjRsL2J1ZmZlci5yc3QgYi9Eb2N1bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEv djRsL2J1ZmZlci5yc3QKPiA+ID4gaW5kZXggNDYzOGVjNjRkYjAwLi5hY2RjNDU1NmY0ZjQgMTAw NjQ0Cj4gPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvYnVm ZmVyLnJzdAo+ID4gPiArKysgYi9Eb2N1bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRs L2J1ZmZlci5yc3QKPiA+ID4gQEAgLTYwNyw2ICs2MDcsMTUgQEAgQnVmZmVyIEZsYWdzCj4gPiA+ ICAgICAgIHRoZSBmb3JtYXQuIEFueSBzdWJzZXF1ZW50IGNhbGwgdG8gdGhlCj4gPiA+ICAgICAg IDpyZWY6YFZJRElPQ19EUUJVRiA8VklESU9DX1FCVUY+YCBpb2N0bCB3aWxsIG5vdCBibG9jayBh bnltb3JlLAo+ID4gPiAgICAgICBidXQgcmV0dXJuIGFuIGBgRVBJUEVgYCBlcnJvciBjb2RlLgo+ ID4gPiArICAgICogLi4gX2BWNEwyLUJVRi1GTEFHLUNPREVDQ09ORklHYDoKPiA+ID4gKwo+ID4g PiArICAgICAgLSBgYFY0TDJfQlVGX0ZMQUdfQ09ERUNDT05GSUdgYAo+ID4gPiArICAgICAgLSAw eDAwMjAwMDAwCj4gPiA+ICsgICAgICAtIFRoaXMgZmxhZyBtYXkgYmUgc2V0IHdoZW4gdGhlIGJ1 ZmZlciBvbmx5IGNvbnRhaW5zIGNvZGVjIGNvbmZpZwo+ID4gPiArICAgIGhlYWRlciwgYnV0IGRv ZXMgbm90IGNvbnRhaW4gYW55IGZyYW1lIGRhdGEuIFVzdWFsbHkgdGhlIGNvZGVjIGNvbmZpZwo+ ID4gPiArICAgIGhlYWRlciBpcyBtZXJnZWQgdG8gdGhlIG5leHQgaWRyIGZyYW1lLCB3aXRoIHRo ZSBmbGFnCj4gPiA+ICsgICAgYGBWNEwyX0JVRl9GTEFHX0tFWUZSQU1FYGAsIGJ1dCB0aGVyZSBp cyBzdGlsbCBzb21lIHNjZW5lcyB0aGF0IHdpbGwKPiA+ID4gKyAgICBzcGxpdCB0aGUgaGVhZGVy IGFuZCBxdWV1ZSBpdCBzZXBhcmF0ZWx5Lgo+ID4gCj4gPiBJIHRoaW5rIHRoZSBkb2N1bWVudGF0 aW9uIGlzIGNsZWFyLiBOb3csIGlmIGEgZHJpdmVyIHVzZXMgdGhpcywgd2lsbCBleGlzdGluZwo+ ID4gdXNlcmxhbmQgKHBlcmhhcHMgZ29vZCB0byBjaGVjayBHU3RyZWFtZXIsIEZGTVBFRyBhbmQg Q2hyb21pdW0gPykgd2lsbCBicmVhayA/Cj4gPiBTbyB3ZSBuZWVkIGV4aXN0aW5nIGRyaXZlciB0 byBkbyB0aGlzIHdoZW4gZmxhZ2dlZCB0bywgYW5kIGp1c3QgY29weS9hcHBlbmQgd2hlbgo+ID4g dGhlIHVzZXJsYW5kIGRpZG4ndCBvcHQtaW4gdGhhdCBmZWF0dXJlID8KPiAKPiBUaGUgY29tbWl0 IHRleHQgc2F5cyBpdCBpcyBmb3IgdXNlcnNwYWNlIGZlZWRpbmcgZGF0YSBpbnRvIGEgdmlkZW8K PiBkZWNvZGVyLCBzbyBpdCdzIGEgdXNlcnNwYWNlIGNob2ljZSBpbnN0ZWFkIG9mIGRyaXZlci4K Ckkgc2VlLCB0aGUgc3BlYyBuZWVkcyB0byBiZSBtb3JlIGNsZWFyIHRoZW4uCgo+IAo+IEZvciBl bmNvZGVycyB0aGVyZSBpcyBhbHJlYWR5IFY0TDJfQ0lEX01QRUdfVklERU9fSEVBREVSX01PREUg WzFdCj4gd2hpY2ggYWxsb3dzIGZvciBWNEwyX01QRUdfVklERU9fSEVBREVSX01PREVfU0VQQVJB VEUgb3IKPiBWNEwyX01QRUdfVklERU9fSEVBREVSX01PREVfSk9JTkVEX1dJVEhfMVNUX0ZSQU1F LiBGRm1wZWcgc2VsZWN0cwo+IF9TRVBBUkFURSBieSBkZWZhdWx0IFsyXSwgd2hpbHN0IHRoZSBk ZWZhdWx0IGlzIG5vcm1hbGx5Cj4gX0pPSU5FRF9XSVRIXzFTVF9GUkFNRS4KCkkgZGlkIG1pc3Mg dGhlIGFkZGl0aW9uIG9mIHRoaXMgQVBJLCB0aGFua3MgZm9yIHRoZSByZW1pbmRlci4gVGhlIHBy b2JsZW0gcmlnaHQKbm93IGlzIHRoYXQgdGhpbmdzIGFyZSBiZWluZyBhZGRlZCB3aXRoIHRoZSBu ZWVkZWQgY3Jvc3MtcmVmZXJlbmNlLgoKPiAKPiBJdCBkb2VzIHJhaXNlIHRoZSBxdWVzdGlvbiBh cyB0byB3aGV0aGVyIGFsbCBkZWNvZGVycyB3aWxsIHN1cHBvcnQKPiBoZWFkZXIgYnl0ZSBvbmx5 IGJ1ZmZlcnMsIGFuZCBkb2VzIHRoZXJlIG5lZWQgdG8gYmUgYSBjYXBhYmlsaXRpZXMKPiBmbGFn IHRvIGRlbm90ZSB0aGF0IGl0IGlzIHN1cHBvcnRlZC4KPiBBbmQgc2hvdWxkIGVuY29kZXJzIGlu IFY0TDJfTVBFR19WSURFT19IRUFERVJfTU9ERV9TRVBBUkFURSBtb2RlIHNldAo+IGl0IG9uIHRo ZSBoZWFkZXJzIG9ubHkgYnVmZmVycz8KCldoYXQgYWJvdXQ6Ci0gRG9jdW1lbnQgYmV0dGVyIHRo YXQgaW4gYWJzZW5jZSBvZiBWNEwyX0NJRF9NUEVHX1ZJREVPX0hFQURFUl9NT0RFIGluIGEKZHJp dmVyLCBWNEwyX01QRUdfVklERU9fSEVBREVSX01PREVfSk9JTkVEX1dJVEhfMVNUX0ZSQU1FIGlz IHRvIGJlIGFzc3VtZWQKLSBEb2N1bWVudCB0aGF0IGluIFY0TDJfTVBFR19WSURFT19IRUFERVJf TU9ERV9TRVBBUkFURSwgZHJpdmVyIHNob3VsZCBzaWduYWwKdGhlIGhlYWRlciBidWZmZXIgd2l0 aCB0aGUgbmV3bHkgYWRkZWQgYnVmZmVyIGZsYWcgKEkgd291bGQgc3VnZ2VzdApWNEwyX0JVRl9G TEFHX0hFQURFUlNfT05MWSkKLSBEb2N1bWVudCBmb3IgZWFjaCBzdXBwb3J0IENPREVDcyBpZiBW NEwyX0NJRF9NUEVHX1ZJREVPX0hFQURFUl9NT0RFIGNhbiBiZQpzdXBwb3J0ZWQsIGFuZCB0aGUg ZXhwZWN0ZWQgaGVhZGVycyBhbmQgdGhlIHBhY2tpbmcgb2YgdGhlc2UgCi0gRG9jdW1lbnQgdGhh dCBkZWNvZGVycyB0aGF0IGRpZG4ndCBpbXBsZW1lbnQgVjRMMl9DSURfTVBFR19WSURFT19IRUFE RVJfTU9ERQpzaG91bGQgYmUgYXNzdW1lZCB0byBvbmx5IHN1cHBvcnQgClY0TDJfTVBFR19WSURF T19IRUFERVJfTU9ERV9KT0lORURfV0lUSF8xU1RfRlJBTUUgZGVjb2RpbmcgKGV2ZW4gdGhvdWdo IGl0CmFsbG93ZWQgdG8gc3VwcG9ydCBhbnkgYWxpZ25tZW50LCBldmVuIHJhbmRvbSkuCi0gQ3Jv c3MtcmVmZXJlbmNlIFY0TDJfQ0lEX01QRUdfVklERU9fSEVBREVSX01PREUgaW50byB0aGUgbmV3 IGZsYWcKZG9jdW1lbnRhdGlvbiAod2hhdGV2ZXIgdGhpcyBuZXcgZmxhZyB3aWxsIGJlIGNhbGxl ZCkuCgo+IAo+IEEgbnVtYmVyIG9mIHVuZGVmaW5lZCBlbGVtZW50cyBvZiBob3cgdGhpcyBzaG91 bGQgYmUgaW1wbGVtZW50ZWQvdXNlZCA6LSgKPiAKPiAgIERhdmUKPiAKPiBbMV0gaHR0cHM6Ly93 d3cua2VybmVsLm9yZy9kb2MvaHRtbC9sYXRlc3QvdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvZXh0 LWN0cmxzLWNvZGVjLmh0bWwKPiBbMl0gaHR0cHM6Ly9naXRodWIuY29tL0ZGbXBlZy9GRm1wZWcv YmxvYi9tYXN0ZXIvbGliYXZjb2RlYy92NGwyX20ybV9lbmMuYyNMMTk2Cgo+IAo+ID4gPiAgICAg ICogLi4gX2BWNEwyLUJVRi1GTEFHLVJFUVVFU1QtRkRgOgo+ID4gPiAKPiA+ID4gICAgICAgIC0g YGBWNEwyX0JVRl9GTEFHX1JFUVVFU1RfRkRgYAo+ID4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91 YXBpL2xpbnV4L3ZpZGVvZGV2Mi5oIGIvaW5jbHVkZS91YXBpL2xpbnV4L3ZpZGVvZGV2Mi5oCj4g PiA+IGluZGV4IDUzMTFhYzRmZGUzNS4uODcwOGVmMjU3NzEwIDEwMDY0NAo+ID4gPiAtLS0gYS9p bmNsdWRlL3VhcGkvbGludXgvdmlkZW9kZXYyLmgKPiA+ID4gKysrIGIvaW5jbHVkZS91YXBpL2xp bnV4L3ZpZGVvZGV2Mi5oCj4gPiA+IEBAIC0xMTMxLDYgKzExMzEsOCBAQCBzdGF0aWMgaW5saW5l IF9fdTY0IHY0bDJfdGltZXZhbF90b19ucyhjb25zdCBzdHJ1Y3QgdGltZXZhbCAqdHYpCj4gPiA+ ICAjZGVmaW5lIFY0TDJfQlVGX0ZMQUdfVFNUQU1QX1NSQ19TT0UgICAgICAgICAweDAwMDEwMDAw Cj4gPiA+ICAvKiBtZW0ybWVtIGVuY29kZXIvZGVjb2RlciAqLwo+ID4gPiAgI2RlZmluZSBWNEwy X0JVRl9GTEFHX0xBU1QgICAgICAgICAgICAgICAgICAgMHgwMDEwMDAwMAo+ID4gPiArLyogQnVm ZmVyIG9ubHkgY29udGFpbnMgY29kZWMgaGVhZGVyICovCj4gPiA+ICsjZGVmaW5lIFY0TDJfQlVG X0ZMQUdfQ09ERUNDT05GSUcgICAgICAgICAgICAweDAwMjAwMDAwCj4gPiA+ICAvKiByZXF1ZXN0 X2ZkIGlzIHZhbGlkICovCj4gPiA+ICAjZGVmaW5lIFY0TDJfQlVGX0ZMQUdfUkVRVUVTVF9GRCAg ICAgICAgICAgICAweDAwODAwMDAwCj4gPiA+IAo+ID4gCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD559CCA47B for ; Tue, 5 Jul 2022 13:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbiGENvg (ORCPT ); Tue, 5 Jul 2022 09:51:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbiGENvR (ORCPT ); Tue, 5 Jul 2022 09:51:17 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2BDC242 for ; Tue, 5 Jul 2022 06:25:47 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id g1so8631460qkl.9 for ; Tue, 05 Jul 2022 06:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=HguDNM2ryvAwNvVw3X1nI4XYjogH/9AJf4v+v8SPiNI=; b=x5yYdvsCXmmpnDNQl6naFlMQS/XRzVGIgeWc3mM+T8ojt0HUsx3I/0C3QQOgxcxjuu eWmplPF2CphWovJNTR+eM3fzJw4LWakoEBBftPkKE16eO/3hIMGeA5KSzD4WzDI6CkLq qmj/lTzWFtbfjk0cRznfTV29uqA/FGSCN7xoJ9CNoYG+Zx6C03bc8ogsKCk3/fr+ncpz dwPmPs/aYBdU3juKCgoH+c8Macu89wunr9nPQdb500ER4801Nb3lWsojMbpNv4HVXNZ+ WY1khmc6o99lem14pH93q/kJ2LGDvcqERTysOIvnDdLQUDIaMPOh/3a2kWiEYNBJt72P HqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=HguDNM2ryvAwNvVw3X1nI4XYjogH/9AJf4v+v8SPiNI=; b=RBU/XP1G/qrAvVI8ohX1bWEYZGQyC8HjelDu6A2yGKA7MpZZNaBhFZt0qEnULrA3xF hyWKAPTFPJIa3rUZWkKkrebVF0twGEKVgYkXsMCRxXs9LlYTJ7v2d+6ScQ7RTGGkdd3Q Zbwcwp8gfU4osFfbxTBwNxzMNfPNcJhgzcy+M/eaU0Ya4nQNKBBWb7aMqBSyKfXH/9fo DkIff8dpdXbNDV7MHCS5loqQr3cjkYNVaphWXgdbMXTVNvVe7waFJk266R1RXX5+bFg5 7ZyuALU211FIQo8TRgRNWN2Ll3jt5lcDbXaa+n7Y+oGZSO9Bq5Kf0sOXjYM0uDlzx8wc UJ6w== X-Gm-Message-State: AJIora9p9h27xdOEoKQ6U/GkCDliTBNE9X29INCo1nNAj4an0pptAPjj W8BP9KXFDE9nJL1EeHPjyucl9w== X-Google-Smtp-Source: AGRyM1unglZsJhJldcMdtSkf5ZhX/veAVjhQpvw4NWTnuEx/5DV1Gt52xS0AcdDfqVPRxC8uD780IQ== X-Received: by 2002:a37:db11:0:b0:6ae:f350:cbe0 with SMTP id e17-20020a37db11000000b006aef350cbe0mr23298323qki.196.1657027546710; Tue, 05 Jul 2022 06:25:46 -0700 (PDT) Received: from nicolas-tpx395.localdomain (mtl.collabora.ca. [66.171.169.34]) by smtp.gmail.com with ESMTPSA id de16-20020a05620a371000b006b46997c0a9sm4244131qkb.72.2022.07.05.06.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 06:25:45 -0700 (PDT) Message-ID: <61e26a184b87dea6b17d3ba7c4437da29486e167.camel@ndufresne.ca> Subject: Re: [PATCH] media: videobuf2: add V4L2_BUF_FLAG_CODECCONFIG flag From: Nicolas Dufresne To: Dave Stevenson Cc: Ming Qian , Mauro Carvalho Chehab , Hans Verkuil , Shawn Guo , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Linux Media Mailing List , LKML , Linux ARM Date: Tue, 05 Jul 2022 09:25:43 -0400 In-Reply-To: References: <20220628021909.14620-1-ming.qian@nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mardi 05 juillet 2022 =C3=A0 13:34 +0100, Dave Stevenson a =C3=A9crit=C2= =A0: > Hi Ming and Nicolas >=20 > On Mon, 4 Jul 2022 at 16:53, Nicolas Dufresne wrot= e: > >=20 > > Le mardi 28 juin 2022 =C3=A0 10:19 +0800, Ming Qian a =C3=A9crit : > > > By setting the V4L2_BUF_FLAG_CODECCONFIG flag, > > > user-space should be able to hint decoder > > > the vb2 only contains codec config header, > > > but does not contain any frame data. > > > It's only used for parsing header, and can't be decoded. > >=20 > > This is copied from OMX specification. I think we we import this, we sh= ould at > > least refer to the original. > >=20 > > >=20 > > > Current, it's usually used by android. > > >=20 > > > Signed-off-by: Ming Qian > > > --- > > > Documentation/userspace-api/media/v4l/buffer.rst | 9 +++++++++ > > > include/uapi/linux/videodev2.h | 2 ++ > > > 2 files changed, 11 insertions(+) > > >=20 > > > diff --git a/Documentation/userspace-api/media/v4l/buffer.rst b/Docum= entation/userspace-api/media/v4l/buffer.rst > > > index 4638ec64db00..acdc4556f4f4 100644 > > > --- a/Documentation/userspace-api/media/v4l/buffer.rst > > > +++ b/Documentation/userspace-api/media/v4l/buffer.rst > > > @@ -607,6 +607,15 @@ Buffer Flags > > > the format. Any subsequent call to the > > > :ref:`VIDIOC_DQBUF ` ioctl will not block anymore, > > > but return an ``EPIPE`` error code. > > > + * .. _`V4L2-BUF-FLAG-CODECCONFIG`: > > > + > > > + - ``V4L2_BUF_FLAG_CODECCONFIG`` > > > + - 0x00200000 > > > + - This flag may be set when the buffer only contains codec con= fig > > > + header, but does not contain any frame data. Usually the codec c= onfig > > > + header is merged to the next idr frame, with the flag > > > + ``V4L2_BUF_FLAG_KEYFRAME``, but there is still some scenes that = will > > > + split the header and queue it separately. > >=20 > > I think the documentation is clear. Now, if a driver uses this, will ex= isting > > userland (perhaps good to check GStreamer, FFMPEG and Chromium ?) will = break ? > > So we need existing driver to do this when flagged to, and just copy/ap= pend when > > the userland didn't opt-in that feature ? >=20 > The commit text says it is for userspace feeding data into a video > decoder, so it's a userspace choice instead of driver. I see, the spec needs to be more clear then. >=20 > For encoders there is already V4L2_CID_MPEG_VIDEO_HEADER_MODE [1] > which allows for V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE or > V4L2_MPEG_VIDEO_HEADER_MODE_JOINED_WITH_1ST_FRAME. FFmpeg selects > _SEPARATE by default [2], whilst the default is normally > _JOINED_WITH_1ST_FRAME. I did miss the addition of this API, thanks for the reminder. The problem r= ight now is that things are being added with the needed cross-reference. >=20 > It does raise the question as to whether all decoders will support > header byte only buffers, and does there need to be a capabilities > flag to denote that it is supported. > And should encoders in V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE mode set > it on the headers only buffers? What about: - Document better that in absence of V4L2_CID_MPEG_VIDEO_HEADER_MODE in a driver, V4L2_MPEG_VIDEO_HEADER_MODE_JOINED_WITH_1ST_FRAME is to be assumed - Document that in V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE, driver should sign= al the header buffer with the newly added buffer flag (I would suggest V4L2_BUF_FLAG_HEADERS_ONLY) - Document for each support CODECs if V4L2_CID_MPEG_VIDEO_HEADER_MODE can b= e supported, and the expected headers and the packing of these=20 - Document that decoders that didn't implement V4L2_CID_MPEG_VIDEO_HEADER_M= ODE should be assumed to only support=20 V4L2_MPEG_VIDEO_HEADER_MODE_JOINED_WITH_1ST_FRAME decoding (even though it allowed to support any alignment, even random). - Cross-reference V4L2_CID_MPEG_VIDEO_HEADER_MODE into the new flag documentation (whatever this new flag will be called). >=20 > A number of undefined elements of how this should be implemented/used :-( >=20 > Dave >=20 > [1] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ct= rls-codec.html > [2] https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/v4l2_m2m_enc.= c#L196 >=20 > > > * .. _`V4L2-BUF-FLAG-REQUEST-FD`: > > >=20 > > > - ``V4L2_BUF_FLAG_REQUEST_FD`` > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/vide= odev2.h > > > index 5311ac4fde35..8708ef257710 100644 > > > --- a/include/uapi/linux/videodev2.h > > > +++ b/include/uapi/linux/videodev2.h > > > @@ -1131,6 +1131,8 @@ static inline __u64 v4l2_timeval_to_ns(const st= ruct timeval *tv) > > > #define V4L2_BUF_FLAG_TSTAMP_SRC_SOE 0x00010000 > > > /* mem2mem encoder/decoder */ > > > #define V4L2_BUF_FLAG_LAST 0x00100000 > > > +/* Buffer only contains codec header */ > > > +#define V4L2_BUF_FLAG_CODECCONFIG 0x00200000 > > > /* request_fd is valid */ > > > #define V4L2_BUF_FLAG_REQUEST_FD 0x00800000 > > >=20 > >=20