From: Jens Axboe <axboe@kernel.dk>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Hou Tao <houtao1@huawei.com>
Subject: Re: [PATCH] blk-throttle: fix infinite throttling caused by non-cascading timer wheel
Date: Mon, 19 Sep 2016 15:11:10 -0600 [thread overview]
Message-ID: <61ec807a-96ed-5363-7e0c-0ee46c3b70f4@kernel.dk> (raw)
In-Reply-To: <20160919210645.GE12537@redhat.com>
On 09/19/2016 03:06 PM, Vivek Goyal wrote:
> On Tue, Sep 13, 2016 at 09:46:46AM -0400, Vivek Goyal wrote:
>>
>> Hi Hou Tao,
>>
>> [ CC Tejun and Thomas ]
>>
>> Thanks for the patch. I can reproduce it. I am wondering that why are you
>> doing so many checks. Can't we just check if throttle group is empty or
>> not. If it is empty and slice has expired, then start a new slice. If
>> throttle group is not empty, then we know slice has to be an active slice
>> and should be extended (despite the fact that it might have expired
>> because timer function got called later than we expected it to be).
>>
>> Can you please try following patch. It seems to resolve the issue for me.
>>
>> Vivek
>
> Hi Jens,
>
> Can you please pick this patch. It seems to fix the reported issued.
> Please let me know if you prefer a separate posting.
I'll apply it, thanks Vivek.
--
Jens Axboe
next prev parent reply other threads:[~2016-09-19 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 6:45 [PATCH] blk-throttle: fix infinite throttling caused by non-cascading timer wheel Hou Tao
2016-09-13 13:46 ` Vivek Goyal
2016-09-17 1:26 ` Hou Tao
2016-09-19 21:06 ` Vivek Goyal
2016-09-19 21:11 ` Jens Axboe [this message]
2016-09-27 12:57 ` Vivek Goyal
2016-09-27 14:10 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ec807a-96ed-5363-7e0c-0ee46c3b70f4@kernel.dk \
--to=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.