From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C4F6C433F5 for ; Mon, 10 Jan 2022 15:00:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 28B7881DE9; Mon, 10 Jan 2022 16:00:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fUd3fmUs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4CB0C83063; Mon, 10 Jan 2022 16:00:37 +0100 (CET) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3C57281D5D for ; Mon, 10 Jan 2022 16:00:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-ot1-x32c.google.com with SMTP id 45-20020a9d0a30000000b0058f1a6df088so15288994otg.4 for ; Mon, 10 Jan 2022 07:00:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=23tyN224LnbsQDZHZVZeKjc5mPBV4Ut0MZTvJ+WTj6M=; b=fUd3fmUsBXVAeVQEOqPfNpl6JPpKA5YKtS4ERaOqiCxBeUtic2J5/bT9u9sRflJ0uF 2JSm306pjoMOMrxMc1W97R+Kc3AVwqmkHmEVcIgJ5+6Argwd5kUecSf5lL49tCm4eyIy vxev0SLduH9dlLRhGxYcc4hnfNnk7pxc+NcwXwirZ9cMaKryjjNtG7+3N5Cd3vQwX8pC +agmRdRCqEaAepiWf4fivb93eamOyI9eHQnEkiFrfmn4XoK89XH7yej+79mXZ8Y9W6IJ m6cVaEVTs67MZx/f5j9NDU9J5215EuDU/mOPcW8FxCkKBBRxkxSpGFMDMA+/oEAJXnWx 2j/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=23tyN224LnbsQDZHZVZeKjc5mPBV4Ut0MZTvJ+WTj6M=; b=QKHfAYavnBNqpFRNNISlVq8UeWP/OUvhPfeRTRHLHDpH2JBkb+jNTPFpy5E8i9d1/K D8aEdri+L406bY+b0+6Cx2/O4KqjWl4w3Fm0HuHm/bEUA6Q3WlRWBdIH5XsFF8ODjMct v8toyLS8+vStv2pVXAM5QO/eCETVvv75MPHJUpnN5ps/h3aZhWXwI+Uc+k9KeFCR2yXD kVAQtKhzjtziHiUoNMBsA3Waz6p52j+2g+/8BvMcpg9PK4wqvE7NRRRgUnSe6fCgWZmG g3OoERNAKrZfJF+0MgBc8d4Y2rVa5ii5xBb/kMR2H/hg+OXUNDYz4KXWxAOhSG2EGr9t zwOg== X-Gm-Message-State: AOAM531Q1npOAwQft4+ZwFhW5t29OypWMSyjPp+pr99tr8OvIXgTr0iK Hhvb5SZeMXGM3kONCy6dsWIjCxqY5bM= X-Google-Smtp-Source: ABdhPJz2uDRFg7DEHz7YKkNCJXFHWVPInQkxPsaMjsrumQ95lypkDFCA7iUvmoDDQ+hU1uxBGbY1Cg== X-Received: by 2002:a9d:53cb:: with SMTP id i11mr107919oth.344.1641826831332; Mon, 10 Jan 2022 07:00:31 -0800 (PST) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q13sm1476759otf.76.2022.01.10.07.00.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 07:00:30 -0800 (PST) Subject: Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers To: Heinrich Schuchardt , Tom Rini Cc: Simon Glass , Donald Chan , Marc Kleine-Budde , u-boot@lists.denx.de References: <20220109143940.167046-1-heinrich.schuchardt@canonical.com> From: "Alex G." Message-ID: <61f8f122-59cb-686d-440f-250aa428dfc9@gmail.com> Date: Mon, 10 Jan 2022 09:00:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220109143940.167046-1-heinrich.schuchardt@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: > The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. > Our code drops the const qualifier leading to > > In file included from tools/lib/rsa/rsa-sign.c:1: > ./tools/../lib/rsa/rsa-sign.c: In function ‘rsa_add_verify_data’: > ./tools/../lib/rsa/rsa-sign.c:631:13: warning: > assignment discards ‘const’ qualifier from pointer target type > [-Wdiscarded-qualifiers] > 631 | rsa = EVP_PKEY_get0_RSA(pkey); > | ^ > > Add a type conversion. > > Signed-off-by: Heinrich Schuchardt > --- > lib/rsa/rsa-sign.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c > index 44f21416ce..3b6e5f0f86 100644 > --- a/lib/rsa/rsa-sign.c > +++ b/lib/rsa/rsa-sign.c > @@ -628,7 +628,7 @@ int rsa_add_verify_data(struct image_sign_info *info, void *keydest) > if (ret) > goto err_get_pub_key; > > - rsa = EVP_PKEY_get0_RSA(pkey); > + rsa = (RSA *)EVP_PKEY_get0_RSA(pkey); I think it's the wrong path to discard const qualifiers, whether unwillingly or by type punning. I suggest making 'rsa' a "const RSA *" and fixing the downstream users to do the same. Alex > ret = rsa_get_params(rsa, &exponent, &n0_inv, &modulus, &r_squared); > if (ret) > goto err_get_params; >