From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759548AbcHaUhm (ORCPT ); Wed, 31 Aug 2016 16:37:42 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:63188 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754052AbcHaUhk (ORCPT ); Wed, 31 Aug 2016 16:37:40 -0400 From: Arnd Bergmann To: David Howells Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released Date: Wed, 31 Aug 2016 22:37:39 +0200 Message-ID: <6209332.zC1KBURZ66@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <32632.1472675181@warthog.procyon.org.uk> References: <20160831123911.3467676-2-arnd@arndb.de> <20160831123911.3467676-1-arnd@arndb.de> <32632.1472675181@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:aWW9QavYdTQRUeyM3+RVvBC+BfZzupUczB+cIqCO/0+NWmMlqhE 8vy8SxM7mNQwjhBbBb9E7zH6kg/qVQoYRoDiLJTJZ0YeKs7bMNrku5y+5yFKMF/tm9LFqiY MZ2DiZXjEMY6C6PrafpHKi/WHc+PgcNRsfCK0DbOCc5qqZIDgSGxJ0bmMSKf2kEjgPkH9ix 2WmVjA8uXaQ4r4srtathQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:XoJQRtxAy4c=:5GEQsgR5/G93YBBTSOTC8y Y6PdY45RSFCq22KehEeGc32XamyTk/IqcOMhvIuRGMaPcRa4G7+9B5dR7sOvBxS89gdULDXwx Ekf2QVSYcr34RCKeUga6XBIYxatqEz9nlZyTsENWmM0kR9AhrVFHcWCGxz2PFvJYu9Aszpk96 WyZhQKpeRjM/CXOtekgAbBkvC3Mah6FuwabMN+Ts9w8yW+P7nw+ptOXuh8ZJ/gbouW08FOHFI YvgyCPejY7YAm1JpthudgWt6ePPaR9vqH/VFrPiMU4ch7JyOuy28903a9aYz7HmDcXxf5ZDCs 0z+5G4bOQ39RQGzUwhaWS4CPDtyB3G06KdmrRCApYxA+h6ycQDq3/4soANHHJ57ln+eO0yR7U EHlj22Zbp78bK1agXiyNloC+AzzbprvOkSss4L99pqmlfiz3vBmKZHSjGXZfngmDE68JtadFq kzDvEJ+7pDoXXcX0CyJonjbBFJCoih6y1cNV69FEKvG6JwLN53sHivzrkrrehp5EqrZ8y8Tyf pTYSVguQRtofH/7a2/+N86meVtcJ6OGJT+hhA9z+dAFLgA2plpOsKXozC7iN/ukgLpxe0s6Ve Lr4ub0Wn8EThEdmnI4ZY9PqCQZwfozMjwyPv6CmPjy3qyDn2JcxUtzA5T7puW2iOdTxq22p9Y Il2DxKPBrjmabuCWGwrsFe8KWwRiTC2r4bPITzUjzaq3jZKSw9u+b3+y1GG84zQBatzb37gWQ raTUS2dzfWf2Z8FX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 31, 2016 9:26:21 PM CEST David Howells wrote: > Arnd Bergmann wrote: > > > + } else { > > + sched = 0; > > That should be false, not 0, btw. > Right, sorry about that. Do you want me to resend the fixed version, or do you apply and fix it yourself? As patch 1/2 isn't actually meant for net-next anyway, the series doesn't need to stay together. Arnd