From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbcKPLyU (ORCPT ); Wed, 16 Nov 2016 06:54:20 -0500 Received: from gloria.sntech.de ([95.129.55.99]:58709 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbcKPLyS (ORCPT ); Wed, 16 Nov 2016 06:54:18 -0500 From: Heiko Stuebner To: Andy Yan Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/10] ARM: dts: add basic support for Rockchip RK1108 SOC Date: Wed, 16 Nov 2016 12:53:46 +0100 Message-ID: <6212491.PZIkq4o7iJ@phil> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <2204596.BeWafPDT3k@phil> References: <1479124550-24037-1-git-send-email-andy.yan@rock-chips.com> <1479125688-24528-1-git-send-email-andy.yan@rock-chips.com> <2204596.BeWafPDT3k@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 15. November 2016, 12:45:16 CET schrieb Heiko Stuebner: > Am Montag, 14. November 2016, 20:14:48 CET schrieb Andy Yan: > > RK1108 is embedded with an ARM Cortex-A7 single core and a DSP core. > > It is designed for varies application scenario such as car DVR, sports > > DV, secure camera and UAV camera. > > > > This patch add basic support for it with DMAC / UART / CRU / pinctrl / MMC > > enabled. > > > > Signed-off-by: Andy Yan > > Tested-by: Jacob Chen > > > > --- > > > > Changes in v2: > > - fix timer and gic dt description > > - ordering devices by register address > > > > arch/arm/boot/dts/rk1108.dtsi | 428 > > > > ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 428 > > insertions(+) > > > > create mode 100644 arch/arm/boot/dts/rk1108.dtsi > > > > diff --git a/arch/arm/boot/dts/rk1108.dtsi b/arch/arm/boot/dts/rk1108.dtsi > > new file mode 100644 > > index 0000000..636c294 > > --- /dev/null > > +++ b/arch/arm/boot/dts/rk1108.dtsi > > @@ -0,0 +1,428 @@ > > +/* > > + * This file is dual-licensed: you can use it either under the terms > > + * of the GPL or the X11 license, at your option. Note that this dual > > + * licensing only applies to this file, and not this project as a > > + * whole. > > + * > > + * a) This file is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation; either version 2 of the > > + * License, or (at your option) any later version. > > + * > > + * This file is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * Or, alternatively, > > + * > > + * b) Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without > > + * restriction, including without limitation the rights to use, > > + * copy, modify, merge, publish, distribute, sublicense, and/or > > + * sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following > > + * conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > > + * OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +/ { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + compatible = "rockchip,rk1108"; > > + > > + interrupt-parent = <&gic>; > > + > > + aliases { > > + serial0 = &uart0; > > + serial1 = &uart1; > > + serial2 = &uart2; > > + }; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu0: cpu@f00 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a7"; > > + reg = <0xf00>; > > + }; > > + }; > > + > > + arm-pmu { > > + compatible = "arm,cortex-a7-pmu"; > > + interrupts = ; > > + }; > > + > > + > > unnecessary empty line (only 1 please) > > otherwise looks fine now, just needs to wait for fixed clock ids now. after Shawn fixed the clocks, applied now to my dts32 branch with that line removed. Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2 08/10] ARM: dts: add basic support for Rockchip RK1108 SOC Date: Wed, 16 Nov 2016 12:53:46 +0100 Message-ID: <6212491.PZIkq4o7iJ@phil> References: <1479124550-24037-1-git-send-email-andy.yan@rock-chips.com> <1479125688-24528-1-git-send-email-andy.yan@rock-chips.com> <2204596.BeWafPDT3k@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2204596.BeWafPDT3k@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Andy Yan Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org Am Dienstag, 15. November 2016, 12:45:16 CET schrieb Heiko Stuebner: > Am Montag, 14. November 2016, 20:14:48 CET schrieb Andy Yan: > > RK1108 is embedded with an ARM Cortex-A7 single core and a DSP core. > > It is designed for varies application scenario such as car DVR, sports > > DV, secure camera and UAV camera. > > > > This patch add basic support for it with DMAC / UART / CRU / pinctrl / MMC > > enabled. > > > > Signed-off-by: Andy Yan > > Tested-by: Jacob Chen > > > > --- > > > > Changes in v2: > > - fix timer and gic dt description > > - ordering devices by register address > > > > arch/arm/boot/dts/rk1108.dtsi | 428 > > > > ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 428 > > insertions(+) > > > > create mode 100644 arch/arm/boot/dts/rk1108.dtsi > > > > diff --git a/arch/arm/boot/dts/rk1108.dtsi b/arch/arm/boot/dts/rk1108.dtsi > > new file mode 100644 > > index 0000000..636c294 > > --- /dev/null > > +++ b/arch/arm/boot/dts/rk1108.dtsi > > @@ -0,0 +1,428 @@ > > +/* > > + * This file is dual-licensed: you can use it either under the terms > > + * of the GPL or the X11 license, at your option. Note that this dual > > + * licensing only applies to this file, and not this project as a > > + * whole. > > + * > > + * a) This file is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation; either version 2 of the > > + * License, or (at your option) any later version. > > + * > > + * This file is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * Or, alternatively, > > + * > > + * b) Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without > > + * restriction, including without limitation the rights to use, > > + * copy, modify, merge, publish, distribute, sublicense, and/or > > + * sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following > > + * conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > > + * OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +/ { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + compatible = "rockchip,rk1108"; > > + > > + interrupt-parent = <&gic>; > > + > > + aliases { > > + serial0 = &uart0; > > + serial1 = &uart1; > > + serial2 = &uart2; > > + }; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu0: cpu@f00 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a7"; > > + reg = <0xf00>; > > + }; > > + }; > > + > > + arm-pmu { > > + compatible = "arm,cortex-a7-pmu"; > > + interrupts = ; > > + }; > > + > > + > > unnecessary empty line (only 1 please) > > otherwise looks fine now, just needs to wait for fixed clock ids now. after Shawn fixed the clocks, applied now to my dts32 branch with that line removed. Thanks Heiko