From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696F6C1975A for ; Tue, 17 Mar 2020 18:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C45620735 for ; Tue, 17 Mar 2020 18:56:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbgCQS45 (ORCPT ); Tue, 17 Mar 2020 14:56:57 -0400 Received: from www62.your-server.de ([213.133.104.62]:59752 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbgCQS45 (ORCPT ); Tue, 17 Mar 2020 14:56:57 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jEHOZ-0001vg-SC; Tue, 17 Mar 2020 19:56:55 +0100 Received: from [85.7.42.192] (helo=pc-9.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEHOZ-0008LS-K6; Tue, 17 Mar 2020 19:56:55 +0100 Subject: Re: [PATCH v2 bpf-next] selftests/bpf: fix nanosleep for real this time To: Andrii Nakryiko , bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com References: <20200314002743.3782677-1-andriin@fb.com> From: Daniel Borkmann Message-ID: <621281d6-8eb6-79f2-7672-4647e875019e@iogearbox.net> Date: Tue, 17 Mar 2020 19:56:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200314002743.3782677-1-andriin@fb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25754/Tue Mar 17 14:09:15 2020) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 3/14/20 1:27 AM, Andrii Nakryiko wrote: > Amazingly, some libc implementations don't call __NR_nanosleep syscall from > their nanosleep() APIs. Hammer it down with explicit syscall() call and never > get back to it again. Also simplify code for timespec initialization. > > I verified that nanosleep is called w/ printk and in exactly same Linux image > that is used in Travis CI. So it should both sleep and call correct syscall. > > v1->v2: > - math is too hard, fix usec -> nsec convertion (Martin); > - test_vmlinux has explicit nanosleep() call, convert that one as well. > > Fixes: 4e1fd25d19e8 ("selftests/bpf: Fix usleep() implementation") > Signed-off-by: Andrii Nakryiko Applied, thanks!