From: Andrey Okoshkin <a.okoshkin@samsung.com>
To: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, pclouds@gmail.com, l.s.r@web.de,
avarab@gmail.com, krh@redhat.com, rctay89@gmail.com,
Ivan Arishchenko <i.arishchenk@samsung.com>,
Mikhail Labiuk <m.labiuk@samsung.com>
Subject: Re: [PATCH] commit: check result of resolve_ref_unsafe
Date: Thu, 19 Oct 2017 12:33:30 +0300 [thread overview]
Message-ID: <62255b66-67be-e6cf-92e9-bed92c6b2899@samsung.com> (raw)
In-Reply-To: <20171019024919.ram3bzabt5fra2lc@sigill.intra.peff.net>
I also think it's a good idea to record the destination of the updated
symref. But for now the most simple solution is just to catch the
unreadable HEAD error.
Maybe for the future improvement it would be nice to redesign
print_summary passing some ref_transaction results to it.
19.10.2017 05:49, Jeff King wrote:
> TBH, I think the "most right" thing would be to actually capture the ref
> that HEAD points to when we actually make the commit, remember it, and
> then report it here (the whole function of this code is just to say "I
> made a commit on branch X"). But I don't know how much trouble it is
> worth going to for that. It's buried behind a ref_transaction, and I
> don't think builtin/commit.c ever sees the real name (though maybe it
> would be a good feature of the transaction to record the destinations of
> any symrefs we updated).
--
Best regards,
Andrey Okoshkin
next prev parent reply other threads:[~2017-10-19 9:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171018170047epcas2p4310be357e11e194d6d08ac3bdc478ba3@epcas2p4.samsung.com>
2017-10-18 17:00 ` [PATCH] commit: check result of resolve_ref_unsafe Andrey Okoshkin
2017-10-18 18:34 ` Jeff King
2017-10-19 0:41 ` Junio C Hamano
2017-10-19 2:49 ` Jeff King
2017-10-19 9:33 ` Andrey Okoshkin [this message]
2017-10-19 9:36 ` [PATCH v2] " Andrey Okoshkin
2017-10-19 17:44 ` Jeff King
2017-10-19 17:46 ` [PATCH 1/4] test-ref-store: avoid passing NULL to printf Jeff King
2017-10-19 17:47 ` [PATCH 2/4] remote: handle broken symrefs Jeff King
2017-10-19 17:53 ` Jeff King
2017-10-19 17:49 ` [PATCH 3/4] log: handle broken HEAD in decoration check Jeff King
2017-10-19 17:49 ` [PATCH 4/4] worktree: handle broken symrefs in find_shared_symref() Jeff King
2017-10-21 10:49 ` Eric Sunshine
2017-10-21 19:26 ` Jeff King
2017-10-22 0:46 ` Junio C Hamano
2017-10-20 10:40 ` [PATCH v2] commit: check result of resolve_ref_unsafe Andrey Okoshkin
2017-10-20 11:03 ` [PATCH v3] " Andrey Okoshkin
2017-10-20 13:09 ` [PATCH v4] " Andrey Okoshkin
2017-10-21 6:19 ` Jeff King
2017-10-22 0:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62255b66-67be-e6cf-92e9-bed92c6b2899@samsung.com \
--to=a.okoshkin@samsung.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=i.arishchenk@samsung.com \
--cc=krh@redhat.com \
--cc=l.s.r@web.de \
--cc=m.labiuk@samsung.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.